Fix PHP 8.4 deprecations: implicitly nullable parameters
>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3575388. --> Reported by: [sebastix](https://www.drupal.org/user/2943731) >>> <p>When using the module with PHP8.4, you could get quite some `Deprecated function` messages regarding the Implicitly nullable parameter declarations deprecated introduced in the 8.4 release of PHP. See <a href="https://www.php.net/manual/en/migration84.deprecated.php">https://www.php.net/manual/en/migration84.deprecated.php</a>.</p> <p>Code analysis with PHPstan <code>vendor/bin/phpstan analyze web/modules/contrib/danse</code>:</p> <pre> ------ ----------------------------------------------------------------------------------------------------- <br>&nbsp; Line&nbsp;&nbsp; modules/content/src/Plugin/Danse/Content.php&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ ----------------------------------------------------------------------------------------------------- <br>&nbsp; 468&nbsp;&nbsp;&nbsp; Deprecated in PHP 8.4: Parameter #4 $bundle (string) is implicitly nullable via default value null.&nbsp; <br>&nbsp; 723&nbsp;&nbsp;&nbsp; Deprecated in PHP 8.4: Parameter #4 $values (array) is implicitly nullable via default value null.&nbsp;&nbsp; <br> ------ ----------------------------------------------------------------------------------------------------- <br><br> ------ --------------------------------------------------------------------------------------------------------------------------- <br>&nbsp; Line&nbsp;&nbsp; modules/content/src/Plugin/Danse/ContentSettingsTrait.php (in context of class Drupal\danse_content\Plugin\Danse\Content)&nbsp; <br> ------ --------------------------------------------------------------------------------------------------------------------------- <br>&nbsp; 29&nbsp;&nbsp;&nbsp;&nbsp; Deprecated in PHP 8.4: Parameter #2 $bundle (string) is implicitly nullable via default value null.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ --------------------------------------------------------------------------------------------------------------------------- <br><br> ------ ----------------------------------------------------------------------------------------------------------------------------- <br>&nbsp; Line&nbsp;&nbsp; modules/eca/src/Event/BaseEvent.php&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ ----------------------------------------------------------------------------------------------------------------------------- <br>&nbsp; 37&nbsp;&nbsp;&nbsp;&nbsp; Deprecated in PHP 8.4: Parameter #2 $payload (Drupal\danse\PayloadInterface) is implicitly nullable via default value null.&nbsp; <br> ------ ----------------------------------------------------------------------------------------------------- <br>&nbsp; Line&nbsp;&nbsp; modules/content/src/Plugin/Danse/Content.php&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ ----------------------------------------------------------------------------------------------------- <br>&nbsp; 468&nbsp;&nbsp;&nbsp; Deprecated in PHP 8.4: Parameter #4 $bundle (string) is implicitly nullable via default value null.&nbsp; <br>&nbsp; 723&nbsp;&nbsp;&nbsp; Deprecated in PHP 8.4: Parameter #4 $values (array) is implicitly nullable via default value null.&nbsp;&nbsp; <br> ------ ----------------------------------------------------------------------------------------------------- <br><br> ------ --------------------------------------------------------------------------------------------------------------------------- <br>&nbsp; Line&nbsp;&nbsp; modules/content/src/Plugin/Danse/ContentSettingsTrait.php (in context of class Drupal\danse_content\Plugin\Danse\Content)&nbsp; <br> ------ --------------------------------------------------------------------------------------------------------------------------- <br>&nbsp; 29&nbsp;&nbsp;&nbsp;&nbsp; Deprecated in PHP 8.4: Parameter #2 $bundle (string) is implicitly nullable via default value null.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ --------------------------------------------------------------------------------------------------------------------------- <br><br> ------ ----------------------------------------------------------------------------------------------------------------------------- <br>&nbsp; Line&nbsp;&nbsp; modules/eca/src/Event/BaseEvent.php&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ ----------------------------------------------------------------------------------------------------------------------------- <br>&nbsp; 37&nbsp;&nbsp;&nbsp;&nbsp; Deprecated in PHP 8.4: Parameter #2 $payload (Drupal\danse\PayloadInterface) is implicitly nullable via default value null.&nbsp; <br> ------ ----------------------------------------------------------------------------------------------------------------------------- <br><br> ------ ------------------------------------------------------------------------------------------------------------------------------------ <br>&nbsp; Line&nbsp;&nbsp; modules/generic/src/Plugin/Action/DanseEventArbitrary.php&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ ------------------------------------------------------------------------------------------------------------------------------------ <br>&nbsp; 24&nbsp;&nbsp;&nbsp;&nbsp; Deprecated in PHP 8.4: Parameter #2 $account (Drupal\Core\Session\AccountInterface) is implicitly nullable via default value null.&nbsp; <br> ------ ------------------------------------------------------------------------------------------------------------------------------------ <br><br> ------ ------------------------------------------------------------------------------------------------------------------------------------ <br>&nbsp; Line&nbsp;&nbsp; modules/generic/src/Plugin/Action/DanseEventContentEntity.php&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ ------------------------------------------------------------------------------------------------------------------------------------ <br>&nbsp; 24&nbsp;&nbsp;&nbsp;&nbsp; Deprecated in PHP 8.4: Parameter #2 $account (Drupal\Core\Session\AccountInterface) is implicitly nullable via default value null.&nbsp; <br> ------ ------------------------------------------------------------------------------------------------------------------------------------ <br><br> ------ --------------------------------------------------------------------------------------------------- <br>&nbsp; Line&nbsp;&nbsp; src/Cron.php&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ --------------------------------------------------------------------------------------------------- <br>&nbsp; 63&nbsp;&nbsp;&nbsp;&nbsp; Deprecated in PHP 8.4: Parameter #1 $batch (array) is implicitly nullable via default value null.&nbsp; <br> ------ --------------------------------------------------------------------------------------------------- <br><br> ------ ------------------------------------------------------------------------------------------------------------------------------------ <br>&nbsp; Line&nbsp;&nbsp; src/Entity/EventAccess.php&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ ------------------------------------------------------------------------------------------------------------------------------------ <br>&nbsp; 48&nbsp;&nbsp;&nbsp;&nbsp; Deprecated in PHP 8.4: Parameter #3 $account (Drupal\Core\Session\AccountInterface) is implicitly nullable via default value null.&nbsp; <br> ------ ------------------------------------------------------------------------------------------------------------------------------------ <br><br> ------ ---------------------------------------------------------------------------------------------------------------------- <br>&nbsp; Line&nbsp;&nbsp; src/Form/Subscriptions.php&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ ---------------------------------------------------------------------------------------------------------------------- <br>&nbsp; 65&nbsp;&nbsp;&nbsp;&nbsp; Deprecated in PHP 8.4: Parameter #3 $user (Drupal\user\UserInterface) is implicitly nullable via default value null.&nbsp; <br> ------ ---------------------------------------------------------------------------------------------------------------------- <br><br> ------ ---------------------------------------------------------------------------------------------------------------------- <br>&nbsp; Line&nbsp;&nbsp; src/Service.php&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ ---------------------------------------------------------------------------------------------------------------------- <br>&nbsp; 122&nbsp;&nbsp;&nbsp; Deprecated in PHP 8.4: Parameter #1 $user (Drupal\user\UserInterface) is implicitly nullable via default value null.&nbsp; <br> ------ ---------------------------------------------------------------------------------------------------------------------- </pre>
issue