## Summary The public Registration form crashes with a `TypeError` on any site that has a member option group of field type `textfields`. #3596652 (commit `7a01764`) added a `Member` type to `FieldOptionGroup::groupTextFields()`: ```diff - private function groupTextFields($options, &$member) { + private function groupTextFields(array $options, Member &$member) { ``` `Registration::buildForm()` deliberately passes `NULL` as the member when building option fields, because the form is for new members (`src/Form/Registration.php`, the `addOptionFields()` calls for per-member options and global options). That `NULL` is passed through `FieldOptions::addOptionFields()` and `FieldOptionGroup::groupForm()` to `groupTextFields()`. The non-nullable `Member` type then rejects it. The same commit added an `isset($member->options)` check inside the method, so a missing member was clearly meant to be allowed. The type rejects `null` before that check can run. `groupCheckBoxes()` has no type on `$member`, so sites that only use `checkboxes` option groups are not affected. This is why the error shows up on some sites but not others. ## Steps to reproduce 1. On the Member Options configuration, add an option group with field type `textfields` and at least one option. 2. Go to the Registration form (`/members/register`). ## Expected result The Registration form loads, and the `textfields` option group shows empty text fields. ## Actual result The page fails to load, and the following error is logged: ``` TypeError: Drupal\conreg\FieldOptionGroup::groupTextFields(): Argument #2 ($member) must be of type Drupal\conreg\Member, null given, called in .../conreg/src/FieldOptionGroup.php on line 117 in Drupal\conreg\FieldOptionGroup->groupTextFields() (line 176 of .../conreg/src/FieldOptionGroup.php). ``` Backtrace (abridged): ``` #0 src/FieldOptionGroup.php(117): Drupal\conreg\FieldOptionGroup->groupTextFields() #1 src/FieldOptions.php(248): Drupal\conreg\FieldOptionGroup->groupForm() #2 src/Form/Registration.php(724): Drupal\conreg\FieldOptions->addOptionFields() #3 [internal function]: Drupal\conreg\Form\Registration->buildForm() ``` ## Proposed resolution Make `$member` nullable in `FieldOptionGroup::groupForm()`, `groupCheckBoxes()` and `groupTextFields()`, so that it matches the null handling already inside those methods. Also remove the `&` from `$member` in all three methods. Objects are passed by handle, so any changes to the member's properties are seen by the caller without a reference. The reference only matters if a method reassigns the variable itself, and none of them do. `FieldOptions::addOptionFields()` already takes `$member` by value, so even a reassignment couldn't get back to the form. Keeping the `&` suggests the methods might replace the member, and it stops a literal `NULL` being passed directly. ```php public function groupForm(?Member $member, bool $requireMandatory = TRUE) { private function groupCheckBoxes(array $options, ?Member $member, bool $requireMandatory) { private function groupTextFields(array $options, ?Member $member) { ``` Add a test that builds a `textfields` option group with no member. ## Affected modules / components *(optional)* conreg (Registration form / member field options) ## Environment - Drupal version: - Module version: 1.x-dev (after 1.0.0-beta5) - PHP version: - Last known working version: 1.0.0-beta5 (regression introduced in #3596652, commit `7a01764`, which is not yet in a tagged release)