>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3556298. --> Reported by: [star-szr](https://www.drupal.org/user/1167326) Related to !33 !32 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>We should now be able to delete swaths of code from Config Enforce and Config Enforce Devel now that we are using an Off-Canvas dialog (or separate page for non-JS users) to manage enforcement settings. See <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-7"><a href="https://www.drupal.org/project/config_enforce_devel/issues/3188474" title="Status: Closed (fixed)">#3188474: Move the config_enforce form to an off-canvas dialog</a></span>.</p> <p>This issue is only for Config Enforce, the Config Enforce Devel issue is: <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-7"><a href="https://www.drupal.org/project/config_enforce_devel/issues/3556243" title="Status: Closed (fixed)">#3556243: Remove unused code after switching to off-canvas dialog form</a></span></p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Delete unused code.</p> <p>First, <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-7"><a href="https://www.drupal.org/project/config_enforce_devel/issues/3556243" title="Status: Closed (fixed)">#3556243: Remove unused code after switching to off-canvas dialog form</a></span> needs to happen on the Config Enforce Devel side, because many classes depend on classes that we want to delete here.</p> <h5>Legend</h5> <ul> <li>&#10060; = class/method to be deleted</li> <li>&#9989; = update needed</li> <li>&#9888;&#65039; = resolution unclear, needs discussion and careful handling</li> <li>&#128196; = docs updates needed</li> </ul> <h4>Classes to deprecate in 1.x, delete in 2.x</h4> <ul> <li>&#10060; Drupal\config_enforce\Form\AbstractEnforceForm <ul> <li>&#10060; Drupal\config_enforce\Form\EnforceForm (extended by)</li> <li>&#10060; Drupal\config_enforce_devel\Form\EmbeddedEnforceForm (extended by)</li> <li>&#10060; Drupal\config_enforce_devel\Form\ModalEnforceForm (extended by)</li> <li>&#128196; Referenced in inline docs</li> </ul> </li> <li>&#10060; Drupal\config_enforce\Form\EnforceForm <ul> <li>&#9989; Drupal\config_enforce\FormHandler\EnforceFormHandler (referenced by, reference to be removed)</li> <li>&#9989; config_enforce_config_enforce_form_denylist() (referenced by, reference to be removed)</li> </ul> </li> </ul> <h4>Methods to deprecate in 1.x, delete in 2.x</h4> <ul> <li>&#10060; Drupal\config_enforce\FormHandler\AbstractEnforceFormHandler::addEnforceForm() <ul> <li>&#9989; Drupal\config_enforce\FormHandler\EnforceFormHandler::alter() (called from, call needs to be removed)</li> </ul> </li> </ul> <h4>Classes that will be refactored; likely to have methods deprecated in 1.x, deleted in 2.x</h4> <p>(form helper trait updates moved to <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-7"><a href="https://www.drupal.org/project/config_enforce/issues/3556977" title="Status: Closed (fixed)">#3556977: Clean up/refactor FormHelperTrait</a></span>).</p> <h4>Other considerations</h4> <ul> <li>Would it make sense to deprecate then remove <code>hook_config_enforce_form_denylist()</code>? <ul> <li>It was added in <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/config_enforce/-/work_items/3164887" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/config_enforce/-/work_items/3164887</a></span></li> <li>Should probably be addressed in a follow-up issue (to be created)</li> </ul> </li> </ul> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <ul> <li>Delete code</li> <li>Test manually</li> <li>Run automated tests and consider adding more tests</li> </ul> <h3 id="summary-ui-changes">User interface changes</h3> <p>Should be none.</p> <h3 id="summary-api-changes">API changes</h3> <p>There will be removed classes, methods, etc. which we could mark as deprecated on the 1.0.x branch.</p> <h3 id="summary-data-model-changes">Data model changes</h3> <p>Should be none.</p> > Related issue: [Issue #3556243](https://www.drupal.org/node/3556243)