Commit f55c0925 authored by Andreas Mayr's avatar Andreas Mayr Committed by Jonathan Sacksick
Browse files

Issue #3254521 by agoradesign, jsacksick: BuyXGetY::findOrCreateOrderItem()... 

Issue #3254521 by agoradesign, jsacksick: BuyXGetY::findOrCreateOrderItem() leads to NPE on order items without purchased entity.
parent aabafe8e

modules/promotion/src/Plugin/Commerce/PromotionOffer/BuyXGetY.php

+3 −0
Original line number Diff line number Diff line
@@ -576,6 +576,9 @@ class BuyXGetY extends OrderPromotionOfferBase { 
  protected function findOrCreateOrderItem(PurchasableEntityInterface $get_purchasable_entity, array $order_items) {

    foreach ($order_items as $order_item) {

      $purchased_entity = $order_item->getPurchasedEntity();

      if (!$purchased_entity) {

        continue;

      }

      if ($purchased_entity->getEntityTypeId() == $get_purchasable_entity->getEntityTypeId()

          && $purchased_entity->id() == $get_purchasable_entity->id()) {

        return $order_item;