>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3397055. --> Reported by: [larowlan](https://www.drupal.org/user/395439) >>> <p>Hello all, it&rsquo;s time for the fortnightly coding standards meeting.</p> <p>This meeting:<br> &#10148; Is for anyone interested in the Drupal coding standards.<br> &#10148; Is held on the #coding standards channel in Drupal Slack (see <a href="http://www.drupal.org/slack">www.drupal.org/slack</a> for information).<br> &#10148; Usually happens fortnightly. Alternating between Tuesday 2100 UTC and Wednesday 0900 UTC.<br> &#10148; The meeting open for 24 hours to allow for all time zones.<br> &#10148; Discussion is done in threads, which you can follow to be notified of new replies even if you don&rsquo;t comment in the thread. You may also join the meeting later and participate asynchronously.<br> &#10148; Has a public agenda anyone by adding a comment to the meeting issue.<br> &#10148; A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.</p> <p>Current ping list: @catch, @larowan, @longwave, @quietone<br> @dww, @borisson_ @longwave @Bj&ouml;rn Brala, @Aaron McHale, @Alex Skrypnyk, @Urvashi, @Kingdutch</p> <h2>0&#65039;&#8419; Who is here today? Comment in the thread to introduce yourself. We&rsquo;ll keep the meeting open for 24 hours to allow for all time zones.</h2> <table> <tr> <td>Alex Skrypnyk</td> <td>:wave:</td> </tr> <tr> <td>longwave</td> <td>:wave:</td> </tr> <tr> <td>larowlan</td> <td>hi</td> </tr> <tr> <td>hestenet (he/him)</td> <td>:wave::skin-tone-3: Just following along</td> </tr> <tr> <td>kimb0</td> <td>:wave:</td> </tr> <tr> <td>urvashi_vora</td> <td>Hello</td> </tr> <tr> <td>Bj&ouml;rn Brala (bbrala)</td> <td>&#10084;&#65039;</td> </tr> <tr> <td>gapple</td> <td>:wave:</td> </tr> </table> <h2>1&#65039;&#8419; Do you have suggested topics you are looking to discuss? Post in this thread and we&rsquo;ll open threads for them as appropriate.</h2> <table> <tr> <td>longwave</td> <td>Twig coding standards and enforcement in core</td> </tr> <tr> <td>larowlan</td> <td>establishing a roster for admin tasks&nbsp;(edited)</td> </tr> <tr> <td>andypost</td> <td>Native attributes would be great a standard too)</td> </tr> </table> <h2>2&#65039;&#8419; Action items</h2> <h2>2&#65039;&#8419;.1&#65039;&#8419; Complete from last meeting</h2> <p>The post about new members was made. As was a 'regular' announcement'</p> <h2>2&#65039;&#8419;.2&#65039;&#8419; TBA</h2> <table> <tr> <td>urvashi_vora</td> <td>Approve Previous Minutes:<span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/coding_standards/-/work_items/3393077" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/coding_standards/-/work_items/3393077</a></span></td> </tr> <tr> <td>urvashi_vora</td> <td>Verified the conversion, added missing thread replied which were done after the meeting, and also fixed the issue.</td> </tr> <tr> <td>urvashi_vora</td> <td>Approved and Fixed: <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/coding_standards/-/work_items/3393077" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/coding_standards/-/work_items/3393077</a></span></td> </tr> </table> <h2>3&#65039;&#8419; Sign up for your turn at admin duties in our calendar</h2> <table> <tr> <td>quietone</td> <td>I haven't noticed any changes in the calendar. :disappointed:</td> </tr> <tr> <td>quietone</td> <td>Who wants to facilitate the next meeting?</td> </tr> <tr> <td>quietone</td> <td>Who can record the minutes of this meeting?</td> </tr> <tr> <td>quietone</td> <td>Just hoping to get us started ^</td> </tr> <tr> <td>larowlan</td> <td>I think we just assign them based on taking in turns, if you get a week that doesn't suit, you organise a trade</td> </tr> <tr> <td>dww</td> <td>I&rsquo;d love to help, and am totally slammed through Nov. happy to start taking duties in Dec and beyond</td> </tr> <tr> <td>quietone</td> <td>@dww, thanks for letting us know &#128578;</td> </tr> <tr> <td>urvashi_vora</td> <td>I would be happy to facilitate the next meeting.</td> </tr> <tr> <td>urvashi_vora</td> <td>Also, I can record the minutes of this meeting.</td> </tr> <tr> <td>Bj&ouml;rn Brala (bbrala)</td> <td>I'll do the one after that, ill record my name there and record @urvashi_vora for next</td> </tr> <tr> <td>urvashi_vora</td> <td>Thank you @Bj&ouml;rn Brala (bbrala) :innocent:</td> </tr> </table> <h2>4&#65039;&#8419; Issues that have had the 14 day consultation period. Actually, it will be 14 days tomorrow. They are at Step 5.(edited)</h2> <h2>4&#65039;&#8419;.1&#65039;&#8419; <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/coding_standards/-/work_items/3074131" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/coding_standards/-/work_items/3074131</a></span></h2> <table> <tr> <td>quietone</td> <td>This is back to NW to use the new template. But I suggest we be a bit flexible for issues in transition?</td> </tr> <tr> <td>quietone</td> <td>If so, this could then go to a core meeting for core approval?</td> </tr> <tr> <td>larowlan</td> <td>I can try to apply the template here</td> </tr> <tr> <td>Alex Skrypnyk</td> <td>I agree with @quietoneIf we are going to ask to update all issues with new templates, then it will be blocking a lot of them.We have not actually discussed this policy when the new template was accepted. I suggest we discuss and decide if the new template should be applied to the already opened issues.</td> </tr> <tr> <td>larowlan</td> <td>A fortnight back I would have agreed with you, but then quietone applied the template to some RTBC issues and realised they were missing steps, so I feel there is value in it. I'll take this one and see if it yields the same outcome</td> </tr> </table> <h2>4&#65039;&#8419;.2&#65039;&#8419; <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-7"><a href="https://www.drupal.org/project/drupal/issues/2961791" title="Status: Closed (fixed)">#2961791: Update Help Text Standards Examples to Modify Heading Structure</a></span></h2> <table> <tr> <td>quietone</td> <td>This is NR and there was no further discussion during the 2 week period.</td> </tr> <tr> <td>quietone</td> <td>This affects core so moves to Step 7 which is to take it to a committer meeting.</td> </tr> <tr> <td>quietone</td> <td>Please, others needs to check the issue and correct the above if I am wrong.</td> </tr> </table> <h2>5&#65039;&#8419; Twig coding standards and enforcement in core</h2> <table> <tr> <td>longwave</td> <td>we have <a href="https://www.drupal.org/docs/develop/coding-standards/twig-coding-standards">https://www.drupal.org/docs/develop/coding-standards/twig-coding-standards</a> which has some basic guidelines but really just points to the Twig docs</td> </tr> <tr> <td>longwave</td> <td>a while back I opened <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-7"><a href="https://www.drupal.org/project/drupal/issues/3284817" title="Status: Closed (fixed)">#3284817: Adopt vincentlanglet/twig-cs-fixer for Twig coding standards</a></span> to try and enforce this</td> </tr> <tr> <td>longwave</td> <td>someone else has picked this up and opened an MR with all the fixes to core; just looking for someone to confirm that we don't need to do anything more on policy side before we adopt twigcs as a tool</td> </tr> <tr> <td>quietone</td> <td>The issue is making a change for core only but the coding standards wiki is for all of Drupal. Thus, I think it should go through the process.</td> </tr> <tr> <td>quietone</td> <td>Does that make sense?</td> </tr> <tr> <td>larowlan</td> <td>Agree with quietone</td> </tr> <tr> <td>urvashi_vora</td> <td>It does make sense @quietone</td> </tr> </table> <h2>6&#65039;&#8419; RTBC issues to review (Step 4)</h2> <h2>6&#65039;&#8419;.1&#65039;&#8419; <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/coding_standards/-/work_items/3295249" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/coding_standards/-/work_items/3295249</a></span></h2> <table> <tr> <td>quietone</td> <td>I recall working on this to add the new template. I have no objections to this. It can move to Step 5, announcement.</td> </tr> <tr> <td>Bj&ouml;rn Brala (bbrala)</td> <td>yes, also got lots of ocmmunity support, so thats great</td> </tr> </table> <h2>6&#65039;&#8419;.2&#65039;&#8419; <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/coding_standards/-/work_items/3324368" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/coding_standards/-/work_items/3324368</a></span></h2> <table> <tr> <td>quietone</td> <td>I think the next step 7 to got to a core committer meeting.&nbsp;(edited)</td> </tr> </table> <h2>7&#65039;&#8419; Should we change the Warning message on coding standards wiki pages?&nbsp;(edited)&nbsp;</h2> <table> <tr> <td>quietone</td> <td>Changes to Drupal coding standards are proposed and discussed in issues in the Coding Standards project.</td> </tr> <tr> <td>quietone</td> <td>That is the current message.</td> </tr> <tr> <td>quietone</td> <td>I'd like to prevent changes being made before approval.</td> </tr> <tr> <td>quietone</td> <td>I was wondering if it should say something like 'all change must be approved by the Coding Standards committee'?</td> </tr> <tr> <td>urvashi_vora</td> <td>We can also make it something like "Proposed changes must receive approval from the Coding Standards Committee."</td> </tr> </table> <p>Participants:<br> Alex Skrypnyk, longwave, larowlan, hestenet, kim.pepper, urvashi_vora, bbrala, gapple, andypost, quietone, dww</p>