Unverified Commit bcfac795 authored by Klaus Purer's avatar Klaus Purer Committed by GitHub
Browse files

tests(ScopeIndent): Sync upstream changes from PHPCS and expand test coverage

parent f1e1627d

coder_sniffer/Drupal/Sniffs/WhiteSpace/ScopeIndentSniff.php

+392 −119

File changed.

Preview size limit exceeded, changes collapsed.

coder_sniffer/Drupal/Test/WhiteSpace/ScopeIndentUnitTest.inc

+78 −0
Original line number Diff line number Diff line
@@ -125,3 +125,81 @@ function entity_permissions($entity_type_id, $operation) { 
  }

  return [];

}



$tests = [

  [

    'original' => '$no_index_value_scalar = TRUE;',

    'settings' => [

      'no_index_value_scalar' => (object) [

        'value' => FALSE,

        'comment' => 'comment',

      ],

    ],

    'expected' => '$no_index_value_scalar = false; // comment',

  ],

  [

    'original' => '$no_index_value_scalar = TRUE;',

    'settings' => [

      'no_index_value_foo' => [

        'foo' => [

          'value' => (object) [

            'value' => NULL,

            'required' => TRUE,

            'comment' => 'comment',

          ],

        ],

      ],

    ],

    'expected' => <<<'EXPECTED'

$no_index_value_scalar = TRUE;

$no_index_value_foo['foo']['value'] = NULL; // comment

EXPECTED

  ],

  [

    'original' => '$no_index_value_array = array("old" => "value");',

    'settings' => [

      'no_index_value_array' => (object) [

        'value' => FALSE,

        'required' => TRUE,

        'comment' => 'comment',

      ],

    ],

    'expected' => '$no_index_value_array = array("old" => "value");

$no_index_value_array = false; // comment',

  ],

  [

    'original' => '$has_index_value_scalar["foo"]["bar"] = NULL;',

    'settings' => [

      'has_index_value_scalar' => [

        'foo' => [

          'bar' => (object) [

            'value' => FALSE,

            'required' => TRUE,

            'comment' => 'comment',

          ],

        ],

      ],

    ],

    'expected' => '$has_index_value_scalar["foo"]["bar"] = false; // comment',

  ],

  [

    'original' => '$has_index_value_scalar["foo"]["bar"] = "foo";',

    'settings' => [

      'has_index_value_scalar' => [

        'foo' => [

          'value' => (object) [

            'value' => ['value' => 2],

            'required' => TRUE,

            'comment' => 'comment',

          ],

        ],

      ],

    ],

    'expected' => <<<'EXPECTED'

$has_index_value_scalar["foo"]["bar"] = "foo";

$has_index_value_scalar['foo']['value'] = array (

'value' => 2,

); // comment

EXPECTED

  ],

];

coder_sniffer/Drupal/Test/WhiteSpace/ScopeIndentUnitTest.inc.fixed

+78 −0
Original line number Diff line number Diff line
@@ -137,3 +137,81 @@ function entity_permissions($entity_type_id, $operation) { 
  }

  return [];

}



$tests = [

  [

    'original' => '$no_index_value_scalar = TRUE;',

    'settings' => [

      'no_index_value_scalar' => (object) [

        'value' => FALSE,

        'comment' => 'comment',

      ],

    ],

    'expected' => '$no_index_value_scalar = false; // comment',

  ],

  [

    'original' => '$no_index_value_scalar = TRUE;',

    'settings' => [

      'no_index_value_foo' => [

        'foo' => [

          'value' => (object) [

            'value' => NULL,

            'required' => TRUE,

            'comment' => 'comment',

          ],

        ],

      ],

    ],

    'expected' => <<<'EXPECTED'

$no_index_value_scalar = TRUE;

$no_index_value_foo['foo']['value'] = NULL; // comment

EXPECTED

  ],

  [

    'original' => '$no_index_value_array = array("old" => "value");',

    'settings' => [

      'no_index_value_array' => (object) [

        'value' => FALSE,

        'required' => TRUE,

        'comment' => 'comment',

      ],

    ],

    'expected' => '$no_index_value_array = array("old" => "value");

$no_index_value_array = false; // comment',

  ],

  [

    'original' => '$has_index_value_scalar["foo"]["bar"] = NULL;',

    'settings' => [

      'has_index_value_scalar' => [

        'foo' => [

          'bar' => (object) [

            'value' => FALSE,

            'required' => TRUE,

            'comment' => 'comment',

          ],

        ],

      ],

    ],

    'expected' => '$has_index_value_scalar["foo"]["bar"] = false; // comment',

  ],

  [

    'original' => '$has_index_value_scalar["foo"]["bar"] = "foo";',

    'settings' => [

      'has_index_value_scalar' => [

        'foo' => [

          'value' => (object) [

            'value' => ['value' => 2],

            'required' => TRUE,

            'comment' => 'comment',

          ],

        ],

      ],

    ],

    'expected' => <<<'EXPECTED'

$has_index_value_scalar["foo"]["bar"] = "foo";

$has_index_value_scalar['foo']['value'] = array (

'value' => 2,

); // comment

EXPECTED

  ],

];