>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3090970. --> Reported by: [chris burge](https://www.drupal.org/user/1826152) >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>Currently, this module uses <code>CustomConfig::getConfig()</code> to override CKEditor settings. There are two issue with this:</p> <ol start="1"> <li>Certain settings are set by CKEditor's internal plugin and require a core patch to modify (<span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-8"><a href="https://www.drupal.org/project/ckeditor/issues/3052938" title="Status: Needs review">#3052938: CKEditor should allow plugins to override default config</a></span>)</li> </ol> <p>If issue #1 is fixed, then</p> <ol start="2"> <li>Settings from plugins that load after CKEditor will be able to override custom configuration; however, by design, CKEditor config should have the final say.</li> </ol> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>In <code>CustomConfig::getConfig()</code>, instead of overriding settings, store them in their own setting for later:</p> <pre>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; // Convert numeric values to integers.<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (is_numeric($exploded_value[1])) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; $exploded_value[1] = (int) $exploded_value[1];<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; $config['ckeditor_custom_config'][$exploded_value[0]] = $exploded_value[1];<br>-&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; $config[$exploded_value[0]] = $exploded_value[1];<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>&nbsp;&nbsp;&nbsp; }</pre><p>Then in ckeditor_config.module, add</p> <pre>/**<br> * Implements hook_editor_js_settings_alter().<br> */<br>function ckeditor_config_editor_js_settings_alter(array &amp;$settings) {<br>&nbsp; foreach($settings['editor']['formats'] as $editor_name =&gt; &amp;$editor) {<br>&nbsp;&nbsp;&nbsp; if (isset($editor['editorSettings']['ckeditor_custom_config'])) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; foreach ($editor['editorSettings']['ckeditor_custom_config'] as $name =&gt; $value) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; $editor['editorSettings'][$name] = $value;<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>&nbsp;&nbsp;&nbsp; }<br>&nbsp; }<br>}</pre><h3 id="summary-remaining-tasks">Remaining tasks</h3> <p><del>Write patch</del><br> <del>Verify tests</del></p> <h3 id="summary-ui-changes">User interface changes</h3> <p>None.</p> <h3 id="summary-api-changes">API changes</h3> <p>None.</p> <h3 id="summary-data-model-changes">Data model changes</h3> <p>I don't believe so. We're not changing how config data is stored. The manipulations proposed here all happen at runtime.</p> <h3 id="summary-release-notes">Release notes snippet</h3> <p>Beginning in 8.x-2.1, CKEditor settings are now added using <code>hook_editor_js_settings_alter()</code>, which means they are added after all CKEditor Drupal plugins have provided their settings. This guarantees that settings defined by <em>CKEditor config</em> override settings provided by CKEditor Drupal plugins. Previously, this was not the case, specifically with regard to core's Internal plugin. The following settings can now be managed with <em>CKEditor config</em> without the use of a core patch:</p> <ul> <li>pasteFromWordPromptCleanup</li> <li>resize_dir</li> <li>justifyClasses</li> <li>entities</li> <li>disableNativeSpellChecker</li> </ul> <h3 id="summary-original-report">Original report by TwoD</h3> <p>This architectural change to CKEditor config was originally raised by TwoD on <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-8"><a href="https://www.drupal.org/project/ckeditor/issues/3052938" title="Status: Needs review">#3052938: CKEditor should allow plugins to override default config</a></span>.</p>