Incompatible with Drupal Core 10.5 / CKEditor 45
>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3531259. --> Reported by: [harkonn](https://www.drupal.org/user/3583169) Related to !12 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>After an upgrade to Drupal 10.5.0, or on a fresh 10.5.0 site-install, when the ckeditor_abbreviation module is enabled, and a text format has been configured with a ckeditor_abbreviation toolbar button, the CKEditor widget fails to load (e.g.: on a node/add page). Checking the browser console, CKEditor generates a JS-error:</p> <pre>TypeError: Cannot read properties of undefined (reading 'check')<br>&nbsp;&nbsp;&nbsp; at new d (abbreviation.js?sy5a3z:1:3972)<br>&nbsp;&nbsp;&nbsp; at b._createFormView (abbreviation.js?sy5a3z:1:7343)<br>&nbsp;&nbsp;&nbsp; at b.init (abbreviation.js?sy5a3z:1:5502)</pre><p>This appears to be related to the upgrade to CKEditor 45.2.0 &mdash;&nbsp;<a href="https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-45.html">in CKEditor 45.0.0, the icons were moved into their own package</a>, <a href="https://www.npmjs.com/package/@ckeditor/ckeditor5-icons">@ckeditor5/ckeditor5-icons</a>.</p> <h4 id="summary-steps-reproduce">Steps to reproduce</h4> <ol> <li>Install Drupal 10.5.0 with the Standard install profile and ckeditor_abbreviation.</li> <li>Enable ckeditor_abbreviation on the Basic HTML text format.</li> <li>Go to <code>/node/add/article</code> &mdash;&nbsp;note that CKEditor did not load. Check the browser console.</li> </ol> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Fix breaking changes from <a href="https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-45.html">the CKEditor documentation on Updat[ing] to CKEditor 5 v45.x</a>.</p> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <ol> <li><del>Write a patch</del> &mdash;&nbsp;done by @sunlix</li> <li><del>Cross-compatibility testing and figure out if we need to make a new version</del> &mdash;&nbsp;turns out we don't need to make a new version</li> <li><del>Fix broken tests</del>&nbsp;&mdash;&nbsp;done by @mparker17</li> <li><del>Review and feedback</del> &mdash;&nbsp;reviewed by @mparker17</li> <li>RTBC and feedback</li> <li>Commit</li> <li>Release</li> </ol> <h3 id="summary-ui-changes">User interface changes</h3> <p>None anticipated.</p> <h3 id="summary-api-changes">API changes</h3> <p>To be determined.</p> <h3 id="summary-data-model-changes">Data model changes</h3> <p>None anticipated.</p>
issue