Remove \Drupal\Tests\cdn\Unit\File\FileUrlGeneratorTest::getConfigFactoryStub() once the CDN module can require Drupal 8.5 (#2934643) · Issues · project / cdn

Remove \Drupal\Tests\cdn\Unit\File\FileUrlGeneratorTest::getConfigFactoryStub() once the CDN module can require Drupal 8.5

>>> [!note] Migrated issue   Reported by: [wim leers](https://www.drupal.org/user/99777) >>> Quoting myself from <a href="https://www.drupal.org/project/drupal/issues/2862248" title="Status: Closed (fixed)">#2862248: UnitTestCase::getConfigFactoryStub() doesn't accept dotted keys</a>: <blockquote> Hah! While scanning the RTBC queue, this one caught my eye. I also ran into this in #2708787, in the CDN contrib module that I maintain. I added a work-around in <a href="https://git.drupalcode.org/project/cdn/-/work_items/2708787" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/cdn/-/work_items/2708787</a>, but then forgot to report it back to the Drupal core issue queue. I overrode <code>UnitTestCase::getConfigFactoryStub()</code> in my unit test, with the following interdiff: <pre>diff --git a/core/tests/Drupal/Tests/UnitTestCase.php b/core/tests/Drupal/Tests/UnitTestCase.php index 58173e5..030b5e4 100644 --- a/core/tests/Drupal/Tests/UnitTestCase.php +++ b/core/tests/Drupal/Tests/UnitTestCase.php @@ -111,20 +111,24 @@ public function getConfigFactoryStub(array $configs = []) {      $config_editable_map = [];      // Construct the desired configuration object stubs, each with its own      // desired return map. -    foreach ($configs as $config_name => $config_values) { -      $map = []; -      foreach ($config_values as $key => $value) { -        $map[] = [$key, $value]; -      } -      // Also allow to pass in no argument. -      $map[] = ['', $config_values]; +    foreach ($configs as $config_name => $map) { +      $get = function ($key) use ($map) { +        $parts = explode('.', $key); +        if (count($parts) == 1) { +          return isset($map[$key]) ? $map[$key] : NULL; +        } +        else { +          $value = NestedArray::getValue($map, $parts, $key_exists); +          return $key_exists ? $value : NULL; +        } +      };        $immutable_config_object = $this->getMockBuilder('Drupal\Core\Config\ImmutableConfig')          ->disableOriginalConstructor()          ->getMock();        $immutable_config_object->expects($this->any())          ->method('get') -        ->will($this->returnValueMap($map)); +        ->willReturnCallback($get);        $config_get_map[] = [$config_name, $immutable_config_object];        $mutable_config_object = $this->getMockBuilder('Drupal\Core\Config\Config') @@ -132,7 +136,7 @@ public function getConfigFactoryStub(array $configs = []) {          ->getMock();        $mutable_config_object->expects($this->any())          ->method('get') -        ->will($this->returnValueMap($map)); +        ->willReturnCallback($get);        $config_editable_map[] = [$config_name, $mutable_config_object];      }      // Construct a config factory with the array of configuration object stubs</pre>And had this docblock for my override: <pre>  /**    * {@inheritdoc}    *    * Overridden, because the way ImmutableConfig::get() is mocked, does not    * match the actual implementation, which then causes tests to fail.    */</pre>Glad to see this being solved in Drupal core! 🎉 </blockquote> > Related issue: [Issue #2708787](https://www.drupal.org/node/2708787) > Related issue: [Issue #2862248](https://www.drupal.org/node/2862248)

issue