Automate review using PHPStan: disallow short ternary
@larowlan, while reviewing !1112: > ``` > $entity_type_bundles[] = [$entity_type_id, $bundle ?: $entity_type_id]; > ``` > > ?? instead of ?: - ?: - we know it is NULL so can use the more strict version — — —-- — https://git.drupalcode.org/project/canvas/-/merge_requests/1112#note_1199237 The solution is https://github.com/phpstan/phpstan-strict-rules' `disallowedShortTernary: true`: > Disallow short ternary operator (?:) - implies weak comparison, it's recommended to use null coalesce operator (??) or ternary operator with strict condition.
issue