CI: upstream PHPStan 2.38 release triggered new failures
>>> [!note] Migrated issue
<!-- Drupal.org comment -->
<!-- Migrated from issue #3571034. -->
Reported by: [wim leers](https://www.drupal.org/user/99777)
Related to !528
>>>
<h3 id="overview">Overview</h3>
<p>Friday's PHPStan 2.38 release (<a href="https://github.com/phpstan/phpstan/releases/tag/2.1.38">https://github.com/phpstan/phpstan/releases/tag/2.1.38</a>) caused or <code>lint (php)</code> CI job to start failing:</p>
<pre> ------ ---------------------------------------------------------------- <br> Line src/Entity/ContentTemplate.php <br> ------ ---------------------------------------------------------------- <br> 438 Parameter #1 $entity_type_id of method <br> Drupal\Core\Entity\EntityTypeManagerInterface::getDefinition() <br> expects string, string|null given. <br> 🪪 argument.type <br> ------ ---------------------------------------------------------------- <br> ------ ---------------------------------------------------------------- <br> Line src/ShapeMatcher/JsonSchemaFieldInstanceMatcher.php <br> ------ ---------------------------------------------------------------- <br> 1022 Parameter #1 $entity_type_id of method <br> Drupal\Core\Entity\EntityTypeManagerInterface::getDefinition() <br> expects string, string|null given. <br> 🪪 argument.type <br> ------ ---------------------------------------------------------------- <br> ------ ---------------------------------------------------------------- <br> Line src/ShapeMatcher/PropSourceSuggester.php <br> ------ ---------------------------------------------------------------- <br> 107 Parameter #1 $entity_type_id of method <br> Drupal\Core\Entity\EntityTypeManagerInterface::getDefinition() <br> expects string, string|null given. <br> 🪪 argument.type <br> ------ ---------------------------------------------------------------- <br> [ERROR] Found 3 errors </pre><h3 id="proposed-resolution">Proposed resolution</h3>
<h3 id="ui-changes">User interface changes</h3>
issue