Add the ability for ComponentSourceManager to generate a Component config entity for a single source, or even a single specific component (#3561272) · Issues · project / canvas

Add the ability for ComponentSourceManager to generate a Component config entity for a single source, or even a single specific component

>>> [!note] Migrated issue   Reported by: [phenaproxima](https://www.drupal.org/user/205645) Related to !407 >>> <h3 id="overview">Overview</h3> See <a href="https://git.drupalcode.org/project/canvas/-/work_items/3556327" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/canvas/-/work_items/3556327</a>'s <a href="https://git.drupalcode.org/project/canvas/-/merge_requests/378#note_634136">https://git.drupalcode.org/project/canvas/-/merge_requests/378#note_634136</a> It might be helpful for ComponentSourceManager to have the ability to generate <code>Component</code> config entities, if necessary, for a single specific component source, or even a single component in that source. Right now it just generates entities for all the components it can, across all sources. <h3 id="proposal">Proposed solution</h3> <pre>diff --git a/src/ComponentSource/ComponentSourceManager.php b/src/ComponentSource/ComponentSourceManager.php index 6ed03cce0..e714bc438 100644 --- a/src/ComponentSource/ComponentSourceManager.php +++ b/src/ComponentSource/ComponentSourceManager.php @@ -64,9 +64,16 @@ final class ComponentSourceManager extends DefaultPluginManager {    /**     * Generates Component config entities for all eligible discovered components.     * +   * @param string|null $source_id +   *   (optional) A ComponentSource plugin ID. If omitted, will (re)generate +   *   Component config entities for all ComponentSource plugins. +   * @param ComponentSourceSpecificId|null $source_specific_id +   *   (optional) A source-specific ID in the given $source_id. If omitted, will +   *   (re)generate Component config entities for all components. +   *     * @return $this     */ -  public function generateComponents(): self { +  public function generateComponents(string $source_id = NULL, string $source_specific_id = NULL): self {      if ($this->isUpdateKernel) {        return $this;      }</pre>This would enable us to change <code>\Drupal\canvas\EntityHandlers\JavascriptComponentStorage::doPostSave()</code> from <pre>  protected function doPostSave(EntityInterface $entity, $update): void {     parent::doPostSave($entity, $update); …     $this->componentSourceManager->generateComponents();   }</pre>to <pre>  protected function doPostSave(EntityInterface $entity, $update): void {     parent::doPostSave($entity, $update); …     $this->componentSourceManager->generateComponent(JsComponent::PLUGIN_ID, $entity);   }</pre>or even <pre>  protected function doPostSave(EntityInterface $entity, $update): void {     parent::doPostSave($entity, $update); …     $this->componentSourceManager->generateComponent(JsComponent::PLUGIN_ID, $entity->id());   }</pre> (That entity ID is a <code>JavaScriptComponent</code> ID, not a <code>Component</code> ID!)

issue