Rename DynamicPropSource to EntityFieldPropSource
>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3555229. --> Reported by: [phenaproxima](https://www.drupal.org/user/205645) Related to !280 >>> <h3 id="overview">Overview</h3> <p><em>Extracted from <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/canvas/-/work_items/3548297" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/canvas/-/work_items/3548297</a></span></em></p> <p><code>DynamicPropSource</code> is strangely named. It gets data from entity fields -- that's it. That's what it does. "Dynamic" is...technically true, but uninformative, and imposes extra cognitive load on anyone trying to understand Canvas's inner workings.</p> <h3 id="proposed-resolution">Proposed resolution</h3> <p>Rename <code>DynamicPropSource</code> to <code>EntityFieldPropSource</code>, with the <code>entity-field</code> prefix. For backwards compatibility, the <code>dynamic</code> prefix should be silently converted to <code>entity-field</code>; maybe we can do an update path later (to <em>force</em> every component tree using this to get updated), but for now it's not really problematic to alias it (and have it be updated just-in-time).</p>
issue