Remove assertion in `ComputedUrlWithQueryString::calculateDependencies()` to allow contrib reuse
>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3552028. --> Reported by: [vishalkhode](https://www.drupal.org/user/2439156) Related to !230 >>> <h3 id="overview">Overview</h3> <p>Update the <code>calculateDependencies()</code> method of class <code>ComputedUrlWithQueryString</code> class to prevent error when used by other contributed modules.</p> <p>As part of ticket <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/canvas/-/work_items/3530351" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/canvas/-/work_items/3530351</a></span>, the <code>ComputedUrlWithQueryString</code> class was refactored to allow other contributed modules (e.g., Acquia DAM) to use it directly, eliminating the need to copy its code. <a href="https://git.drupalcode.org/project/canvas/-/merge_requests/3/diffs?commit_id=a9c99a1f35b3b07a77c9b701a7656da3c99df105">An assert was removed to improve reusability</a>, but the <code>calculateDependencies()</code> method was missed to be updated accordingly. This causes an error when the method is invoked:</p> <pre>AssertionError: assert($url_prop_expression instanceof ReferenceFieldTypePropExpression) in assert() (line 85 of /var/www/html/web/modules/contrib/canvas/src/Plugin/DataType/ComputedUrlWithQueryString.php).</pre>
issue