From d32b6dfdcd14ee783e6e4beeea7b67a0347faabc Mon Sep 17 00:00:00 2001 From: Jeya Sundharam <jeyasundharam33@gmail.com> Date: Tue, 28 Jan 2025 16:13:30 +0530 Subject: [PATCH 1/3] Issue #3502748 by sundhar: LogicException: Cannot create key "loading" --- src/BlazySettings.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BlazySettings.php b/src/BlazySettings.php index 1e5533d9..0f5da286 100644 --- a/src/BlazySettings.php +++ b/src/BlazySettings.php @@ -385,7 +385,7 @@ class BlazySettings implements \Countable { $this->storage[$key] = $value; } else { - NestedArray::setValue($this->storage, $parts, $value); + NestedArray::setValue($this->storage, $parts, $value, TRUE); } return $this; } -- GitLab From ee706a7d6ec4d95ff8ec09809f940a7bc4806f1b Mon Sep 17 00:00:00 2001 From: Frantisek Trusa <frantisek.trusa@dropsolid.com> Date: Wed, 26 Mar 2025 16:50:22 +0100 Subject: [PATCH 2/3] Issue #3502748: Revert back --- src/BlazySettings.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BlazySettings.php b/src/BlazySettings.php index 0f5da286..1e5533d9 100644 --- a/src/BlazySettings.php +++ b/src/BlazySettings.php @@ -385,7 +385,7 @@ class BlazySettings implements \Countable { $this->storage[$key] = $value; } else { - NestedArray::setValue($this->storage, $parts, $value, TRUE); + NestedArray::setValue($this->storage, $parts, $value); } return $this; } -- GitLab From 2a29cde59250831b0dfb7931e33fcb179b0128d2 Mon Sep 17 00:00:00 2001 From: Frantisek Trusa <frantisek.trusa@dropsolid.com> Date: Wed, 26 Mar 2025 16:51:35 +0100 Subject: [PATCH 3/3] Issue #3502748: Check if dimensions were calculated. --- src/Media/BlazyResponsiveImage.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/Media/BlazyResponsiveImage.php b/src/Media/BlazyResponsiveImage.php index 6b162961..d4c65233 100644 --- a/src/Media/BlazyResponsiveImage.php +++ b/src/Media/BlazyResponsiveImage.php @@ -173,9 +173,11 @@ class BlazyResponsiveImage { ->set('ratios', (object) $ratios) ->set('resimage.ids', array_values($names)); - // Only needed the last one. - // Overrides plain old image dimensions. - $blazies->set('image', end($dimensions), TRUE); + if ($dimensions) { + // Only needed the last one. + // Overrides plain old image dimensions. + $blazies->set('image', end($dimensions), TRUE); + } // Currently only needed by Preload. // @todo phpstan bug, misleading with multiple conditions. -- GitLab