Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
automatic_updates
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
automatic_updates
Merge requests
!316
Issue
#3280180
: Consolidate all version validation logic into a single class
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Issue
#3280180
: Consolidate all version validation logic into a single class
issue/automatic_updates-3280180:refactor-version-logic
into
8.x-2.x
Overview
63
Commits
114
Pipelines
0
Changes
6
Merged
Adam G-H
requested to merge
issue/automatic_updates-3280180:refactor-version-logic
into
8.x-2.x
2 years ago
Overview
63
Commits
114
Pipelines
0
Changes
1
Expand
0
0
Merge request reports
Compare
version 11
version 49
5c21462f
2 years ago
version 48
2d65cff6
2 years ago
version 47
4133bcfd
2 years ago
version 46
598fa171
2 years ago
version 45
809d873f
2 years ago
version 44
f86b2e1e
2 years ago
version 43
b90a3fd3
2 years ago
version 42
b05a8e1f
2 years ago
version 41
367ed4a1
2 years ago
version 40
5301c753
2 years ago
version 39
69aafe04
2 years ago
version 38
38f35651
2 years ago
version 37
43b663a3
2 years ago
version 36
c66e7a62
2 years ago
version 35
1f335ada
2 years ago
version 34
c67b040b
2 years ago
version 33
2117820e
2 years ago
version 32
461cf57e
2 years ago
version 31
a7853e41
2 years ago
version 30
5a43630d
2 years ago
version 29
4e1c70b8
2 years ago
version 28
bb084953
2 years ago
version 27
2eeb140f
2 years ago
version 26
016ac1d0
2 years ago
version 25
411b0107
2 years ago
version 24
fae39e2a
2 years ago
version 23
f8594f62
2 years ago
version 22
720875d9
2 years ago
version 21
10c44753
2 years ago
version 20
baa00618
2 years ago
version 19
736f85fc
2 years ago
version 18
ec280a04
2 years ago
version 17
69e12858
2 years ago
version 16
53f54184
2 years ago
version 15
0b0f2d52
2 years ago
version 14
052adba5
2 years ago
version 13
9e62fe5d
2 years ago
version 12
74a632b1
2 years ago
version 11
ee005c7d
2 years ago
version 10
2329b7ab
2 years ago
version 9
5990a6f9
2 years ago
version 8
be47a7f0
2 years ago
version 7
0abccdbd
2 years ago
version 6
4d20b5c7
2 years ago
version 5
410a471d
2 years ago
version 4
e4a16f01
2 years ago
version 3
b8b01271
2 years ago
version 2
41bf2d72
2 years ago
version 1
275eda32
2 years ago
8.x-2.x (base)
and
version 12
latest version
5c21462f
114 commits,
2 years ago
version 49
5c21462f
114 commits,
2 years ago
version 48
2d65cff6
113 commits,
2 years ago
version 47
4133bcfd
110 commits,
2 years ago
version 46
598fa171
108 commits,
2 years ago
version 45
809d873f
106 commits,
2 years ago
version 44
f86b2e1e
105 commits,
2 years ago
version 43
b90a3fd3
101 commits,
2 years ago
version 42
b05a8e1f
86 commits,
2 years ago
version 41
367ed4a1
85 commits,
2 years ago
version 40
5301c753
83 commits,
2 years ago
version 39
69aafe04
82 commits,
2 years ago
version 38
38f35651
81 commits,
2 years ago
version 37
43b663a3
79 commits,
2 years ago
version 36
c66e7a62
76 commits,
2 years ago
version 35
1f335ada
75 commits,
2 years ago
version 34
c67b040b
71 commits,
2 years ago
version 33
2117820e
70 commits,
2 years ago
version 32
461cf57e
64 commits,
2 years ago
version 31
a7853e41
58 commits,
2 years ago
version 30
5a43630d
57 commits,
2 years ago
version 29
4e1c70b8
55 commits,
2 years ago
version 28
bb084953
52 commits,
2 years ago
version 27
2eeb140f
50 commits,
2 years ago
version 26
016ac1d0
48 commits,
2 years ago
version 25
411b0107
47 commits,
2 years ago
version 24
fae39e2a
46 commits,
2 years ago
version 23
f8594f62
43 commits,
2 years ago
version 22
720875d9
42 commits,
2 years ago
version 21
10c44753
40 commits,
2 years ago
version 20
baa00618
36 commits,
2 years ago
version 19
736f85fc
35 commits,
2 years ago
version 18
ec280a04
33 commits,
2 years ago
version 17
69e12858
28 commits,
2 years ago
version 16
53f54184
26 commits,
2 years ago
version 15
0b0f2d52
22 commits,
2 years ago
version 14
052adba5
21 commits,
2 years ago
version 13
9e62fe5d
20 commits,
2 years ago
version 12
74a632b1
17 commits,
2 years ago
version 11
ee005c7d
16 commits,
2 years ago
version 10
2329b7ab
15 commits,
2 years ago
version 9
5990a6f9
14 commits,
2 years ago
version 8
be47a7f0
12 commits,
2 years ago
version 7
0abccdbd
11 commits,
2 years ago
version 6
4d20b5c7
10 commits,
2 years ago
version 5
410a471d
7 commits,
2 years ago
version 4
e4a16f01
6 commits,
2 years ago
version 3
b8b01271
5 commits,
2 years ago
version 2
41bf2d72
4 commits,
2 years ago
version 1
275eda32
1 commit,
2 years ago
Show latest version
1 file
+
3
−
3
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
src/Validator/VersionValidator.php
+
3
−
3
Options
@@ -343,14 +343,14 @@ final class VersionValidator implements EventSubscriberInterface {
*
* @param \Drupal\package_manager\Event\StageEvent $event
* The event object.
* @param string $target_version
* The target version of Drupal.
* @param string
|null
$target_version
* The target version of Drupal
, or NULL if it's not known
.
*
* @return bool
* TRUE if the target version of Drupal is in the list of secure, supported
* releases; otherwise FALSE.
*/
private
function
isTargetVersionAcceptable
(
StageEvent
$event
,
string
$target_version
):
bool
{
private
function
isTargetVersionAcceptable
(
StageEvent
$event
,
?
string
$target_version
):
bool
{
// If the target version isn't in the list of installable releases, then it
// isn't secure and supported and we should flag an error.
$releases
=
$this
->
getAvailableReleases
(
$event
);
Loading