Skip to content
Snippets Groups Projects

Issue #3274323: Split ExcludedPathsSubscriber into multiple classes

All threads resolved!
All threads resolved!
Compare and Show latest version
2 files
+ 80
25
Compare changes
  • Side-by-side
  • Inline
Files
2
@@ -10,7 +10,6 @@ use Drupal\package_manager\EventSubscriber\SqliteDatabaseExcluder;
/**
* @covers \Drupal\package_manager\EventSubscriber\ExcludedPathsSubscriber
* @covers \Drupal\package_manager\EventSubscriber\GitExcluder
* @covers \Drupal\package_manager\EventSubscriber\SiteFilesExcluder
* @covers \Drupal\package_manager\EventSubscriber\SqliteDatabaseExcluder
* @covers \Drupal\package_manager\EventSubscriber\TestSiteExcluder
@@ -101,9 +100,6 @@ class ExcludedPathsTest extends PackageManagerKernelTestBase {
'sites/default/settings.php',
'sites/default/settings.local.php',
'sites/default/services.yml',
// No git directories should be staged.
'.git/ignore.txt',
'modules/example/.git/ignore.txt',
];
foreach ($ignore as $path) {
$this->assertFileExists("$active_dir/$path");
@@ -113,8 +109,6 @@ class ExcludedPathsTest extends PackageManagerKernelTestBase {
$this->assertFileExists("$stage_dir/sites/default/stage.txt");
// Regular module files should be staged.
$this->assertFileExists("$stage_dir/modules/example/example.info.yml");
// Files that start with .git, but aren't actually .git, should be staged.
$this->assertFileExists("$stage_dir/.gitignore");
// A new file added to the staging area in an excluded directory, should not
// be copied to the active directory.
@@ -210,25 +204,6 @@ class ExcludedPathsTest extends PackageManagerKernelTestBase {
$this->assertEmpty(array_diff($expected_exclusions, $event->getExcludedPaths()));
}
/**
* Tests that unreadable directories are ignored by the event subscriber.
*/
public function testUnreadableDirectoriesAreIgnored(): void {
$this->createTestProject();
$active_dir = $this->container->get('package_manager.path_locator')
->getProjectRoot();
// Create an unreadable directory within the active directory, which will
// raise an exception as the event subscriber tries to scan for .git
// directories...unless unreadable directories are being ignored, as they
// should be.
$unreadable_dir = $active_dir . '/unreadable';
mkdir($unreadable_dir, 0000);
$this->assertDirectoryIsNotReadable($unreadable_dir);
$this->createStage()->create();
}
}
/**
Loading