automatic_updates_extensions/tests/src/Functional/SuccessfulUpdateTest.php

+<?php
+
+declare(strict_types=1);
+
+namespace Drupal\Tests\automatic_updates_extensions\Functional;
+
+use Drupal\package_manager\Event\PreApplyEvent;
+use Drupal\package_manager\LegacyVersionUtility;
+use Drupal\package_manager_test_validation\StagedDatabaseUpdateValidator;
+
+/**
+ * @covers \Drupal\automatic_updates_extensions\Form\UpdaterForm
+ * @group automatic_updates_extensions
+ * @internal
+ */
+final class SuccessfulUpdateTest extends UpdaterFormTestBase {
+
+  /**
+   * Data provider for testSuccessfulUpdate().
+   *
+   * @return mixed[][]
+   *   The test cases.
+   */
+  public function providerSuccessfulUpdate(): array {
+    return [
+      'maintenance mode on, semver module' => [
+        TRUE, 'semver_test', 'drupal/semver_test_package_name', 'Semver Test', '8.1.0', '8.1.1',
+      ],
+      'maintenance mode off, legacy module' => [
+        FALSE, 'aaa_update_test', 'drupal/aaa_update_test', 'AAA Update test', '8.x-2.0', '8.x-2.1',
+      ],
+      'maintenance mode off, legacy theme' => [
+        FALSE, 'automatic_updates_extensions_test_theme', 'drupal/automatic_updates_extensions_test_theme', 'Automatic Updates Extensions Test Theme', '8.x-2.0', '8.x-2.1',
+      ],
+    ];
+  }
+
+  /**
+   * Tests an update that has no errors or special conditions.
+   *
+   * @param bool $maintenance_mode_on
+   *   Whether maintenance should be on at the beginning of the update.
+   * @param string $project_name
+   *   The project name.
+   * @param string $package_name
+   *   The package name.
+   * @param string $project_title
+   *   The project title.
+   * @param string $installed_version
+   *   The installed version.
+   * @param string $target_version
+   *   The target version.
+   *
+   * @dataProvider providerSuccessfulUpdate
+   */
+  public function testSuccessfulUpdate(bool $maintenance_mode_on, string $project_name, string $package_name, string $project_title, string $installed_version, string $target_version): void {
+    $this->container->get('theme_installer')->install(['automatic_updates_theme_with_updates']);
+    // By default, the Update module only checks for updates of installed
+    // modules and themes. The two modules we're testing here (semver_test and
+    // aaa_update_test) are already installed by static::$modules.
+    $this->container->get('theme_installer')->install(['automatic_updates_extensions_test_theme']);
+    $this->setReleaseMetadata(__DIR__ . '/../../../../package_manager/tests/fixtures/release-history/drupal.9.8.2.xml');
+    $path_to_fixtures_folder = $project_name === 'aaa_update_test' ? '/../../../../package_manager/tests' : '/../..';
+    $this->setReleaseMetadata(__DIR__ . $path_to_fixtures_folder . '/fixtures/release-history/' . $project_name . '.1.1.xml');
+    $this->setProjectInstalledVersion([$project_name => $installed_version]);
+    $this->getStageFixtureManipulator()->setVersion($package_name, LegacyVersionUtility::convertToSemanticVersion($target_version));
+    $this->checkForUpdates();
+    $state = $this->container->get('state');
+    $state->set('system.maintenance_mode', $maintenance_mode_on);
+    StagedDatabaseUpdateValidator::setExtensionsWithUpdates([
+      'system',
+      'automatic_updates_theme_with_updates',
+    ]);
+
+    $page = $this->getSession()->getPage();
+    // Navigate to the automatic updates form.
+    $this->drupalGet('/admin/reports/updates');
+    $this->clickLink('Update Extensions');
+    $this->assertTableShowsUpdates(
+      $project_title,
+      $installed_version,
+      $target_version
+    );
+    $assert_session = $this->assertSession();
+    $this->assertUpdatesCount(1);
+
+    // Submit without selecting a project.
+    $page->pressButton('Update');
+    $assert_session->pageTextContains('Select one or more projects.');
+
+    // Submit with a project selected.
+    $page->checkField('projects[' . $project_name . ']');
+    $page->pressButton('Update');
+    $this->checkForMetaRefresh();
+    $this->assertUpdateStagedTimes(1);
+    // Confirm that the site was put into maintenance mode if needed.
+    $this->assertSame($state->get('system.maintenance_mode'), $maintenance_mode_on);
+
+    $assert_session->pageTextNotContains('The following dependencies will also be updated:');
+    // Ensure that a list of pending database updates is visible, along with a
+    // short explanation, in the warning messages.
+    $warning_messages = $assert_session->elementExists('xpath', '//div[@data-drupal-messages]//div[@aria-label="Warning message"]');
+    $this->assertStringContainsString('Database updates have been detected in the following extensions.<ul><li>System</li><li>Automatic Updates Theme With Updates</li></ul>', $warning_messages->getHtml());
+
+    $this->acceptWarningAndUpdate();
+    $assert_session->addressEquals('/admin/reports/updates');
+    // Confirm that the site was in maintenance before the update was applied.
+    // @see \Drupal\package_manager_test_validation\EventSubscriber\TestSubscriber::handleEvent()
+    $this->assertTrue($state->get(PreApplyEvent::class . '.system.maintenance_mode'));
+    $assert_session->pageTextContainsOnce('Update complete!');
+    // Confirm the site was returned to the original maintenance mode state.
+    $this->assertSame($state->get('system.maintenance_mode'), $maintenance_mode_on);
+    // Confirm that the apply and post-apply operations happened in
+    // separate requests.
+    // @see \Drupal\automatic_updates_test\EventSubscriber\RequestTimeRecorder
+    $pre_apply_time = $state->get('Drupal\package_manager\Event\PreApplyEvent time');
+    $post_apply_time = $state->get('Drupal\package_manager\Event\PostApplyEvent time');
+    $this->assertNotEmpty($pre_apply_time);
+    $this->assertNotEmpty($post_apply_time);
+    $this->assertNotSame($pre_apply_time, $post_apply_time);
+  }
+
+}

automatic_updates_extensions/tests/src/Functional/UnsuccessfulUpdateTest.php

+<?php
+
+declare(strict_types = 1);
+
+namespace Drupal\Tests\automatic_updates_extensions\Functional;
+
+use Drupal\automatic_updates_test\EventSubscriber\TestSubscriber1;
+use Drupal\package_manager\Event\StatusCheckEvent;
+use Drupal\package_manager\ValidationResult;
+use Drupal\package_manager_test_validation\EventSubscriber\TestSubscriber;
+
+/**
+ * @covers \Drupal\automatic_updates_extensions\Form\UpdaterForm
+ * @group automatic_updates_extensions
+ * @internal
+ */
+final class UnsuccessfulUpdateTest extends UpdaterFormTestBase {
+
+  /**
+   * Test the form for warning messages.
+   */
+  public function testWarnings(): void {
+    $this->setReleaseMetadata(__DIR__ . '/../../fixtures/release-history/semver_test.1.1.xml');
+    $assert = $this->assertSession();
+    $this->setProjectInstalledVersion(['semver_test' => '8.1.0']);
+    $this->checkForUpdates();
+    $message = t("Warning! Updating this module may cause an error.");
+    $warning = ValidationResult::createWarning([$message]);
+    TestSubscriber1::setTestResult([$warning], StatusCheckEvent::class);
+    // Navigate to the automatic updates form.
+    $this->drupalGet('/admin/reports/updates');
+    $this->clickLink('Update Extensions');
+    $this->assertTableShowsUpdates('Semver Test', '8.1.0', '8.1.1');
+    $this->getStageFixtureManipulator()->setVersion('drupal/semver_test_package_name', '8.1.1');
+    $this->assertUpdatesCount(1);
+    $this->checkForMetaRefresh();
+    $assert->pageTextNotContains(static::$errorsExplanation);
+    $assert->elementExists('css', '#edit-projects-semver-test')->check();
+    $assert->checkboxChecked('edit-projects-semver-test');
+    // No explanation is given for warnings.
+    $assert->pageTextNotContains(static::$warningsExplanation);
+    $assert->buttonExists('Update');
+
+    // Add warnings from StatusCheckEvent.
+    $summary_status_check_event = t('Some summary');
+    $messages_status_check_event = [
+      t("The only thing we're allowed to do is to"),
+      t("believe that we won't regret the choice"),
+      t("we made."),
+    ];
+    $warning_status_check_event = ValidationResult::createWarning($messages_status_check_event, $summary_status_check_event);
+    TestSubscriber::setTestResult([$warning_status_check_event], StatusCheckEvent::class);
+    $this->getSession()->getPage()->pressButton('Update');
+    $this->checkForMetaRefresh();
+    $assert->buttonExists('Continue');
+    $assert->pageTextContains((string) $summary_status_check_event);
+    foreach ($messages_status_check_event as $message) {
+      $assert->pageTextContains((string) $message);
+    }
+  }
+
+  /**
+   * Tests the form when an uninstallable module requires an update.
+   */
+  public function testUninstallableRelease(): void {
+    $this->container->get('state')->set('testUninstallableRelease', TRUE);
+    $this->setReleaseMetadata(__DIR__ . '/../../fixtures/release-history/semver_test.1.1.xml');
+    $this->setProjectInstalledVersion(['semver_test' => '8.1.0']);
+    $user = $this->createUser(['administer software updates', 'administer site configuration']);
+    $this->drupalLogin($user);
+    $this->drupalGet('admin/reports/updates/automatic-update-extensions');
+    $this->checkForUpdates();
+    $this->assertNoUpdates();
+  }
+
+}

automatic_updates_extensions/tests/src/Functional/UpdateErrorTest.php

+<?php
+
+declare(strict_types = 1);
+
+namespace Drupal\Tests\automatic_updates_extensions\Functional;
+
+use Drupal\automatic_updates_test\EventSubscriber\TestSubscriber1;
+use Drupal\package_manager\Event\StatusCheckEvent;
+use Drupal\package_manager\ValidationResult;
+use Drupal\package_manager_bypass\LoggingCommitter;
+use Drupal\package_manager_test_validation\EventSubscriber\TestSubscriber;
+
+/**
+ * @covers \Drupal\automatic_updates_extensions\Form\UpdaterForm
+ * @group automatic_updates_extensions
+ * @internal
+ */
+final class UpdateErrorTest extends UpdaterFormTestBase {
+
+  /**
+   * Tests that an exception is thrown if a previous apply failed.
+   */
+  public function testMarkerFileFailure(): void {
+    $this->setReleaseMetadata(__DIR__ . '/../../fixtures/release-history/semver_test.1.1.xml');
+    $this->setProjectInstalledVersion(['semver_test' => '8.1.0']);
+    $this->checkForUpdates();
+    $page = $this->getSession()->getPage();
+    // Navigate to the automatic updates form.
+    $this->drupalGet('/admin/modules/automatic-update-extensions');
+    $assert_session = $this->assertSession();
+    $assert_session->pageTextNotContains(static::$errorsExplanation);
+    $assert_session->pageTextNotContains(static::$warningsExplanation);
+
+    $this->assertTableShowsUpdates('Semver Test', '8.1.0', '8.1.1');
+    $this->getStageFixtureManipulator()->setVersion('drupal/semver_test_package_name', '8.1.1');
+    $this->assertUpdatesCount(1);
+    $page->checkField('projects[semver_test]');
+    $page->pressButton('Update');
+    $this->checkForMetaRefresh();
+    $this->assertUpdateStagedTimes(1);
+    $assert_session->pageTextNotContains('The following dependencies will also be updated:');
+    LoggingCommitter::setException(new \Exception('failed at committer'));
+    $this->acceptWarningAndUpdate();
+    $failure_message = 'Automatic updates failed to apply, and the site is in an indeterminate state. Consider restoring the code and database from a backup.';
+    $assert_session->pageTextContainsOnce('An error has occurred.');
+    $assert_session->pageTextContains($failure_message);
+    $page->clickLink('the error page');
+
+    // We should be on the form (i.e., 200 response code), but unable to
+    // continue the update.
+    $assert_session->statusCodeEquals(200);
+    $assert_session->pageTextContains($failure_message);
+    $assert_session->buttonNotExists('Continue');
+    // The same thing should be true if we try to start from the beginning.
+    $this->drupalGet('/admin/modules/automatic-update-extensions');
+    $assert_session->statusCodeEquals(200);
+    $assert_session->pageTextContains($failure_message);
+    $assert_session->buttonNotExists('Update');
+  }
+
+  /**
+   * Test the form for errors.
+   */
+  public function testErrors(): void {
+    $this->setReleaseMetadata(__DIR__ . '/../../fixtures/release-history/semver_test.1.1.xml');
+    $assert = $this->assertSession();
+    $user = $this->createUser([
+      'administer site configuration',
+      'administer software updates',
+    ]);
+    $this->drupalLogin($user);
+    $this->setProjectInstalledVersion(['semver_test' => '8.1.0']);
+    $this->checkForUpdates();
+    $this->drupalGet('admin/reports/updates/automatic-update-extensions');
+    $this->assertTableShowsUpdates('Semver Test', '8.1.0', '8.1.1');
+    $this->assertUpdatesCount(1);
+    $message = t("You've not experienced Shakespeare until you have read him in the original Klingon.");
+    $error = ValidationResult::createError([$message]);
+    TestSubscriber1::setTestResult([$error], StatusCheckEvent::class);
+    $this->getSession()->reload();
+    $assert->pageTextContains((string) $message);
+    $assert->pageTextContains(static::$errorsExplanation);
+    $assert->pageTextNotContains(static::$warningsExplanation);
+    $assert->buttonNotExists('Update');
+  }
+
+  /**
+   * Tests that messages from StatusCheckEvent are shown on the confirmation form.
+   */
+  public function testStatusErrorMessages(): void {
+    $this->setReleaseMetadata(__DIR__ . '/../../fixtures/release-history/semver_test.1.1.xml');
+    $assert = $this->assertSession();
+    $this->setProjectInstalledVersion(['semver_test' => '8.1.0']);
+    $this->checkForUpdates();
+    $this->drupalGet('admin/reports/updates/automatic-update-extensions');
+    $this->assertTableShowsUpdates('Semver Test', '8.1.0', '8.1.1');
+    $this->assertUpdatesCount(1);
+    $this->getSession()->reload();
+    $assert->elementExists('css', '#edit-projects-semver-test')->check();
+    $assert->checkboxChecked('edit-projects-semver-test');
+    $assert->buttonExists('Update');
+    $messages = [
+      t("The only thing we're allowed to do is to"),
+      t("believe that we won't regret the choice"),
+      t("we made."),
+    ];
+    $summary = t('Some summary');
+    $error = ValidationResult::createError($messages, $summary);
+    TestSubscriber::setTestResult([$error], StatusCheckEvent::class);
+    $this->getSession()->getPage()->pressButton('Update');
+    $this->checkForMetaRefresh();
+    $assert->pageTextContains(static::$errorsExplanation);
+    $assert->pageTextNotContains(static::$warningsExplanation);
+    $assert->pageTextContains((string) $summary);
+    foreach ($messages as $message) {
+      $assert->pageTextContains((string) $message);
+    }
+    $assert->buttonNotExists('Continue');
+  }
+
+}

automatic_updates_extensions/tests/src/Functional/UpdaterFormTestBase.php

+<?php
+
+declare(strict_types = 1);
+
+namespace Drupal\Tests\automatic_updates_extensions\Functional;
+
+use Drupal\fixture_manipulator\ActiveFixtureManipulator;
+use Drupal\package_manager\PathLocator;
+use Drupal\Tests\automatic_updates_extensions\Traits\FormTestTrait;
+use Drupal\Tests\automatic_updates\Functional\UpdaterFormTestBase as UpdaterFormFunctionalTestBase;
+
+/**
+ * Base class for functional tests of updater form.
+ *
+ * @internal
+ *   This class is an internal part of the module's testing infrastructure and
+ *   should not be used by external code.
+ */
+abstract class UpdaterFormTestBase extends UpdaterFormFunctionalTestBase {
+
+  use FormTestTrait;
+
+  /**
+   * {@inheritdoc}
+   */
+  protected static $errorsExplanation = 'Your site cannot be automatically updated until further action is performed.';
+
+  /**
+   * The path of the test project's active directory.
+   *
+   * @var string
+   */
+  private $activeDir;
+
+  /**
+   * {@inheritdoc}
+   */
+  protected static $modules = [
+    'automatic_updates_extensions',
+    'semver_test',
+    'aaa_update_test',
+    'automatic_updates_extensions_test',
+  ];
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function setUp(): void {
+    parent::setUp();
+
+    $this->activeDir = $this->container->get(PathLocator::class)->getProjectRoot();
+    (new ActiveFixtureManipulator())
+      // Add a package where the Composer package name,
+      // drupal/semver_test_package_name, does not match the project name,
+      // semver_test.
+      ->addPackage(
+        [
+          'name' => 'drupal/semver_test_package_name',
+          'version' => '8.1.0',
+          'type' => 'drupal-module',
+        ],
+        extra_files: [
+          'semver_test.info.yml' => '{name: "Semver Test", project: "semver_test", type: "module"}',
+        ]
+      )
+      ->addPackage([
+        'name' => 'drupal/aaa_update_test',
+        'version' => '2.0.0',
+        'type' => 'drupal-module',
+      ])
+      ->addPackage([
+        'name' => 'drupal/automatic_updates_extensions_test_theme',
+        'version' => '2.0.0',
+        'type' => 'drupal-theme',
+      ])
+      ->commitChanges();
+    $this->drupalPlaceBlock('local_tasks_block', ['primary' => TRUE]);
+  }
+
+  /**
+   * Sets installed project version.
+   *
+   * @todo Remove this function with use of the trait from the Update module in
+   *   https://drupal.org/i/3348234.
+   */
+  protected function setProjectInstalledVersion($project_versions): void {
+    $this->config('update.settings')
+      ->set('fetch.url', $this->baseUrl . '/test-release-history')
+      ->save();
+    $system_info = [];
+    foreach ($project_versions as $project_name => $version) {
+      $system_info[$project_name] = [
+        'project' => $project_name,
+        'version' => $version,
+        'hidden' => FALSE,
+      ];
+    }
+    $system_info['drupal'] = [
+      'project' => 'drupal',
+      'version' => '8.0.0',
+      'hidden' => FALSE,
+    ];
+    $this->config('update_test.settings')
+      ->set('system_info', $system_info)
+      ->save();
+  }
+
+  /**
+   * Asserts the table shows the updates.
+   *
+   * @param string $expected_project_title
+   *   The expected project title.
+   * @param string $expected_installed_version
+   *   The expected installed version.
+   * @param string $expected_target_version
+   *   The expected target version.
+   * @param int $row
+   *   The row number.
+   */
+  protected function assertTableShowsUpdates(string $expected_project_title, string $expected_installed_version, string $expected_target_version, int $row = 1): void {
+    $this->assertUpdateTableRow($this->assertSession(), $expected_project_title, $expected_installed_version, $expected_target_version, $row);
+  }
+
+  /**
+   * Asserts the form shows no updates.
+   */
+  protected function assertNoUpdates(): void {
+    $assert = $this->assertSession();
+    $assert->buttonNotExists('Update');
+    $assert->pageTextContains('There are no available updates.');
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function checkForUpdates(): void {
+    $this->drupalGet('/admin/modules/automatic-update-extensions');
+    $this->clickLink('Check manually');
+    $this->checkForMetaRefresh();
+  }
+
+  /**
+   * Continue the update after checking the backup warning checkbox.
+   */
+  protected function acceptWarningAndUpdate(): void {
+    $page = $this->getSession()->getPage();
+    $page->pressButton('Continue');
+    $this->assertSession()->statusMessageContains('Warning: Updating contributed modules or themes may leave your site inoperable or looking wrong. field is required.', 'error');
+    $page->checkField('backup');
+    $page->pressButton('Continue');
+    $this->checkForMetaRefresh();
+  }
+
+}

automatic_updates_extensions/tests/src/Kernel/AutomaticUpdatesExtensionsKernelTestBase.php

 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\Tests\automatic_updates_extensions\Kernel;
 
-use Drupal\automatic_updates_extensions\ExtensionUpdater;
-use Drupal\Core\DependencyInjection\ContainerBuilder;
-use Drupal\package_manager\Exception\StageValidationException;
+use Drupal\automatic_updates_extensions\ExtensionUpdateStage;
+use Drupal\fixture_manipulator\ActiveFixtureManipulator;
+use Drupal\package_manager\Event\PreOperationStageEvent;
+use Drupal\package_manager\Exception\StageEventException;
+use Drupal\package_manager\Validator\ComposerValidator;
 use Drupal\Tests\automatic_updates\Kernel\AutomaticUpdatesKernelTestBase;
-use Drupal\Tests\package_manager\Kernel\TestPathFactory;
-use Drupal\Tests\package_manager\Kernel\TestStageTrait;
 
 /**
  * Base class for kernel tests of the Automatic Updates Extensions module.
+ *
+ * @internal
+ *   This class is an internal part of the module's testing infrastructure and
+ *   should not be used by external code.
  */
 abstract class AutomaticUpdatesExtensionsKernelTestBase extends AutomaticUpdatesKernelTestBase {
 
@@ -31,36 +37,40 @@ abstract class AutomaticUpdatesExtensionsKernelTestBase extends AutomaticUpdates
     // server. This should be okay in most situations because, apart from the
     // validator, only Composer Stager needs run Composer, and
     // package_manager_bypass is disabling those operations.
-    $this->disableValidators[] = 'package_manager.validator.composer_executable';
+    $this->disableValidators[] = ComposerValidator::class;
     parent::setUp();
-  }
-
-  /**
-   * Create Virtual Project.
-   *
-   * @param string|null $source_dir
-   *   Source directory.
-   */
-  protected function createVirtualProject(?string $source_dir = NULL): void {
-    $source_dir = $source_dir ?? __DIR__ . '/../../fixtures/fake-site';
-    parent::createVirtualProject($source_dir);
-  }
-
-  /**
-   * {@inheritdoc}
-   */
-  public function register(ContainerBuilder $container) {
-    parent::register($container);
-
-    // Use the test-only implementations of the regular and cron updaters.
-    $overrides = [
-      'automatic_updates_extensions.updater' => TestExtensionUpdater::class,
-    ];
-    foreach ($overrides as $service_id => $class) {
-      if ($container->hasDefinition($service_id)) {
-        $container->getDefinition($service_id)->setClass($class);
-      }
-    }
+    // Install additional packages that will be needed in tests.
+    (new ActiveFixtureManipulator())
+      ->addPackage([
+        "name" => "drupal/my_module",
+        "version" => "9.8.0",
+        "type" => "drupal-module",
+      ])
+      ->addPackage([
+        "name" => "drupal/contrib_profile1",
+        "version" => "1.0.0",
+        "type" => "drupal-profile",
+      ])
+      ->addPackage([
+        "name" => "drupal/my_dev_module",
+        "version" => "9.8.1",
+        "type" => "drupal-module",
+      ], TRUE)
+      ->addPackage([
+        "name" => "drupal/semver_test",
+        "version" => "8.1.0",
+        "type" => "drupal-module",
+      ])
+      ->addPackage([
+        "name" => "drupal/aaa_update_test",
+        "version" => "1.0.0",
+        "type" => "drupal-module",
+      ])
+      ->addPackage([
+        "name" => "drupal/package_manager_test_update",
+        "version" => "1.0.0",
+        "type" => "drupal-module",
+      ])->commitChanges();
   }
 
   /**
@@ -75,57 +85,25 @@ abstract class AutomaticUpdatesExtensionsKernelTestBase extends AutomaticUpdates
    *   be passed if $expected_results is not empty.
    */
   protected function assertUpdateResults(array $project_versions, array $expected_results, string $event_class = NULL): void {
-    $updater = $this->createExtensionUpdater();
+    $stage = $this->container->get(ExtensionUpdateStage::class);
 
     try {
-      $updater->begin($project_versions);
-      $updater->stage();
-      $updater->apply();
-      $updater->postApply();
-      $updater->destroy();
+      $stage->begin($project_versions);
+      $stage->stage();
+      $stage->apply();
+      $stage->postApply();
+      $stage->destroy();
 
       // If we did not get an exception, ensure we didn't expect any results.
       $this->assertEmpty($expected_results);
     }
-    catch (StageValidationException $e) {
+    catch (StageEventException $e) {
       $this->assertNotEmpty($expected_results);
-      $this->assertValidationResultsEqual($expected_results, $e->getResults());
-      // TestStage::dispatch() attaches the event object to the exception so
-      // that we can analyze it.
-      $this->assertNotEmpty($event_class);
-      $this->assertInstanceOf($event_class, $e->event);
+      $exception_event = $e->event;
+      $this->assertInstanceOf($event_class, $exception_event);
+      $this->assertInstanceOf(PreOperationStageEvent::class, $exception_event);
+      $this->assertValidationResultsEqual($expected_results, $e->event->getResults());
     }
   }
 
-  /**
-   * Creates an extension updater object for testing purposes.
-   *
-   * @return \Drupal\Tests\automatic_updates_extensions\Kernel\TestExtensionUpdater
-   *   A extension updater object, with test-only modifications.
-   */
-  protected function createExtensionUpdater(): TestExtensionUpdater {
-    return new TestExtensionUpdater(
-      $this->container->get('config.factory'),
-      $this->container->get('package_manager.path_locator'),
-      $this->container->get('package_manager.beginner'),
-      $this->container->get('package_manager.stager'),
-      $this->container->get('package_manager.committer'),
-      $this->container->get('file_system'),
-      $this->container->get('event_dispatcher'),
-      $this->container->get('tempstore.shared'),
-      $this->container->get('datetime.time'),
-      new TestPathFactory(),
-      $this->container->get('package_manager.failure_marker')
-    );
-  }
-
-}
-
-/**
- * A test-only version of the regular extension updater to override internals.
- */
-class TestExtensionUpdater extends ExtensionUpdater {
-
-  use TestStageTrait;
-
 }

automatic_updates_extensions/tests/src/Kernel/ExtensionUpdaterTest.php → automatic_updates_extensions/tests/src/Kernel/ExtensionUpdateStageTest.php

 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\Tests\automatic_updates_extensions\Kernel;
 
-use Drupal\automatic_updates\Exception\UpdateException;
-use Drupal\automatic_updates_test\EventSubscriber\TestSubscriber1;
-use Drupal\package_manager\Event\PreApplyEvent;
-use Drupal\package_manager\Event\PreCreateEvent;
-use Drupal\package_manager\Event\PreRequireEvent;
-use Drupal\package_manager\ValidationResult;
+use Drupal\automatic_updates_extensions\ExtensionUpdateStage;
+use Drupal\automatic_updates_extensions\Validator\UpdateReleaseValidator;
 use Drupal\Tests\user\Traits\UserCreationTrait;
+use PhpTuf\ComposerStager\API\Core\StagerInterface;
 
 /**
- * @coversDefaultClass \Drupal\automatic_updates_extensions\ExtensionUpdater
- *
+ * @coversDefaultClass \Drupal\automatic_updates_extensions\ExtensionUpdateStage
  * @group automatic_updates_extensions
+ * @internal
  */
-class ExtensionUpdaterTest extends AutomaticUpdatesExtensionsKernelTestBase {
+final class ExtensionUpdateStageTest extends AutomaticUpdatesExtensionsKernelTestBase {
 
   use UserCreationTrait;
 
@@ -36,26 +35,24 @@ class ExtensionUpdaterTest extends AutomaticUpdatesExtensionsKernelTestBase {
     // This test doesn't need to validate that the test projects used are in the
     // codebase. Therefore, we need to disable the following validators that
     // require real Drupal projects.
-    $this->disableValidators[] = 'automatic_updates_extensions.validator.target_release';
+    $this->disableValidators[] = UpdateReleaseValidator::class;
     parent::setUp();
     $this->installEntitySchema('user');
 
     // Create a user who will own the stage even after the container is rebuilt.
     $user = $this->createUser([], NULL, TRUE, ['uid' => 2]);
     $this->setCurrentUser($user);
-
-    $this->createVirtualProject(__DIR__ . '/../../fixtures/fake-site');
   }
 
   /**
    * Tests that correct versions are staged after calling ::begin().
    */
   public function testCorrectVersionsStaged(): void {
-    $id = $this->container->get('automatic_updates_extensions.updater')->begin([
+    $id = $this->container->get(ExtensionUpdateStage::class)->begin([
       'my_module' => '9.8.1',
       // Use a legacy version number to ensure they are converted to semantic
       // version numbers which will work with the drupal.org Composer facade.
-      'my_dev_module' => '8.x-1.2-alpha1',
+      'my_dev_module' => '8.x-1.2-alpha1@alpha',
     ]);
     $user = $this->container->get('current_user')->getAccount();
     // Rebuild the container to ensure the package versions are persisted.
@@ -66,7 +63,7 @@ class ExtensionUpdaterTest extends AutomaticUpdatesExtensionsKernelTestBase {
     // Keep using the user account we created.
     $this->setCurrentUser($user);
 
-    $extension_updater = $this->container->get('automatic_updates_extensions.updater');
+    $stage = $this->container->get(ExtensionUpdateStage::class);
 
     // Ensure that the target package versions are what we expect.
     $expected_versions = [
@@ -74,12 +71,12 @@ class ExtensionUpdaterTest extends AutomaticUpdatesExtensionsKernelTestBase {
         'drupal/my_module' => '9.8.1',
       ],
       'dev' => [
-        'drupal/my_dev_module' => '1.2.0-alpha1',
+        'drupal/my_dev_module' => '1.2.0-alpha1@alpha',
       ],
     ];
-    $this->assertSame($expected_versions, $extension_updater->claim($id)->getPackageVersions());
+    $this->assertSame($expected_versions, $stage->claim($id)->getPackageVersions());
 
-    // When we call ExtensionUpdater::stage(), the stored project versions
+    // When we call ExtensionUpdateStage::stage(), the stored project versions
     // should be read from state and passed to Composer Stager's Stager service,
     // in the form of a Composer command. This is done using
     // package_manager_bypass's invocation recorder, rather than a regular mock,
@@ -98,21 +95,22 @@ class ExtensionUpdaterTest extends AutomaticUpdatesExtensionsKernelTestBase {
         'require',
         '--dev',
         '--no-update',
-        'drupal/my_dev_module:1.2.0-alpha1',
+        'drupal/my_dev_module:1.2.0-alpha1@alpha',
       ],
       [
         'update',
         '--with-all-dependencies',
+        '--optimize-autoloader',
         'drupal/my_module:9.8.1',
-        'drupal/my_dev_module:1.2.0-alpha1',
+        'drupal/my_dev_module:1.2.0-alpha1@alpha',
       ],
     ];
-    $extension_updater->stage();
+    $stage->stage();
 
-    $actual_arguments = $this->container->get('package_manager.stager')
+    $actual_arguments = $this->container->get(StagerInterface::class)
       ->getInvocationArguments();
 
-    $this->assertSame(count($expected_arguments), count($actual_arguments));
+    $this->assertCount(count($expected_arguments), $actual_arguments);
     foreach ($actual_arguments as $i => [$arguments]) {
       $this->assertSame($expected_arguments[$i], $arguments);
     }
@@ -122,10 +120,10 @@ class ExtensionUpdaterTest extends AutomaticUpdatesExtensionsKernelTestBase {
    * Tests that attempting to update an install profile throws an exception.
    */
   public function testUpdatingInstallProfile(): void {
-    $this->expectException('InvalidArgumentException');
+    $this->expectException(\InvalidArgumentException::class);
     $this->expectExceptionMessage("The project contrib_profile1 cannot be updated because updating install profiles is not supported.");
 
-    $this->container->get('automatic_updates_extensions.updater')
+    $this->container->get(ExtensionUpdateStage::class)
       ->begin([
         'contrib_profile1' => '1.1.0',
       ]);
@@ -135,67 +133,20 @@ class ExtensionUpdaterTest extends AutomaticUpdatesExtensionsKernelTestBase {
    * Tests that an exception is thrown when calling begin() with no projects.
    */
   public function testNoProjectsInBegin(): void {
-    $this->expectException('InvalidArgumentException');
+    $this->expectException(\InvalidArgumentException::class);
     $this->expectExceptionMessage('No projects to begin the update');
-    $this->container->get('automatic_updates_extensions.updater')->begin([]);
+    $this->container->get(ExtensionUpdateStage::class)->begin([]);
   }
 
   /**
    * Tests exception if a Drupal project unknown to composer sent to ::begin().
    */
   public function testUnknownDrupalProject(): void {
-    $this->expectException('InvalidArgumentException');
+    $this->expectException(\InvalidArgumentException::class);
     $this->expectExceptionMessage("The project my_module_unknown is not a Drupal project known to Composer and cannot be updated.");
-    $this->container->get('automatic_updates_extensions.updater')->begin([
+    $this->container->get(ExtensionUpdateStage::class)->begin([
       'my_module_unknown' => '9.8.1',
     ]);
   }
 
-  /**
-   * Tests UpdateException handling.
-   *
-   * @param string $event_class
-   *   The stage life cycle event which should raise an error.
-   *
-   * @dataProvider providerUpdateException
-   */
-  public function testUpdateException(string $event_class): void {
-    $this->createVirtualProject(__DIR__ . '/../../fixtures/fake-site');
-    $extension_updater = $this->container->get('automatic_updates_extensions.updater');
-    $results = [
-      ValidationResult::createError(['An error of some sorts.']),
-    ];
-    TestSubscriber1::setTestResult($results, $event_class);
-    try {
-      $extension_updater->begin(['my_module' => '9.8.1']);
-      $extension_updater->stage();
-      $extension_updater->apply();
-      $this->fail('Expected an exception, but none was raised.');
-    }
-    catch (UpdateException $e) {
-      $this->assertStringStartsWith('An error of some sorts.', $e->getMessage());
-      $this->assertInstanceOf($event_class, $e->event);
-    }
-  }
-
-  /**
-   * Data provider for testUpdateException().
-   *
-   * @return string[][]
-   *   The test cases.
-   */
-  public function providerUpdateException(): array {
-    return [
-      'pre-create exception' => [
-        PreCreateEvent::class,
-      ],
-      'pre-require exception' => [
-        PreRequireEvent::class,
-      ],
-      'pre-apply exception' => [
-        PreApplyEvent::class,
-      ],
-    ];
-  }
-
 }

automatic_updates_extensions/tests/src/Kernel/Validator/UpdateReleaseValidatorTest.php

 <?php
 
+declare(strict_types = 1);
+
 namespace Drupal\Tests\automatic_updates_extensions\Kernel\Validator;
 
 use Drupal\package_manager\LegacyVersionUtility;
@@ -9,10 +11,15 @@ use Drupal\Tests\automatic_updates_extensions\Kernel\AutomaticUpdatesExtensionsK
 
 /**
  * @coversDefaultClass \Drupal\automatic_updates_extensions\Validator\UpdateReleaseValidator
- *
  * @group automatic_updates_extensions
+ * @internal
  */
-class UpdateReleaseValidatorTest extends AutomaticUpdatesExtensionsKernelTestBase {
+final class UpdateReleaseValidatorTest extends AutomaticUpdatesExtensionsKernelTestBase {
+
+  /**
+   * {@inheritdoc}
+   */
+  protected static $modules = ['automatic_updates'];
 
   /**
    * Data provider for testPreCreateException().
@@ -46,25 +53,35 @@ class UpdateReleaseValidatorTest extends AutomaticUpdatesExtensionsKernelTestBas
   public function testPreCreateException(string $project, string $installed_version, string $target_version, bool $error_expected): void {
     $this->enableModules([$project]);
 
+    // @todo Replace with use of the trait from the Update module in https://drupal.org/i/3348234.
     $module_info = ['version' => $installed_version, 'project' => $project];
     $this->config('update_test.settings')
       ->set("system_info.$project", $module_info)
       ->save();
 
+    $path_to_fixtures_folder = $project === 'aaa_update_test' ? '/../../../../../package_manager/tests/' : '/../../../';
     $this->setReleaseMetadata([
-      $project => __DIR__ . "/../../../fixtures/release-history/$project.1.1.xml",
+      $project => __DIR__ . $path_to_fixtures_folder . "fixtures/release-history/$project.1.1.xml",
       'drupal' => __DIR__ . '/../../../../../package_manager/tests/fixtures/release-history/drupal.9.8.2.xml',
     ]);
 
     if ($error_expected) {
       $expected_results = [
         ValidationResult::createError(
-          ["Project $project to version " . LegacyVersionUtility::convertToSemanticVersion($target_version)],
+          [
+            t('Project @project to version @target_version', [
+              '@project' => $project,
+              '@target_version' => LegacyVersionUtility::convertToSemanticVersion($target_version),
+            ]),
+          ],
           t('Cannot update because the following project version is not in the list of installable releases.')
         ),
       ];
     }
     else {
+      // Ensure the correct version of the package is staged because the update
+      // is expected to succeed.
+      $this->getStageFixtureManipulator()->setVersion("drupal/$project", LegacyVersionUtility::convertToSemanticVersion($target_version));
       $expected_results = [];
     }
 

config/install/automatic_updates.settings.yml

-cron: security
+unattended:
+  method: web
+  level: disable
 allow_core_minor_updates: false
+status_check_mail: errors_only