From ff67d00490a5b11eab6683b372b9903a3623c731 Mon Sep 17 00:00:00 2001
From: Kunal Sachdev <57170-kunal.sachdev@users.noreply.drupalcode.org>
Date: Fri, 28 Apr 2023 09:24:20 +0000
Subject: [PATCH] Issue #3356640 by kunal.sachdev, phenaproxima, Wim Leers:
Explain why ComposerPluginsValidatorTest::testAddDisallowedPlugin() exists,
even if it is not directly testing ComposerPluginsValidator
---
.../tests/src/Kernel/ComposerPluginsValidatorTest.php | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/package_manager/tests/src/Kernel/ComposerPluginsValidatorTest.php b/package_manager/tests/src/Kernel/ComposerPluginsValidatorTest.php
index 9a20576a60..30f78859c3 100644
--- a/package_manager/tests/src/Kernel/ComposerPluginsValidatorTest.php
+++ b/package_manager/tests/src/Kernel/ComposerPluginsValidatorTest.php
@@ -104,6 +104,16 @@ class ComposerPluginsValidatorTest extends PackageManagerKernelTestBase {
/**
* Tests adding a plugin that's not allowed by the allow-plugins config.
+ *
+ * The exception that this test looks for is not necessarily triggered by
+ * ComposerPluginsValidator; Composer will exit with an error if there is an
+ * installed plugin that is not allowed by the `allow-plugins` config. In
+ * practice, this means that whichever validator is the first one to do a
+ * Composer operation (via ComposerInspector) will get the exception -- it
+ * may or may not be ComposerPluginsValidator.
+ *
+ * This test is here to ensure that Composer's behavior remains consistent,
+ * even if we're not explicitly testing ComposerPluginsValidator here.
*/
public function testAddDisallowedPlugin(): void {
$this->getStageFixtureManipulator()
--
GitLab