diff --git a/package_manager/src/ComposerInspector.php b/package_manager/src/ComposerInspector.php index 92158f26f04689d91d10f4043adb50f26db8fc6c..9c2d5f5a51a34a79a8cd8062a9993183e8aa3cb9 100644 --- a/package_manager/src/ComposerInspector.php +++ b/package_manager/src/ComposerInspector.php @@ -229,10 +229,8 @@ class ComposerInspector { * * @throws \UnexpectedValueException * Thrown if the expect data format is not found. - * - * @todo Make this method private in https://drupal.org/i/3344556. */ - public function getVersion(string $working_dir): string { + private function getVersion(string $working_dir): string { $this->runner->run(['--format=json', "--working-dir=$working_dir"], $this->jsonCallback); $data = $this->jsonCallback->getOutputData(); if (isset($data['application']['name']) diff --git a/package_manager/tests/src/Kernel/ComposerInspectorTest.php b/package_manager/tests/src/Kernel/ComposerInspectorTest.php index f45c969b4fd2f36bc8052caf66efdcd69001f9ff..ef7f12f58c67aeae18cf0151b6775305d9bc88e8 100644 --- a/package_manager/tests/src/Kernel/ComposerInspectorTest.php +++ b/package_manager/tests/src/Kernel/ComposerInspectorTest.php @@ -59,20 +59,6 @@ class ComposerInspectorTest extends PackageManagerKernelTestBase { $inspector->getConfig('extra', $dir); } - /** - * @covers ::getVersion - */ - public function testGetVersion() { - $dir = __DIR__ . '/../../fixtures/fake_site'; - $inspector = $this->container->get('package_manager.composer_inspector'); - $version = $inspector->getVersion($dir); - // We can assert an exact version of Composer, but we can assert that the - // number is in the expected 'MAJOR.MINOR.PATCH' format. - $parts = explode('.', $version); - $this->assertCount(3, $parts); - $this->assertCount(3, array_filter($parts, 'is_numeric')); - } - /** * {@inheritdoc} */