From 54e7b572413ff729b01663c3b62abcedb36ab973 Mon Sep 17 00:00:00 2001 From: Ted Bowman <ted+git@tedbow.com> Date: Fri, 19 Apr 2024 14:32:44 -0400 Subject: [PATCH] remove comment type hints --- .../tests/src/Functional/UpdaterFormTestBase.php | 2 -- .../updated_module/1.1.0/src/PostApplySubscriber.php | 2 -- .../modules/package_manager_bypass/src/LoggingBeginner.php | 2 -- .../modules/package_manager_bypass/src/LoggingCommitter.php | 2 -- .../package_manager_bypass/src/LoggingDecoratorTrait.php | 2 -- .../modules/package_manager_bypass/src/MockPathLocator.php | 2 -- .../modules/package_manager_test_api/src/ApiController.php | 6 ------ .../src/EventSubscriber/TestSubscriber.php | 2 -- .../src/StagedDatabaseUpdateValidator.php | 2 -- package_manager/tests/src/Kernel/LockFileValidatorTest.php | 2 -- package_manager/tests/src/Kernel/RsyncValidatorTest.php | 2 -- package_manager/tests/src/Kernel/StageBaseTest.php | 2 -- package_manager/tests/src/Kernel/StageEventsTest.php | 2 -- src/CronUpdateRunner.php | 2 -- src/Validator/VersionPolicy/SupportedBranchInstalled.php | 2 -- src/Validator/WindowsValidator.php | 2 -- .../src/EventSubscriber/RequestTimeRecorder.php | 4 ---- tests/src/Build/CoreUpdateTest.php | 2 -- tests/src/Functional/StatusCheckTest.php | 6 ------ tests/src/Kernel/ConsoleUpdateStageTest.php | 2 -- tests/src/Traits/ValidationTestTrait.php | 4 ---- 21 files changed, 54 deletions(-) diff --git a/automatic_updates_extensions/tests/src/Functional/UpdaterFormTestBase.php b/automatic_updates_extensions/tests/src/Functional/UpdaterFormTestBase.php index b5ebf84b09..4ce4b7ae3a 100644 --- a/automatic_updates_extensions/tests/src/Functional/UpdaterFormTestBase.php +++ b/automatic_updates_extensions/tests/src/Functional/UpdaterFormTestBase.php @@ -27,8 +27,6 @@ abstract class UpdaterFormTestBase extends UpdaterFormFunctionalTestBase { /** * The path of the test project's active directory. - * - * @var string */ private string $activeDir; diff --git a/package_manager/tests/fixtures/build_test_projects/updated_module/1.1.0/src/PostApplySubscriber.php b/package_manager/tests/fixtures/build_test_projects/updated_module/1.1.0/src/PostApplySubscriber.php index 4138640997..0414453688 100644 --- a/package_manager/tests/fixtures/build_test_projects/updated_module/1.1.0/src/PostApplySubscriber.php +++ b/package_manager/tests/fixtures/build_test_projects/updated_module/1.1.0/src/PostApplySubscriber.php @@ -19,8 +19,6 @@ class PostApplySubscriber implements EventSubscriberInterface { /** * The path locator service. - * - * @var \Drupal\package_manager\PathLocator */ private PathLocator $pathLocator; diff --git a/package_manager/tests/modules/package_manager_bypass/src/LoggingBeginner.php b/package_manager/tests/modules/package_manager_bypass/src/LoggingBeginner.php index 8fdb71847e..7aa02358f2 100644 --- a/package_manager/tests/modules/package_manager_bypass/src/LoggingBeginner.php +++ b/package_manager/tests/modules/package_manager_bypass/src/LoggingBeginner.php @@ -23,8 +23,6 @@ final class LoggingBeginner implements BeginnerInterface { /** * The decorated service. - * - * @var \PhpTuf\ComposerStager\API\Core\BeginnerInterface */ private BeginnerInterface $inner; diff --git a/package_manager/tests/modules/package_manager_bypass/src/LoggingCommitter.php b/package_manager/tests/modules/package_manager_bypass/src/LoggingCommitter.php index 25a420cd05..38c0392117 100644 --- a/package_manager/tests/modules/package_manager_bypass/src/LoggingCommitter.php +++ b/package_manager/tests/modules/package_manager_bypass/src/LoggingCommitter.php @@ -23,8 +23,6 @@ final class LoggingCommitter implements CommitterInterface { /** * The decorated service. - * - * @var \PhpTuf\ComposerStager\API\Core\CommitterInterface */ private CommitterInterface $inner; diff --git a/package_manager/tests/modules/package_manager_bypass/src/LoggingDecoratorTrait.php b/package_manager/tests/modules/package_manager_bypass/src/LoggingDecoratorTrait.php index 93ad7b9105..d7de09f573 100644 --- a/package_manager/tests/modules/package_manager_bypass/src/LoggingDecoratorTrait.php +++ b/package_manager/tests/modules/package_manager_bypass/src/LoggingDecoratorTrait.php @@ -19,8 +19,6 @@ trait LoggingDecoratorTrait { /** * The state service. - * - * @var \Drupal\Core\State\StateInterface */ private StateInterface $state; diff --git a/package_manager/tests/modules/package_manager_bypass/src/MockPathLocator.php b/package_manager/tests/modules/package_manager_bypass/src/MockPathLocator.php index 380a562cdd..a5160e8227 100644 --- a/package_manager/tests/modules/package_manager_bypass/src/MockPathLocator.php +++ b/package_manager/tests/modules/package_manager_bypass/src/MockPathLocator.php @@ -17,8 +17,6 @@ final class MockPathLocator extends BasePathLocator { /** * The state service. - * - * @var \Drupal\Core\State\StateInterface */ private StateInterface $state; diff --git a/package_manager/tests/modules/package_manager_test_api/src/ApiController.php b/package_manager/tests/modules/package_manager_test_api/src/ApiController.php index 508ed69d86..705d7ab81b 100644 --- a/package_manager/tests/modules/package_manager_test_api/src/ApiController.php +++ b/package_manager/tests/modules/package_manager_test_api/src/ApiController.php @@ -26,22 +26,16 @@ class ApiController extends ControllerBase { /** * The route to redirect to after the stage has been applied. - * - * @var string */ protected string $finishedRoute = 'package_manager_test_api.finish'; /** * The stage. - * - * @var \Drupal\package_manager\StageBase */ protected StageBase $stage; /** * The path locator service. - * - * @var \Drupal\package_manager\PathLocator */ private PathLocator $pathLocator; diff --git a/package_manager/tests/modules/package_manager_test_validation/src/EventSubscriber/TestSubscriber.php b/package_manager/tests/modules/package_manager_test_validation/src/EventSubscriber/TestSubscriber.php index 6cf622d69d..bce9909d36 100644 --- a/package_manager/tests/modules/package_manager_test_validation/src/EventSubscriber/TestSubscriber.php +++ b/package_manager/tests/modules/package_manager_test_validation/src/EventSubscriber/TestSubscriber.php @@ -29,8 +29,6 @@ class TestSubscriber implements EventSubscriberInterface { /** * The state service. - * - * @var \Drupal\Core\State\StateInterface */ protected StateInterface $state; diff --git a/package_manager/tests/modules/package_manager_test_validation/src/StagedDatabaseUpdateValidator.php b/package_manager/tests/modules/package_manager_test_validation/src/StagedDatabaseUpdateValidator.php index da491f0adf..f1e269860d 100644 --- a/package_manager/tests/modules/package_manager_test_validation/src/StagedDatabaseUpdateValidator.php +++ b/package_manager/tests/modules/package_manager_test_validation/src/StagedDatabaseUpdateValidator.php @@ -15,8 +15,6 @@ class StagedDatabaseUpdateValidator extends BaseValidator { /** * The state service. - * - * @var \Drupal\Core\State\StateInterface */ private StateInterface $state; diff --git a/package_manager/tests/src/Kernel/LockFileValidatorTest.php b/package_manager/tests/src/Kernel/LockFileValidatorTest.php index d7a507c06e..c5f08d1886 100644 --- a/package_manager/tests/src/Kernel/LockFileValidatorTest.php +++ b/package_manager/tests/src/Kernel/LockFileValidatorTest.php @@ -26,8 +26,6 @@ class LockFileValidatorTest extends PackageManagerKernelTestBase { /** * The path of the active directory in the test project. - * - * @var string */ private string $activeDir; diff --git a/package_manager/tests/src/Kernel/RsyncValidatorTest.php b/package_manager/tests/src/Kernel/RsyncValidatorTest.php index 533679a931..15afe68c55 100644 --- a/package_manager/tests/src/Kernel/RsyncValidatorTest.php +++ b/package_manager/tests/src/Kernel/RsyncValidatorTest.php @@ -22,8 +22,6 @@ class RsyncValidatorTest extends PackageManagerKernelTestBase { /** * The mocked executable finder. - * - * @var \PhpTuf\ComposerStager\API\Finder\Service\ExecutableFinderInterface */ private ObjectProphecy&ExecutableFinderInterface $executableFinder; diff --git a/package_manager/tests/src/Kernel/StageBaseTest.php b/package_manager/tests/src/Kernel/StageBaseTest.php index f41929c28c..af05fc915b 100644 --- a/package_manager/tests/src/Kernel/StageBaseTest.php +++ b/package_manager/tests/src/Kernel/StageBaseTest.php @@ -818,8 +818,6 @@ class TestTime extends Time { /** * An offset to add to the request time. - * - * @var int */ public static int $offset = 0; diff --git a/package_manager/tests/src/Kernel/StageEventsTest.php b/package_manager/tests/src/Kernel/StageEventsTest.php index f30e87e0d1..89bd1f7479 100644 --- a/package_manager/tests/src/Kernel/StageEventsTest.php +++ b/package_manager/tests/src/Kernel/StageEventsTest.php @@ -38,8 +38,6 @@ class StageEventsTest extends PackageManagerKernelTestBase implements EventSubsc /** * The stage under test. - * - * @var \Drupal\package_manager\StageBase */ private StageBase $stage; diff --git a/src/CronUpdateRunner.php b/src/CronUpdateRunner.php index b38f713e13..988aff8495 100644 --- a/src/CronUpdateRunner.php +++ b/src/CronUpdateRunner.php @@ -33,8 +33,6 @@ class CronUpdateRunner implements CronInterface, LoggerAwareInterface { /** * The current interface between PHP and the server. - * - * @var string */ private static string $serverApi = PHP_SAPI; diff --git a/src/Validator/VersionPolicy/SupportedBranchInstalled.php b/src/Validator/VersionPolicy/SupportedBranchInstalled.php index 6224baf066..ee8410f5e2 100644 --- a/src/Validator/VersionPolicy/SupportedBranchInstalled.php +++ b/src/Validator/VersionPolicy/SupportedBranchInstalled.php @@ -25,8 +25,6 @@ final class SupportedBranchInstalled implements ContainerInjectionInterface { /** * The config factory service. - * - * @var \Drupal\Core\Config\ConfigFactoryInterface */ private ConfigFactoryInterface $configFactory; diff --git a/src/Validator/WindowsValidator.php b/src/Validator/WindowsValidator.php index 917b6cd119..e6730f7296 100644 --- a/src/Validator/WindowsValidator.php +++ b/src/Validator/WindowsValidator.php @@ -22,8 +22,6 @@ final class WindowsValidator implements EventSubscriberInterface { /** * The value of the PHP_OS constant. - * - * @var string */ private static string $os = PHP_OS; diff --git a/tests/modules/automatic_updates_test/src/EventSubscriber/RequestTimeRecorder.php b/tests/modules/automatic_updates_test/src/EventSubscriber/RequestTimeRecorder.php index 325c9d14d2..a5373352e8 100644 --- a/tests/modules/automatic_updates_test/src/EventSubscriber/RequestTimeRecorder.php +++ b/tests/modules/automatic_updates_test/src/EventSubscriber/RequestTimeRecorder.php @@ -18,15 +18,11 @@ class RequestTimeRecorder implements EventSubscriberInterface { /** * The state service. - * - * @var \Drupal\Core\State\StateInterface */ protected StateInterface $state; /** * The time service. - * - * @var \Drupal\Component\Datetime\TimeInterface */ protected TimeInterface $time; diff --git a/tests/src/Build/CoreUpdateTest.php b/tests/src/Build/CoreUpdateTest.php index 680b3a5f4b..9148073aa1 100644 --- a/tests/src/Build/CoreUpdateTest.php +++ b/tests/src/Build/CoreUpdateTest.php @@ -27,8 +27,6 @@ class CoreUpdateTest extends UpdateTestBase { /** * WebAssert object. - * - * @var \Drupal\Tests\WebAssert */ protected WebAssert $webAssert; diff --git a/tests/src/Functional/StatusCheckTest.php b/tests/src/Functional/StatusCheckTest.php index 796d9220e7..ba15d28f01 100644 --- a/tests/src/Functional/StatusCheckTest.php +++ b/tests/src/Functional/StatusCheckTest.php @@ -37,22 +37,16 @@ class StatusCheckTest extends AutomaticUpdatesFunctionalTestBase { /** * A user who can view the status report. - * - * @var \Drupal\user\Entity\User */ protected UserInterface $reportViewerUser; /** * A user who can view the status report and run status checks. - * - * @var \Drupal\user\Entity\User */ protected UserInterface $checkerRunnerUser; /** * The test checker. - * - * @var \Drupal\automatic_updates_test\EventSubscriber\TestSubscriber1 */ protected TestSubscriber1 $testChecker; diff --git a/tests/src/Kernel/ConsoleUpdateStageTest.php b/tests/src/Kernel/ConsoleUpdateStageTest.php index adffde2172..b40e4013b1 100644 --- a/tests/src/Kernel/ConsoleUpdateStageTest.php +++ b/tests/src/Kernel/ConsoleUpdateStageTest.php @@ -58,8 +58,6 @@ class ConsoleUpdateStageTest extends AutomaticUpdatesKernelTestBase { /** * The test logger. - * - * @var \ColinODell\PsrTestLogger\TestLogger */ private TestLogger $logger; diff --git a/tests/src/Traits/ValidationTestTrait.php b/tests/src/Traits/ValidationTestTrait.php index 248708141e..a9beb65748 100644 --- a/tests/src/Traits/ValidationTestTrait.php +++ b/tests/src/Traits/ValidationTestTrait.php @@ -20,15 +20,11 @@ trait ValidationTestTrait { /** * Expected explanation text when status checkers return error messages. - * - * @var string */ protected static string $errorsExplanation = 'Your site does not pass some readiness checks for automatic updates. It cannot be automatically updated until further action is performed.'; /** * Expected explanation text when status checkers return warning messages. - * - * @var string */ protected static string $warningsExplanation = 'Your site does not pass some readiness checks for automatic updates. Depending on the nature of the failures, it might affect the eligibility for automatic updates.'; -- GitLab