From 3f978a3a442c80040a87c12e95527529a3c2cf71 Mon Sep 17 00:00:00 2001
From: lucashedding <lucashedding@1463982.no-reply.drupal.org>
Date: Wed, 23 Oct 2019 15:21:45 -0600
Subject: [PATCH] Issue #3089754 by heddn: Only run modified file checking
against Drupal core
---
config/install/automatic_updates.settings.yml | 2 +-
tests/src/Functional/AutomaticUpdatesTest.php | 6 +++++-
.../src/Kernel/ReadinessChecker/MissingProjectInfoTest.php | 3 +++
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/config/install/automatic_updates.settings.yml b/config/install/automatic_updates.settings.yml
index a5dce8b4eb..5386402ba3 100644
--- a/config/install/automatic_updates.settings.yml
+++ b/config/install/automatic_updates.settings.yml
@@ -4,5 +4,5 @@ notify: true
check_frequency: 43200
enable_readiness_checks: true
hashes_uri: 'https://updates.drupal.org/release-hashes'
-ignored_paths: "modules/custom/*\nthemes/custom/*\nprofiles/custom/*"
+ignored_paths: "modules/*\nthemes/*\nprofiles/*"
download_uri: 'https://www.drupal.org/in-place-updates'
diff --git a/tests/src/Functional/AutomaticUpdatesTest.php b/tests/src/Functional/AutomaticUpdatesTest.php
index d01fc4c2db..3acc8fbf86 100644
--- a/tests/src/Functional/AutomaticUpdatesTest.php
+++ b/tests/src/Functional/AutomaticUpdatesTest.php
@@ -92,13 +92,17 @@ class AutomaticUpdatesTest extends BrowserTestBase {
* Tests manually running readiness checks.
*/
public function testReadinessChecks() {
+ $ignore_paths = "modules/custom/*\nthemes/custom/*\nprofiles/custom/*";
+ $this->config('automatic_updates.settings')->set('ignored_paths', $ignore_paths)
+ ->save();
// Test manually running readiness checks. A few warnings will occur.
$this->drupalGet(Url::fromRoute('automatic_updates.settings'));
$this->clickLink('run the readiness checks');
$this->assertSession()->pageTextContains('Your site does not pass some readiness checks for automatic updates. Depending on the nature of the failures, it might effect the eligibility for automatic updates.');
// Ignore specific file paths to see no readiness issues.
- $this->config('automatic_updates.settings')->set('ignored_paths', "core/*\nmodules/*\nthemes/*\nprofiles/*")
+ $ignore_paths = "core/*\nmodules/*\nthemes/*\nprofiles/*";
+ $this->config('automatic_updates.settings')->set('ignored_paths', $ignore_paths)
->save();
$this->drupalGet(Url::fromRoute('automatic_updates.settings'));
$this->clickLink('run the readiness checks');
diff --git a/tests/src/Kernel/ReadinessChecker/MissingProjectInfoTest.php b/tests/src/Kernel/ReadinessChecker/MissingProjectInfoTest.php
index ada97b1841..14a728dcb4 100644
--- a/tests/src/Kernel/ReadinessChecker/MissingProjectInfoTest.php
+++ b/tests/src/Kernel/ReadinessChecker/MissingProjectInfoTest.php
@@ -34,6 +34,9 @@ class MissingProjectInfoTest extends KernelTestBase {
public function testMissingProjectInfo() {
// The checker should always have messages on the testbot, since project
// info is added by the packager.
+ $ignore_paths = "modules/custom/*\nthemes/custom/*\nprofiles/custom/*";
+ $this->config('automatic_updates.settings')->set('ignored_paths', $ignore_paths)
+ ->save();
$messages = $this->container->get('automatic_updates.missing_project_info')->run();
$this->assertNotEmpty($messages);
--
GitLab