## Problem ### A removed segment exits 0 and reads as "agrees" The status report's *Audit trail segment anchors* entry, which is an error, sends the operator to `drush audit_trail:reindex-segments` (`docs/commands.md`). That entry reports two neighbouring segments that no longer meet over rows that are gone, which is what a segment removed from between them looks like after its own events have aged out. The chain no longer records that segment, so the index and the chain agree. `reindexSegments()` prints the break as a warning, but only index mismatches count as damage. So on exactly that state: - `--dry-run` exits **0**. `docs/commands.md` says it "exits 1 when anything disagrees, so a monitoring script can watch for a damaged index". - Both modes end with `Every segment index checked agrees with its chain.`, printed straight after the warning about the removed segment. - A real run also exits 0, although the class docblock defines 1 as "the audited state is bad", and a reindex cannot repair a hole: the rows are gone. An overlap (two segments claiming the same rows) goes through the same path. Observed on `1.x`: three archived and purged segments, the events that recorded them archived and purged in turn, then the middle segment's row deleted. `reindex-segments --chain=webdav --dry-run` exits 0 with: ``` ! [WARNING] Chain "webdav": segments #7 and #11 do not meet, and rows 3-4 are ! gone. A segment was removed from between them. Chain "webdav": index agrees with the chain (1 segment(s)). [OK] Every segment index checked agrees with its chain. ``` ### The two reindex commands are one body written twice `reindexSegments()` and `reindexAcknowledgments()` are about 70 lines each and the same line for line: resolve the chain option, compare, print agreement or the three-part difference, rebuild unless it is a dry run, map the outcome to an exit code. They differ only in the noun, the repository, and two segment-only extras (anchor breaks, unsealable segments). The exit-code defect above is in one copy only, which is what having two copies allows. ## Proposed resolution Move the shared body into one private method, `compareIndexWithChainAndRebuild()`. It takes the noun, the compare and rebuild steps, and a step that reports damage the comparison cannot see. The segment command passes its anchor-break report as that step, and it now returns whether it found any. A chain with an overlap or missing rows counts as damage the rebuild cannot repair: the command exits 1 in both modes and no longer claims the index agrees. Uncovered rows that are still present stay informational, as `findAnchorBreaks()` documents. ### A removed first segment is not seen at all `findAnchorBreaks()` compares each segment with the one before it, so the first segment is never compared with anything. Removing it leaves no break to report, and the status report stays green. The first segment should be held against the start of the chain: a segment covering the chain's first row has an empty `anchor_before`, so any other anchor, with no row of the chain left before it, means those rows are gone and nothing accounts for them. ## Remaining tasks None. --- AI-Generated: Yes (Claude Code was used to help draft this issue summary and to write the fix and its tests on the merge request. I reviewed and ran the work myself before posting it.)