## Problem Nine methods are named for a fragment of the sentence they appear in, so the name only resolves once you have found the subject and read the docblock. `$stage->destroys()` destroys what, `decide()` decides what, `valuesDiffer()` which values, `readsSignatures()` reads them for what purpose. A docblock that explains a name is the evidence the name failed. These all have good docblocks and none of them reads on its own. Most of them share one fault: the third-person verb. `destroys()`, `readsSignatures()`, `requiresEverySecret()`, `valuesDiffer()` are written as the predicate of a sentence whose subject is somewhere else. Verb-and-noun names are not the problem and are used throughout this module; a handful of third-person ones are defensible, but not this many, and not for values a caller has to act on. Core bears that out for `bool` returns in `lib` and `modules`: `is*` 125, `has*` 47, `supports*` 12, `needs*` 9, `should*` 5, against zero for `reads*`, `destroys`, `requires*` and `can*`. The unprefixed ones there are commands reporting success, not predicates. The last two are a different fault in the same place: `decide()` and `shouldEmit()` name no question at all, and `emit` is not a word this module uses for what it does. It records. ## The renames Each is taken from what the call sites do with the value, not from the docblock. | current | new | why | | --- | --- | --- | | `Chain\VerificationDepth::readsSignatures()` | `shouldVerifySignatures()` | Every caller uses it to decide whether to resolve a secret and compute an HMAC, and one sets `authenticationIncomplete` from its negation. | | `Chain\VerificationDepth::requiresEverySecret()` | `shouldFailOnUnverifiedSignature()` | It decides whether a signature that could not be verified is a finding or merely undetermined. The old name gave the mechanism, every secret resolving, rather than the consequence. | | `Time\RetentionThresholds::compactionIsOutOfOrder()` | `isCompactionOutOfOrder()` | Same words, and the prefix where a predicate carries it. | | `Segment\SegmentRetentionStage::destroys()` | `isErasure()` | The caller's own comment says it: "a stalled transient-purge or file-purge means data an operator asked to be destroyed is not". `erasure` is the word the module uses elsewhere for those stages. | | `Snapshot\SnapshotDelta::valuesDiffer()` | `hasValueChanged()` | Both callers ask whether a value changed, and one reads `!valuesDiffer(...)` to mean unchanged, which `!hasValueChanged(...)` says directly. | | `Snapshot\ConfigRedaction::decide()` | `shouldRedact()` | Its docblock says "TRUE when the value must not be recorded". The name said nothing at all. | | `Filter\AuditTrailFilterInterface::shouldEmit()` | `shouldRecord()` | A filter votes on whether the chain records the event. Nothing else in the module calls that emitting, and the filter's own settings, its plugin descriptions and the docs all say records. | | `Filter\ChainFilters::decide()` | `getRecordingVerdict()` | The aggregate over a chain's filters. It cannot be `shouldRecord()` because it returns the vote plus how far a no reaches plus the filters that threw, so the name says it hands back a verdict rather than a boolean. | | `Kernel\ChainArchiverTest::readLifecycleValidity()` | `hasValidLifecycleSignature()` | A test helper read straight into `assertFalse()`. It returns the segment's `valid_lifecycle_signature`, which is what the new name says. | Length is not a consideration where it buys clarity: `shouldFailOnUnverifiedSignature()` is long and says what it answers. The rename carries its namers with it: the local the filter loop reads the vote into, two `testShouldEmit()` methods and the data-provider docblocks pointing at them, a test filter plugin's description, and the `SnapshotDelta` paragraph in `docs/architecture.md`. ## Not renamed `AuditTrailVerifier::mintCheckpoint()`, `ChainArchiver::purgeSegmentArchiveFile()` and `SegmentAttestations::explainMarkedSegment()` return `bool` and are commands reporting success, which is what core's own unprefixed `bool` methods are: `write()`, `delete()`, `rename()`, `insertLogEntry()`. `exists()` is a Form API machine-name callback and `onDependencyRemoval()` a core override; both shapes are fixed. `acquire()`, `wait()` and `lockMayBeAvailable()` implement `LockBackendInterface`. None of the renamed methods is on a public API: `AuditTrailFilterInterface` is implemented by this module's two filter plugins and the test scaffolding, everything else is internal, and the only callers are in this module and its tests. ## Follow-up The shape of what `getRecordingVerdict()` returns is #3620400, which is a return type and two call sites rather than a name. AI-Generated: Yes (Claude Code was used to help draft this issue summary; the core counts were measured against the Drupal 11.4 tree in the development docroot, and each new name was taken from reading the method's call sites.)