>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3619223. --> Reported by: [mably](https://www.drupal.org/user/3375160) Related to !30 >>> <p>Method names across the module are inconsistent enough to slow a reader down: bare nouns where a verb belongs (<code>bucketKey()</code>, <code>severityOptions()</code>), a dangling preposition that never says what for (<code>headIdFor()</code>), a render-helper suffix Drupal does not use (<code>lifecycleCell()</code>), and a lifecycle family whose four members cannot be told apart (<code>archive()</code>, <code>purge()</code>, <code>filePurge()</code>, <code>transientPurgeSegment()</code>).</p> <p>This renames roughly 160 methods so each one reads as a verb followed by what it acts on. Production and test code, every visibility including static and abstract. No behaviour changes.</p> <h3>The rule applied</h3> <p>Verb plus noun, with a verb that is pertinent, named so a Drupal developer can read the call site without opening the definition. Where a name already satisfied that, it was left alone whatever its verb: <code>mint</code>, <code>renew</code> and <code>replay</code> stay, because a core-frequency argument against them would only produce worse names.</p> <h3>What changed</h3> <ul> <li><strong>Bare accessors gained a verb.</strong> <code>bucketKey()</code> to <code>getBucketKey()</code>, <code>nextSecretId()</code> to <code>getNextSecretId()</code>, <code>severityOptions()</code> to <code>getSeverityOptions()</code>. The HMAC builders took <code>compute</code> rather than <code>get</code>, since they derive rather than retrieve.</li> <li><strong>Render helpers took <code>build</code>.</strong> <code>lifecycleCell()</code> to <code>buildLifecycleCell()</code>, <code>lineSpan()</code> to <code>buildLineSpan()</code>. Drupal has no <code>*Cell()</code> method anywhere and 152 <code>build*</code>.</li> <li><strong>The <code>*For()</code> readers say what they are for.</strong> <code>headIdFor()</code> to <code>getChainHeadId()</code>, <code>latestCheckpointFor()</code> to <code>getChainLatestCheckpoint()</code>.</li> <li><strong>The lifecycle family is legible.</strong> <code>archiveChainRange()</code>, <code>purgeLiveRows()</code>, <code>purgeArchiveFile()</code>, <code>purgeTransientContext()</code>: three purges, each saying what it purges.</li> <li><strong>The plugin interfaces agree with themselves.</strong> <code>label()</code> and <code>description()</code> are <code>getLabel()</code> and <code>getDescription()</code>. Neither is inherited, and a matched pair reads better than one bare and one prefixed.</li> <li><strong>Test helpers too.</strong> <code>archiver()</code> to <code>getArchiver()</code>, <code>liveRowHash()</code> to <code>getLiveRowHash()</code>, and the data providers to <code>provide*</code>.</li> </ul> <h3>What deliberately did not change</h3> <ul> <li><code>AuditTrailInterface::event()</code>. It is the consumer-facing API with call sites in five other projects; renaming it belongs in its own coordinated change.</li> <li>Names Drupal itself dictates: OOP hook implementations (<code>entityInsert()</code>, <code>userLogin()</code>), <code>{@inheritdoc}</code> overrides, the <code>#machine_name</code> <code>exists()</code> callback and the entity-builder callback.</li> <li><code>label()</code> on entities, which is core's own <code>EntityInterface::label()</code>.</li> </ul> <h3>Verification</h3> <p>PHPCS with Drupal and DrupalPractice: no errors. PHPStan at level 3: no errors. 430 tests pass locally against MySQL across every unit and kernel suite in the module and its five submodules.</p> <p>Drupal wires callbacks as strings, which a rename working on call shapes cannot see. Three sets were caught by the tests rather than by the rename: AJAX callbacks in form arrays, controller and title callbacks in <code>routing.yml</code>, and <code>#[DataProvider]</code> attributes. Every one of those targets is now checked to resolve against a real method, so the gap is closed rather than patched.</p> <p>AI-Generated: Yes (Claude Code was used to help draft this issue summary and to make the change on the merge request. I reviewed and ran the work myself before posting it.)</p>