Make string -> function link a bit less agressive (no class methods/properties)

Migrated issue

Reported by: jhodgdon

In #294218: Turn hook names in theme() and module_invoke() into links and #745204: Turn strings that are callback function names into function links we are turning various strings in code into links.

I think we need to change the order of this somewhat and adjust it.

Take a look at this screenshot for instance. 'name' shouldn't really be a link -- it is coming up because there is a class property or method called 'name', and I don't think we should really make 'name' into a link because of that -- only should be done for bare functions not part of classes.

And the module_invoke() link for 'install' is not actually linking to hook_install() [which would be appropriate here] but is instead linking to Updater::install -- two ways to fix this:
a) check for the module_invoke(..., 'string') pattern before the generic 'string' pattern
b) don't do class stuff (fix for the above).

So I think both (a) and (b) should be done before we release this code into the wild.

Assignee Loading
Time tracking Loading