>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3605725. --> Reported by: [joshua1234511](https://www.drupal.org/user/3362218) Related to !16 >>> <h3>Problem / Motivation</h3> <p>The Context Control Centre integration shipped in <a href="https://www.drupal.org/project/ai_empathy/issues/3583739">#3583739</a> had to work around two limitations in ai_context that have since been fixed upstream:</p> <ol> <li><strong>No public form-building API</strong> &mdash; <code>ai_empathy_ccc</code> reimplemented the scope subscription build/extract/summary logic and depended directly on the internal <code>plugin.manager.ai_context_scope</code>. Fixed upstream by <a href="https://git.drupalcode.org/project/ai_context/-/work_items/3586287">ai_context #3586287</a>, which adds the public <code>ai_context.scope_subscription_form</code> service (<code>AiContextScopeSubscriptionFormBuilderInterface</code>).</li> <li><strong><code>hook_ai_context_scope_values_alter()</code> ignored in forms</strong> &mdash; our <code>empathy_evaluation</code> use case (registered via that hook) wasn't selectable in the scope widgets, so we carry <code>_ai_empathy_ccc_apply_altered_scope_options()</code> to rewrite each widget's <code>#options</code> from <code>getAllScopeValues()</code>. Fixed upstream by <a href="https://git.drupalcode.org/project/ai_context/-/work_items/3586246">ai_context #3586246</a>, which makes the alter hook authoritative in <code>buildValueForm()</code> / <code>getValues()</code>.</li> </ol> <p>Now that both fixes exist upstream, we can delete our workarounds and depend on the supported public API instead.</p> <h3>Blocked on</h3> <ul> <li><a href="https://git.drupalcode.org/project/ai_context/-/work_items/3586287">ai_context #3586287</a></li> <li><a href="https://git.drupalcode.org/project/ai_context/-/work_items/3586246">ai_context #3586246</a></li> <li>A tagged ai_context release containing both.</li> </ul> <p><em>Do not start until a fixed version is out.</em></p> <h3>Proposed resolution</h3> <p>In <code>modules/ai_empathy_ccc/</code>:</p> <ul> <li>Replace the build loop in <code>_ai_empathy_ccc_scenario_scope_form()</code> with <code>ai_context.scope_subscription_form</code>::<code>buildWidgets()</code> (plus <code>hasSubscribableScopes()</code>).</li> <li>Replace the extract loop in <code>ai_empathy_ccc_scenario_form_builder()</code> with <code>extractValues()</code>.</li> <li>Remove <code>_ai_empathy_ccc_apply_altered_scope_options()</code> entirely, and the <code>ai_context_item</code> branch in <code>ai_empathy_ccc_form_alter()</code> that calls it &mdash; the altered <code>empathy_evaluation</code> value now renders natively.</li> <li>Drop the direct <code>\Drupal::service('plugin.manager.ai_context_scope')</code> usages (the internal manager) once the above are gone.</li> <li>Bump the ai_context constraint in <code>ai_empathy_ccc.info.yml</code> / <code>composer.json</code> to the release that contains both fixes.</li> </ul> <p><code>hook_ai_context_scope_values_alter()</code> (registering the <code>empathy_evaluation</code> use case) stays &mdash; that's still the supported extension point and is unaffected.</p> <h3>Acceptance criteria</h3> <ul> <li>[ ] <code>ai_empathy_ccc</code> no longer references <code>plugin.manager.ai_context_scope</code>.</li> <li>[ ] <code>_ai_empathy_ccc_apply_altered_scope_options()</code> is removed.</li> <li>[ ] Scenario add/edit form still renders scope subscriptions and persists them identically (incl. the <code>empathy_evaluation</code> use case being selectable).</li> <li>[ ] Existing CCC tests pass; add/adjust coverage for the form via the new API.</li> <li>[ ] ai_context version constraint bumped to the fixed release.</li> </ul> <h3>Verification note</h3> <p>Verified locally with both upstream patches applied: the altered use case renders and saves from the scenario form without the workaround, so the local helper can be removed cleanly. See discussion on<br> <a href="https://www.drupal.org/project/ai_empathy/issues/3583739">#3583739</a>, <a href="https://git.drupalcode.org/project/ai_context/-/work_items/3586287">ai_context #3586287</a> and <a href="https://git.drupalcode.org/project/ai_context/-/work_items/3586246">ai_context #3586246</a>.</p>