## Summary Upgrading from `1.0.0-beta2` to current `1.0.x` can fail during a single `drush updb` run in two places: 1. **`ai_context_update_10006()`** — entity saves while the database still has the bundled NOT NULL `type` column, but the code already defines a bundleless `ai_context_item`. Saves write `type` as NULL and hit an integrity constraint violation. 2. **`ai_context_update_10011()`** — after update `10008` removes the bundle, stale Content Moderation field definitions remain in memory in the same process. Later entity saves fail on `moderation_state` (or related presave errors). A second `drush updb` often succeeds for this case. Both failures occur on supported Drupal 10 and Drupal 11. Which one appears first depends on site data (for example, whether `10006` must migrate legacy use-case scope values and therefore call `$item->save()`). Related to #3586338, but not caused by its Drupal 10 compatibility changes. Also related to, but distinct from, #3586290 (post-update missing view display YAML). Fix in progress: [!229](https://git.drupalcode.org/project/ai_context/-/merge_requests/229). ## Steps to reproduce 1. Install AI Context `1.0.0-beta2`. 2. Create one or more moderated context items. 3. Optionally assign legacy use-case scope values that `10006` migrates (for example `writing_words` or `working_in_canvas`), so `10006` performs entity saves. 4. Update the code to the current `1.0.x` branch (or MR !229). 5. Run `drush updb`. ## Expected result All database updates complete successfully in one `drush updb` run. ## Actual result Depending on data, either: **A. Update `10006` fails** with an error similar to: `IntegrityConstraintViolationException: Column 'type' cannot be null` `UPDATE "ai_context_item" SET ... "type"=:db_update_placeholder_1 ...` `Update failed: ai_context_update_10006` **B. Updates reach `10011` and fail** with errors similar to: `Attempt to read property "value" on null in EntityOperations.php` `InvalidArgumentException: Field moderation_state is unknown in ContentEntityBase::getTranslatedField()` For failure B, running `drush updb` again completes successfully. ## Technical analysis ### Failure A (`10006`) Current code defines `ai_context_item` as bundleless (no `type` entity key). A beta2 database still has a NOT NULL `type` column until update `10008` removes it. Update `10006` migrates legacy use-case scope values and may call `$item->save()` before `10008` runs. SqlContentEntityStorage still writes the `type` column, but the loaded entity has no bundle value, so the UPDATE sets `type` to NULL and MySQL rejects it. ### Failure B (`10011` after `10008`) Update `10008` converts `ai_context_item` from a bundled entity type to a bundleless entity type and changes its stored entity and field definitions. Update `10011` later loads and saves context items in the same PHP process. Content Moderation appears to retain stale definitions from before update `10008`, causing its presave processing to reference the removed or outdated `moderation_state` field definition. A fresh `drush updb` process rebuilds these in-memory definitions, which explains why the second run succeeds for this failure. ## Resolution [!229](https://git.drupalcode.org/project/ai_context/-/merge_requests/229) addresses both failures by: **For `10006` (type-column / entity-save failure):** - Migrates legacy use-case scope values via direct database updates to `ai_context_item_field_data` and `ai_context_item_field_revision`, avoiding entity API saves while the beta2 NOT NULL `type` column still exists and the code is already bundleless. - Iterates item IDs from the `ai_context_item` base table instead of `entityQuery`, which can fail while legacy bundled `type` field storage remains. - Reindexes the item and inheriting children after a direct scope update via `_ai_context_reindex_scope_after_direct_update()`. - Adds Kernel coverage in `testUpdate10006MigratesUseCaseWithoutNullingType` (beta2-style `type` column, legacy use-case values, then `10008`/`10011` in the same process). **For `10008` / `10011` (stale Content Moderation definitions):** - Adds shared cache-reset helpers: `_ai_context_reset_entity_type_and_bundle_caches()` and `_ai_context_reset_entity_definition_caches()`. - Uses the full entity-definition cache reset at the end of update `10008` instead of clearing only entity-type and bundle-info caches. - Removes the legacy bundled `type` field storage from last-installed definitions before calling `updateEntityType()` in update `10008`. - Resets entity-definition caches once at the start of update `10011`, before the batched entity saves. - Adds `AiContextUpdate10008To10011UpgradeTest` with moderated beta2 schema simulation, stale-definition recovery, moderation-state preservation, `inherit_parent_scope` backfill, scope indexes, workflow/bundle cleanup, and idempotent reruns. Manual beta2 upgrade verification on Drupal 10 and Drupal 11 is still recommended before RTBC. Related upgrade failures in #3586290 and Drupal 10 compatibility work in #3586338 remain separate. ## Acceptance criteria - A beta2 site upgrades successfully in one `drush updb` run. - Update `10006` does not fail with a NULL `type` integrity constraint when legacy use-case values require migration. - Updates `10008` and `10011` complete in the same process without stale Content Moderation field-definition errors. - Verified on supported Drupal 10 and Drupal 11 versions. - Existing context items remain loadable. - Content Moderation configuration remains valid. - `inherit_parent_scope` is correctly backfilled. - Scope indexes remain correct. - Automated upgrade-path regression tests cover both the `10006` `type` failure and the `10008`→`10011` stale-definition failure. - Re-running the updates is safe and idempotent. ## AI disclosure - [x] AI **Assisted Issue** The issue summary and technical analysis were drafted with AI assistance and reviewed by a human.