## Problem / Motivation A `text_replace` suggestion quotes one sentence (`original_value`) and proposes a replacement for that sentence (`suggested_value`). **Apply** ignores `original_value` and replaces the **entire field** with `suggested_value`. Every paragraph, heading and sentence the suggestion did not mention is deleted, and the text format is dropped as well. On the edit form the problem is invisible. The button turns into "Applied ✓", but the form still shows the old text. The node was already saved on the server behind the open form. The damage only shows up when you reload or view the node. Found on `1.0.0-alpha1`. ### Example The Description field (formatted long text, 613 characters) before Apply: > **Getting started** > > Thank you for your registration. We will process your request shortly, and you will receive a confirmation once this has been completed. > > To get started, please complete the setup process outlined below. After you have completed the setup, which usually takes a few minutes, you can begin adding content. > > **Signing in** > > Authenticate with your credentials to access the dashboard. Each team member should update their profile, and he or she can change it later. > > The recording of our onboarding session will be available afterwards if you missed the live session. The Tone & voice suggestion: - original_value: `Thank you for your registration. We will process your request shortly, and you will receive a confirmation once this has been completed.` The Tone & voice suggestion: - original_value: `Thank you for your registration. We will process your request shortly, and you will receive a confirmation once this has been completed.` - suggested_value: `Thanks for registering. We'll review your request shortly and send you a confirmation when it's ready.` The Description field after Apply, in full, with a `NULL` text format: > Thanks for registering. We'll review your request shortly and send you a confirmation when it's ready. I reproduced this with three different suggestions on the same node, and got the same result each time. ## Steps to reproduce 1. Set up a review rule with an agent-based criterion (for example, tone of voice) for a content type that has a formatted long-text field. 2. Create a node whose field has several paragraphs. 3. Open the node edit form. In the Content Review sidebar, run the criterion. 4. Click the criterion label to open the result dialog (`/ai-content-review/record/{id}/detail`), then click **Apply** on a `text_replace` suggestion. The suggestion doesn't need to be accepted first. 5. Note that the button reads "Applied ✓" and the edit form has not changed. 6. Reload the page, or view the node. **Expected:** only the quoted sentence changes. The rest of the field and its text format stay as they were. **Actual:** - The whole field now holds the suggested sentence, and its text format is `NULL`. - The new revision carries the *previous* revision's log message and timestamp, so the revision history doesn't show that Apply changed anything. - The open edit form is now stale (see the autosave error in the third screenshot below). The editor's next Save runs against content that was changed underneath them. ## Cause - `src/Plugin/Suggestion/TextReplaceSuggestion.php` line 65: `$entity->set($target, $suggestion->getSuggestedValue());` sets the whole field from a bare string. It never looks up `original_value`, and it replaces `{value, format}` with a value that has no format. - `src/Plugin/ReviewRecordType/InternalReviewRecordType.php` line 171 saves the entity immediately. It doesn't set a revision log message, a revision time or a new revision; here a revision was only created because content moderation forces one. - `js/review_run.js`, `applyAction()`, only relabels the button when the request succeeds. The edit-form widget is never updated. When the request fails, the button silently goes back to "Apply". ## Proposed resolution A mechanical Apply is only safe for an exact text replacement: find `original_value` in the target field and replace just that text. Anything else needs an editor to decide how the change should land. That includes text that has changed since the review, a sentence that occurs more than once, and a suggestion with no target. That includes text that has changed since the review, a sentence that occurs more than once, and a suggestion with no target. 1. **Remove the Apply button from the result dialog for now.** This matches the v1 scope in #3585831: no automated application to fields, with editors working from the improvement-plan checklist and copy button. #3585831 §10 already lists an assisted Apply as future scope. 2. **If Apply comes back**, whether as a single Apply or as Apply all (#3585845), it should: - replace only `original_value` inside the target field, and only when it occurs there exactly once; otherwise refuse and report the suggestion as stale; - write the `value` property and keep the existing `format`; - on the edit form, update the field widget rather than saving the entity behind the open form; - require the suggestion to be accepted first, and write a revision log message, time and user, for example "Applied AI Content Review suggestion #N". ## Related issues - #3585847: target validation. It also notes that setting a field from a bare string drops the format. - #3585845: Apply all. It builds on the same `apply()`, so as written it would batch this overwrite. Its `original_value` stale check is needed, but on its own it doesn't prevent the whole-field replacement. - #3585846: collisions. With whole-field replacement, any two suggestions on the same field collide. - #3585831: the v1 improvement-plan spec (no automated apply; Apply listed as future scope). - #3585827: my earlier report that the Apply button had disappeared. Having tested the r Review Content {width=900 height=340} Click link to open dialog box and apply suggestion {width=900 height=436} Suggestion applied and get error about autosave {width=900 height=427} Refresh page and all content replaced {width=900 height=342} /do:label ~"state::needsWork" /do:label ~"category::bug"