## Description Running the module's test suite reports **43 PHPUnit deprecations**, all of the same kind: > Metadata found in doc-comment for method `...`. Metadata in doc-comments is > deprecated and will no longer be supported in PHPUnit 12. Update your test > code to use attributes instead. They come from `@coversDefaultClass`, `@covers` and `@dataProvider` in the four unit test classes: | Class | Deprecations | |---|---| | `ReviewOrchestratorTest` | 21 | | `AgentBasedCriterionStepTest` | 11 | | `InputHasherTest` | 9 | | `GradeEvaluatorTest` | 2 | **These do not fail CI today.** Core's `phpunit.xml.dist` sets `failOnRisky`, `failOnWarning` and `failOnPhpunitWarning`, but not `failOnDeprecation` or `failOnPhpunitDeprecation`, so the run reports "OK, but there were issues" and exits 0. They become hard failures when the project moves to PHPUnit 12, which is the reason to do this now rather than under time pressure later. Found while reviewing #3585844. They predate it: the annotation counts are identical between that branch and `1.x` (`@covers` 40, `@dataProvider` 1, `@group` 4), so this is `1.x` housekeeping and was deliberately kept out of that issue rather than widening its diff. ### Note on `@group` `@group` is **not** currently reported as deprecated and is left alone here. It is present in all 20 test files, so if a later PHPUnit does start flagging it, converting it is a much wider change and belongs in its own issue rather than being smuggled into this one. ## Tasks * [ ] Replace class-level `@coversDefaultClass \Some\Class` and method-level `@covers ::method` with class-level `#[CoversMethod(SomeClass::class, 'method')]`, one per distinct covered method. Both `CoversClass` and `CoversMethod` are `TARGET_CLASS` attributes, so they aggregate on the class and cannot sit on the method the way the annotation did. * [ ] Replace `@dataProvider providerName` with `#[DataProvider('providerName')]`. Unlike the above, this one is `TARGET_METHOD` and stays on the method. * [ ] Add the `use` statements for the covered classes and for `PHPUnit\Framework\Attributes\CoversMethod` / `DataProvider`, keeping the `use` block alphabetical so phpcs stays clean. * [ ] Write short descriptions for the docblocks that held nothing but the removed annotations. 25 method docblocks and 4 class docblocks become empty or lose their summary, which `Drupal.Commenting.DocComment.Empty` and `.MissingShort` both reject. * [ ] Fix the `@group` tag alignment left over from the longer `@coversDefaultClass` line it used to sit under. ## Acceptance criteria * `phpunit` reports **0 PHPUnit deprecations** for this module. Verify with `--display-phpunit-deprecations`, since the default configuration counts them without listing them. * Test count and assertion count are unchanged, and no test changes behaviour. This is a metadata-only change. * `phpcs` at the CI configuration reports 0 errors and 0 warnings. Note the pipeline uses the `Drupal` standard only, since the GitLab template's default `phpcs.xml.dist` has DrupalPractice commented out, and its extension list is `engine,inc,info,install,module,php,profile,test,theme,yml`. * No doc-comment metadata is left in `tests/`: `grep -rE '@(covers|coversDefaultClass|dataProvider|depends|test)\b' tests/` returns nothing. ## Testing instructions *(added by implementor before review)* 1. Confirm the starting state on `1.x`: ```bash php vendor/bin/phpunit -c web/core/phpunit.xml.dist \ web/modules/contrib/ai_content_review/tests/src/Unit \ --display-phpunit-deprecations ``` Expected before: `PHPUnit Deprecations: 43`. 2. Apply the change and re-run the same command. Expected after: `PHPUnit Deprecations: 0`, with the same test and assertion counts. 3. Run the whole suite and confirm it is unchanged: ```bash php vendor/bin/phpunit -c web/core/phpunit.xml.dist \ web/modules/contrib/ai_content_review/tests ``` Expected: 195 tests, 2045 assertions, all passing. The 41 remaining deprecations are runtime ones from other contrib modules (`ai`, `webform`, `key`, `token`, `search_api` and others) and are out of scope here. 4. Coding standards: ```bash vendor/bin/phpcs web/modules/contrib/ai_content_review --standard=Drupal \ --extensions=engine,inc,info,install,module,php,profile,test,theme,yml ``` Expected: 0 errors, 0 warnings. ## Related issues *(optional)* ``` /relate #3585844 /label ~"Task" ``` <!-- If this issue description was significantly AI-generated (entire sections, not autocomplete), please note it in a comment below. See https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquette/policy-on-the-use-of-ai-when-contributing-to-drupal -->