PHPStan fails on the Drupal 10 job for `1.5.x`. Most of the errors trace back to a single root cause in the new ChatMemory plugin type, plus two unrelated stragglers. ## Summary `Drupal\ai\Base\ChatMemoryPluginBase` (added in `fd0c9a88`, [#3586539](https://www.drupal.org/project/ai/issues/3586539)) extends `Drupal\Core\Plugin\ConfigurablePluginBase`. That class does **not** exist in Drupal 10. Verified against core branches: | Core branch | `Drupal\Core\Plugin\ConfigurablePluginBase` | `Drupal\Core\Plugin\ConfigurableTrait` | |---|---|---| | `10.5.x` | absent | absent | | `11.0.x` / `11.1.x` / `11.2.x` | absent | absent | | `11.3.x` / `11.4.x` | present | present | `ai.info.yml` declares `core_version_requirement: ^10.5 || ^11.2`, so this breaks **both** the lowest supported Drupal 10 and the lowest supported Drupal 11 (11.2). Drupal 10 is only where CI happens to notice it first. Note that `Drupal\Component\Plugin\ConfigurableTrait` is also absent from 10.5 — the usual fallback is not available either. The base class has to implement `ConfigurableInterface` by hand. ## PHPStan output ``` ------ ------------------------------------------------------------------------------- Line modules/ai_assistant_api/src/Plugin/ChatMemory/PrivateTempStoreChatMemory.php ------ ------------------------------------------------------------------------------- 16 Non-abstract class Drupal\ai_assistant_api\Plugin\ChatMemory\PrivateTempStoreChatMemory contains abstract method getConfiguration() from interface Drupal\Component\Plugin\ConfigurableInterface. 16 Non-abstract class Drupal\ai_assistant_api\Plugin\ChatMemory\PrivateTempStoreChatMemory contains abstract method setConfiguration() from interface Drupal\Component\Plugin\ConfigurableInterface. ------ ------------------------------------------------------------------------------- ------ ----------------------------------------------------------------------------------- Line modules/ai_assistant_api/src/Plugin/ChatMemory/PrivateTempStorePoolChatMemory.php ------ ----------------------------------------------------------------------------------- 19 Non-abstract class Drupal\ai_assistant_api\Plugin\ChatMemory\PrivateTempStorePoolChatMemory contains abstract method getConfiguration() from interface Drupal\Component\Plugin\ConfigurableInterface. 19 Non-abstract class Drupal\ai_assistant_api\Plugin\ChatMemory\PrivateTempStorePoolChatMemory contains abstract method setConfiguration() from interface Drupal\Component\Plugin\ConfigurableInterface. ------ ----------------------------------------------------------------------------------- ------ ---------------------------------------------------------------------------- Line modules/ai_assistant_api/src/Plugin/ChatMemory/TempStoreChatMemoryBase.php ------ ---------------------------------------------------------------------------- 82 Call to an undefined static method Drupal\ai\Base\ChatMemoryPluginBase::__construct(). ------ ---------------------------------------------------------------------------- ------ -------------------------------------------------------------------- Line modules/ai_assistant_api/tests/src/Unit/AgentRunnerTest.php ------ -------------------------------------------------------------------- 19 Attribute class PHPUnit\Framework\Attributes\CoversMethod does not exist. ------ -------------------------------------------------------------------- ------ --------------------------------------------------------------- Line scripts/generate-provider-matrix.php ------ --------------------------------------------------------------- 856 Function http_request invoked with 1 parameter, 2-5 required. ------ --------------------------------------------------------------- ------ --------------------------------------------------------------------- Line src/Base/ChatMemoryPluginBase.php ------ --------------------------------------------------------------------- 17 Class Drupal\ai\Base\ChatMemoryPluginBase extends unknown class Drupal\Core\Plugin\ConfigurablePluginBase. ------ --------------------------------------------------------------------- ------ --------------------------------------------------------------------- Line tests/modules/ai_test/src/Plugin/ChatMemory/StateChatMemory.php ------ --------------------------------------------------------------------- 16 Non-abstract class Drupal\ai_test\Plugin\ChatMemory\StateChatMemory contains abstract method defaultConfiguration() from interface Drupal\Component\Plugin\ConfigurableInterface. 16 Non-abstract class Drupal\ai_test\Plugin\ChatMemory\StateChatMemory contains abstract method getConfiguration() from interface Drupal\Component\Plugin\ConfigurableInterface. 16 Non-abstract class Drupal\ai_test\Plugin\ChatMemory\StateChatMemory contains abstract method setConfiguration() from interface Drupal\Component\Plugin\ConfigurableInterface. 37 Call to an undefined static method Drupal\ai\Base\ChatMemoryPluginBase::__construct(). ``` ## Breakdown ### 1. Root cause — unresolvable parent class (5 of the 7 reported files) `src/Base/ChatMemoryPluginBase.php:17` is the actual defect. Everything below cascades from PHPStan being unable to resolve the parent: - `PrivateTempStoreChatMemory:16`, `PrivateTempStorePoolChatMemory:19`, `StateChatMemory:16` — the `ConfigurableInterface` methods PHPStan cannot see inherited (`defaultConfiguration()`, `getConfiguration()`, `setConfiguration()`) are reported as unimplemented abstract methods. - `TempStoreChatMemoryBase:82` and `StateChatMemory:37` — `parent::__construct(...)` cannot be resolved, so PHPStan reports it as an undefined static method call. This is not merely a static-analysis artifact. On Drupal 10.5 and 11.2 the class genuinely does not exist, so any of these plugins would fatal at runtime. **Suggested fix:** make `ChatMemoryPluginBase` extend `Drupal\Core\Plugin\PluginBase` and implement `Drupal\Component\Plugin\ConfigurableInterface` directly — `defaultConfiguration()`, `getConfiguration()`, `setConfiguration()`, and a constructor that calls `setConfiguration($configuration)`. That is portable across 10.5 through 11.4. Alternatives, if the team prefers: raise `core_version_requirement` to `^11.3` (drops Drupal 10 and 11.2 support entirely — a much bigger decision), or ship a compatibility shim. ### 2. `AgentRunnerTest.php:19` — PHPUnit attribute not available on Drupal 10 `#[CoversMethod]` was introduced in PHPUnit 11.2. Core requires: - `10.5.x` → `phpunit/phpunit: ^9.6.13` - `11.2.x` → `phpunit/phpunit: ^10.5.19 || ^11.5.3` So the attribute is unavailable on Drupal 10 (PHPUnit 9.6) and only conditionally available on Drupal 11.2. The file already carries a `@coversDefaultClass` annotation, so the simplest fix is to drop the `#[CoversMethod]` attribute and its `use` statement, or replace it with the annotation form, until the minimum PHPUnit version supports it. ### 3. `scripts/generate-provider-matrix.php:856` — name collision with pecl_http The script defines its own `function http_request(string $url, array $headers = []): array` and calls it with 1 argument from `drupal_org_get()`. PHPStan resolves the name against its bundled stub for the pecl_http extension function `http_request(int $method, string $url, ...)`, which takes 2-5 parameters, and flags the call. The code itself is correct; the function name is the problem. Renaming it to something namespaced-by-convention (for example `ai_matrix_http_request()`) removes the collision. This one is not Drupal-10-specific and could be split into its own issue if preferred. ## Steps to reproduce 1. Check out `1.5.x`. 2. Run the PHPStan job against Drupal 10.5. ## Expected result PHPStan passes on all supported core versions declared in `ai.info.yml`. ## Actual result 11 errors across 7 files, as above. ## Environment - Module version: `1.5.x-dev` - Affected core versions: 10.5 and 11.2 (both within the declared `^10.5 || ^11.2` range) - Unaffected: 11.3+ Related: [#3586539](https://www.drupal.org/project/ai/issues/3586539) added the ChatMemory plugin type. <!-- This issue description was significantly AI-generated. See https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquette/policy-on-the-use-of-ai-when-contributing-to-drupal -->