Move extraAdvancedFormFields to buildAdvancedConfigurationForm and rename the base classes
>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3563855. --> Reported by: [marcus_johansson](https://www.drupal.org/user/385947) Related to !1297 >>> <p>[Tracker]<br> <strong>Update Summary: </strong>[One-line status update for stakeholders]<br> <strong>Short Description: </strong>[One-line issue summary for stakeholders]<br> <strong>Check-in Date: </strong>MM/DD/YYYY<br> <em>Metadata is used by the <a href="https://www.drupalstarforge.ai/" title="AI Tracker">AI Tracker.</a> Docs and additional fields <a href="https://www.drupalstarforge.ai/ai-dashboard/docs" title="AI Issue Tracker Documentation">here</a>.</em><br> [/Tracker]</p> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>We have refactored so that buildAdvancedConfigurationForm should be the way forward, and not extraAdvancedFormFields. Currently we allow both, because we had the idea of making it BC.</p> <p>We should move out these from the two file RuleBase.php and ExternalBase.php. This means that the different plugins will have to start inherting in the parents setup in the buildAdvancedConfigurationForm.</p> <p>We also should refactor the names of those two base classes - basically RuleBase.php is ExternalBase.php but with AI added on top. So instead we should call RuleBase.php -&gt; AiAutomatorTypeBase.php and ExternalBase.php AutomatorTypeBase.php and make AiAutomatorTypeBase inherit AutomatorTypeBase.</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <ol> <li>Wait until <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-7"><a href="https://www.drupal.org/project/ai/issues/3563394" title="Status: Closed (fixed)">#3563394: Fix PHPStan issues on AI Automators</a></span> is merged.</li> <li>Refactor according to description.</li> </ol> > Related issue: [Issue #3563394](https://www.drupal.org/node/3563394)
issue