From b9e5b7374fb10446c7c33adc3517187c60e8c5ad Mon Sep 17 00:00:00 2001
From: tonytheferg <47358-TonyTheFerg@users.noreply.drupalcode.org>
Date: Fri, 21 Feb 2025 16:29:48 +0000
Subject: [PATCH] Issue #3507579 by tonytheferg, dydave, berdir: Fixed Fatal
error 'Controller for URI /en/admin/flush is not callable' by reverting
change introduced in #3486841 with commit f6acda66.
---
.../admin_toolbar_tools.links.menu.yml | 7 -----
.../admin_toolbar_tools.routing.yml | 9 ------
.../src/Controller/ToolbarController.php | 31 ++-----------------
3 files changed, 2 insertions(+), 45 deletions(-)
diff --git a/admin_toolbar_tools/admin_toolbar_tools.links.menu.yml b/admin_toolbar_tools/admin_toolbar_tools.links.menu.yml
index f42e394..7b006ba 100644
--- a/admin_toolbar_tools/admin_toolbar_tools.links.menu.yml
+++ b/admin_toolbar_tools/admin_toolbar_tools.links.menu.yml
@@ -90,10 +90,3 @@ admin_toolbar_tools.settings:
description: 'Configure the Admin Toolbar Tools module.'
route_name: admin_toolbar_tools.settings
parent: system.admin_config_ui
-
-system.run_reindex_site:
- title: 'Re-index Site'
- route_name: admin_toolbar.run.reindex.site
- menu_name: admin
- parent: admin_toolbar_tools.help
- weight: -9
diff --git a/admin_toolbar_tools/admin_toolbar_tools.routing.yml b/admin_toolbar_tools/admin_toolbar_tools.routing.yml
index ca9d57d..e5a0bfd 100644
--- a/admin_toolbar_tools/admin_toolbar_tools.routing.yml
+++ b/admin_toolbar_tools/admin_toolbar_tools.routing.yml
@@ -95,12 +95,3 @@ admin_toolbar_tools.settings:
_title: 'Admin Toolbar Tools settings'
requirements:
_permission: 'administer site configuration'
-
-admin_toolbar.run.reindex.site:
- path: '/reindex-site'
- defaults:
- _controller: '\Drupal\admin_toolbar_tools\Controller\ToolbarController::runReindexSite'
- _title: 'Re-index Site'
- requirements:
- _permission: 'administer site configuration'
- _csrf_token: 'TRUE'
diff --git a/admin_toolbar_tools/src/Controller/ToolbarController.php b/admin_toolbar_tools/src/Controller/ToolbarController.php
index fcd3ac3..169a719 100644
--- a/admin_toolbar_tools/src/Controller/ToolbarController.php
+++ b/admin_toolbar_tools/src/Controller/ToolbarController.php
@@ -13,7 +13,6 @@ use Drupal\Core\Menu\MenuLinkManagerInterface;
use Drupal\Core\Plugin\CachedDiscoveryClearerInterface;
use Drupal\Core\Template\TwigEnvironment;
use Drupal\Core\Theme\Registry;
-use Drupal\search\SearchPageRepositoryInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\RequestStack;
@@ -109,13 +108,6 @@ class ToolbarController extends ControllerBase {
*/
protected $themeRegistry;
- /**
- * The search page repository service.
- *
- * @var \Drupal\search\SearchPageRepositoryInterface
- */
- protected SearchPageRepositoryInterface $searchPageRepository;
-
/**
* Constructs a ToolbarController object.
*
@@ -143,8 +135,6 @@ class ToolbarController extends ControllerBase {
* A TwigEnvironment instance.
* @param \Drupal\Core\Theme\Registry $theme_registry
* The theme.registry service.
- * @param \Drupal\search\SearchPageRepositoryInterface $search_page_repository
- * The search page repository service.
*/
public function __construct(
CronInterface $cron,
@@ -158,9 +148,8 @@ class ToolbarController extends ControllerBase {
CachedDiscoveryClearerInterface $plugin_cache_clearer,
CacheBackendInterface $cache_menu,
TwigEnvironment $twig,
- Registry $theme_registry,
// phpcs:ignore Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma
- SearchPageRepositoryInterface $search_page_repository
+ Registry $theme_registry
) {
$this->cron = $cron;
$this->menuLinkManager = $menuLinkManager;
@@ -174,7 +163,6 @@ class ToolbarController extends ControllerBase {
$this->cacheMenu = $cache_menu;
$this->twig = $twig;
$this->themeRegistry = $theme_registry;
- $this->searchPageRepository = $search_page_repository;
}
/**
@@ -193,8 +181,7 @@ class ToolbarController extends ControllerBase {
$container->get('plugin.cache_clearer'),
$container->get('cache.menu'),
$container->get('twig'),
- $container->get('theme.registry'),
- $container->get('search.search_page_repository')
+ $container->get('theme.registry')
);
}
@@ -306,18 +293,4 @@ class ToolbarController extends ControllerBase {
return new RedirectResponse($this->reloadPage());
}
- /**
- * Reindexes all active search pages.
- */
- public function runReindexSite() {
- // Ask each active search page to mark itself for re-index.
- foreach ($this->searchPageRepository->getIndexableSearchPages() as $entity) {
- $entity->getPlugin()->markForReindex();
- }
- // Run the cron to process the reindexing.
- $this->cron->run();
- $this->messenger()->addMessage($this->t('All search indexes have been rebuilt.'));
- return new RedirectResponse($this->reloadPage());
- }
-
}
--
GitLab