>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3310754. --> Reported by: [vitorbs](https://www.drupal.org/user/3719802) >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>Used the PHPStan tool on level 0 and found 4 errors, need to fix them.</p> <pre>------ ----------------------------------------------------------------------------------- <br>&nbsp; Line&nbsp;&nbsp; src/Controller/AdminFeedbackController.php&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ ----------------------------------------------------------------------------------- <br>&nbsp; 55&nbsp;&nbsp;&nbsp;&nbsp; Unsafe usage of new static().&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static&nbsp; <br> ------ ----------------------------------------------------------------------------------- <br><br> ------ ----------------------------------------------------------------------------------- <br>&nbsp; Line&nbsp;&nbsp; src/Form/AdminFeedbackAjaxForm.php&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ ----------------------------------------------------------------------------------- <br>&nbsp; 54&nbsp;&nbsp;&nbsp;&nbsp; Unsafe usage of new static().&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static&nbsp; <br> ------ ----------------------------------------------------------------------------------- <br><br> ------ ------------------------------------------------------------------------------ <br>&nbsp; Line&nbsp;&nbsp; src/Form/AdminFeedbackDeleteForm.php&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ ------------------------------------------------------------------------------ <br>&nbsp; 85&nbsp;&nbsp;&nbsp;&nbsp; \Drupal calls should be avoided in classes, use dependency injection instead&nbsp; <br> ------ ------------------------------------------------------------------------------ <br><br> ------ ----------------------------------------------------------------------------------- <br>&nbsp; Line&nbsp;&nbsp; src/Plugin/Block/AdminFeedbackBlock.php&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ ----------------------------------------------------------------------------------- <br>&nbsp; 51&nbsp;&nbsp;&nbsp;&nbsp; Unsafe usage of new static().&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static&nbsp; <br> ------ ----------------------------------------------------------------------------------- </pre><h4 id="summary-steps-reproduce">Steps to reproduce</h4> <p>Use the command <code>lando phpstan analyse web/modules/contrib/admin_feedback/</code></p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Fix manually.</p> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <h3 id="summary-ui-changes">User interface changes</h3> <h3 id="summary-api-changes">API changes</h3> <h3 id="summary-data-model-changes">Data model changes</h3>