>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3624193. --> Reported by: [rohan-sinha](https://www.drupal.org/user/3707347) Related to !358 >>> <p>Problem/Motivation</p> <p>Embed mode ignores the focal point when the requested crop box is at least as large as<br> the source: getFocalPointCropParameters() returns an empty array, so the widen.net URL<br> carries no crop parameters at all instead of letterboxing the way Drupal's own image<br> pipeline does. Separately, a focal point set in Embed mode is not carried onto the<br> Download-and-sync file crop, and one set with the native image widget in<br> Download-and-sync mode is not carried onto the embed styles, so switching a media type's<br> render mode loses it.</p> <p>Steps to reproduce</p> <p>1. Create an image style with a focal_point_crop effect, e.g. width 3000 height 2000, and<br> attach it to a media type using the Acquia DAM embed code formatter. Use an asset larger<br> than 2048px, e.g. 4000x3000, and set a focal point on the media item.<br> 2. Render the media item and inspect the generated widen.net URL. Source dimensions cap to<br> 2048x1536, the 3000x2000 box caps to 2048x2000, so 2000 &gt;= 1536 and no parameters are<br> emitted.<br> 3. On a media type with download_assets enabled and the same 4000x3000 asset, set a focal<br> point with the native image widget, then switch the type to embed mode (or inspect the<br> embed crops directly).</p> <p>Expected: the URL is letterboxed into the requested box (crop=no, w, h, color), matching<br> Drupal's own rendering of the same style; and the focal point follows the asset across<br> render modes.<br> Actual: the URL contains no crop parameters and the uncropped original is displayed with<br> the focal point ignored; and the focal point exists only in the mode where it was set.</p> <p>Proposed resolution</p> <p>Return letterbox parameters instead of an empty array when the box reaches or exceeds the<br> source, after capping the requested box with getDimensionValue() (2048px) so the<br> comparison matches every other branch in mapImageEffects(). Split the focal point<br> conversions by coordinate space - ...Embed() methods for "acquia-dam://styles/..." rows<br> (2048px clamped) and ...File() methods for local file crops (true pixels) - and add<br> setFocalPointOnFile() / syncFocalPointFromFileToEmbedStyles() to carry a focal point<br> between them, guarded so a file crop the editor set is never overwritten. Also cast the<br> anchor offset to int and guard a zero source width (DivisionByZeroError).</p> <p>User interface changes</p> <p>None. The focal point element stays embed-only; no form elements are added or altered.</p> <p>API changes</p> <p>relativeToAbsolute() / absoluteToRelative() are renamed to relativeToAbsoluteEmbed() /<br> absoluteToRelativeEmbed(), the CropInterface parameter and internal save are dropped, and<br> persistence moves to applyAbsoluteToCrop(). New public methods: relativeToAbsoluteFile(),<br> absoluteToRelativeFile(), setFocalPointOnFile(),<br> syncFocalPointFromFileToEmbedStyles(), getDownloadedFile(), getImageDimensions(). No<br> deprecated wrappers are included; happy to add them for one release if preferred.</p> <p>Behaviour change to note: for a style whose crop box reaches or exceeds the capped source,<br> the embed URL changes from no crop parameters to crop=no&amp;w=...&amp;h=...&amp;color=000000.</p> <p>Data model changes</p> <p>None. No new entity types, fields, schema or configuration.</p>