>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3461739. --> Reported by: [hetal.solanki](https://www.drupal.org/user/3702323) Related to !8 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p><strong>Command</strong> : phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig web/modules/contrib/acb/</p> <pre>FILE: /var/www/html/d10/web/modules/contrib/acb/acb.module<br>--------------------------------------------------------------------------------------------------------------------------------------------<br>FOUND 2 ERRORS AND 31 WARNINGS AFFECTING 33 LINES<br>--------------------------------------------------------------------------------------------------------------------------------------------<br>&nbsp;&nbsp; 7 | WARNING | [x] '@TODO: code cleanup.' should match the format '@todo Fix problem X here.'<br>&nbsp;&nbsp; 8 | WARNING | [x] '@TODO: define services where appropriate.' should match the format '@todo Fix problem X here.'<br>&nbsp; 11 | WARNING | [x] Unused use statement<br>&nbsp; 63 | ERROR&nbsp;&nbsp; | [x] Data types in @var tags need to be fully namespaced<br> 107 | WARNING | [ ] Line exceeds 80 characters; contains 98 characters<br> 135 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters<br> 141 | WARNING | [x] '@TODO: check if still needed in D8.' should match the format '@todo Fix problem X here.'<br> 142 | ERROR&nbsp;&nbsp; | [ ] The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines<br> 156 | WARNING | [x] '@TODO: Find out if there is a reason to keep existing grants.' should match the format '@todo Fix problem X here.'<br> 166 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters<br> 169 | WARNING | [ ] Line exceeds 80 characters; contains 113 characters<br> 172 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters<br> 180 | WARNING | [ ] Line exceeds 80 characters; contains 123 characters<br> 181 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters<br> 182 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters<br> 183 | WARNING | [ ] Line exceeds 80 characters; contains 96 characters<br> 213 | WARNING | [ ] Line exceeds 80 characters; contains 103 characters<br> 218 | WARNING | [ ] Line exceeds 80 characters; contains 105 characters<br> 231 | WARNING | [ ] Line exceeds 80 characters; contains 109 characters<br> 258 | WARNING | [ ] Code after the RETURN statement on line 256 cannot be executed<br> 261 | WARNING | [ ] Code after the RETURN statement on line 260 cannot be executed<br> 268 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters<br> 270 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters<br> 275 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters<br> 291 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters<br> 301 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters<br> 303 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters<br> 304 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters<br> 305 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters<br> 309 | WARNING | [ ] Line exceeds 80 characters; contains 143 characters<br> 320 | WARNING | [ ] Line exceeds 80 characters; contains 110 characters<br> 323 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters<br> 332 | WARNING | [x] A comma should follow the last multiline array item. Found: 100<br>--------------------------------------------------------------------------------------------------------------------------------------------<br>PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br>--------------------------------------------------------------------------------------------------------------------------------------------<br><br><br>FILE: /var/www/html/d10/web/modules/contrib/acb/acb.info.yml<br>-------------------------------------------------------------------------------------------------------------<br>FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE<br>-------------------------------------------------------------------------------------------------------------<br> 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically<br> 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically<br> 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically<br>-------------------------------------------------------------------------------------------------------------<br><br><br>FILE: /var/www/html/d10/web/modules/contrib/acb/acb.install<br>---------------------------------------------------------------------------------------<br>FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES<br>---------------------------------------------------------------------------------------<br>&nbsp; 1 | ERROR&nbsp;&nbsp; | [x] The PHP open tag must be followed by exactly one blank line<br>&nbsp; 3 | ERROR&nbsp;&nbsp; | [x] Doc comment short description must be on the first line<br> 27 | WARNING | [x] '@TODO: test.' should match the format '@todo Fix problem X here.'<br>---------------------------------------------------------------------------------------<br>PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br>---------------------------------------------------------------------------------------<br><br>Time: 207ms; Memory: 12MB</pre><h4 id="summary-steps-reproduce">Steps to reproduce</h4> <p>Run PHPCS on Config Pages module.</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Fixed the coding standards.</p> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <p>Submit the patch either MR.</p>