From f1584efd0bcf2293a4fc68973a102e01b5ca638d Mon Sep 17 00:00:00 2001
From: Aaron Bauman <aaron@messageagency.com>
Date: Tue, 19 Feb 2019 13:48:07 -0500
Subject: [PATCH] Code sniff cleanups
---
.../salesforce_encrypt.install | 1 -
.../salesforce_encrypt.module | 2 --
.../src/Form/SalesforceAuthEncryptForm.php | 5 +++-
.../src/Form/SettingsForm.php | 5 ----
.../src/SalesforceEncrypt.php | 26 ++++++++++++++-----
.../src/SalesforceEncryptServiceProvider.php | 4 +--
.../SalesforceEncryptedAuthStorage.php | 11 +++++---
.../SalesforceEncryptedAuthTokenStorage.php | 4 ---
.../SalesforceJWTPlugin.php | 7 +++--
.../src/Controller/AutocompleteController.php | 2 ++
.../src/Entity/MappedObjectInterface.php | 2 +-
.../PropertiesExtended.php | 2 ++
.../Controller/SalesforceOAuthController.php | 2 +-
.../SalesforcePushQueueProcessor/Rest.php | 2 +-
.../SalesforcePushQueueProcessorRestTest.php | 2 --
.../salesforce_soap/src/Soap/SoapClient.php | 2 ++
salesforce.info.yml | 2 +-
salesforce.install | 9 +++----
src/Consumer/SalesforceCredentials.php | 7 +++--
src/Form/SalesforceAuthDeleteForm.php | 6 ++++-
src/Form/SalesforceAuthForm.php | 5 ++--
src/Form/SalesforceAuthRevokeForm.php | 6 ++++-
src/Form/SalesforceAuthSettings.php | 19 +++++++++-----
src/Rest/RestClient.php | 2 ++
src/Rest/RestResponse.php | 2 +-
src/SalesforceAuthProviderInterface.php | 4 +--
src/SelectQueryRaw.php | 4 +++
27 files changed, 91 insertions(+), 54 deletions(-)
diff --git a/modules/salesforce_encrypt/salesforce_encrypt.install b/modules/salesforce_encrypt/salesforce_encrypt.install
index d7f1eee1..f8a774eb 100644
--- a/modules/salesforce_encrypt/salesforce_encrypt.install
+++ b/modules/salesforce_encrypt/salesforce_encrypt.install
@@ -42,4 +42,3 @@ function salesforce_encrypt_requirements($phase) {
}
return $requirements;
}
-
diff --git a/modules/salesforce_encrypt/salesforce_encrypt.module b/modules/salesforce_encrypt/salesforce_encrypt.module
index 96658c1f..1f231412 100644
--- a/modules/salesforce_encrypt/salesforce_encrypt.module
+++ b/modules/salesforce_encrypt/salesforce_encrypt.module
@@ -65,8 +65,6 @@ function salesforce_encrypt_local_tasks_alter(&$local_tasks) {
'provider' => 'salesforce_encrypt',
'id' => 'entity.salesforce_auth.encryption',
]);
-
-
}
/**
diff --git a/modules/salesforce_encrypt/src/Form/SalesforceAuthEncryptForm.php b/modules/salesforce_encrypt/src/Form/SalesforceAuthEncryptForm.php
index b03babaa..e8b974d1 100644
--- a/modules/salesforce_encrypt/src/Form/SalesforceAuthEncryptForm.php
+++ b/modules/salesforce_encrypt/src/Form/SalesforceAuthEncryptForm.php
@@ -8,6 +8,9 @@ use Drupal\Core\Url;
use Drupal\salesforce\Entity\SalesforceAuthConfig;
use Drupal\salesforce_encrypt\SalesforceEncryptTrait;
+/**
+ * Auth encryption form.
+ */
class SalesforceAuthEncryptForm extends EntityConfirmFormBase {
/**
@@ -49,4 +52,4 @@ class SalesforceAuthEncryptForm extends EntityConfirmFormBase {
$form_state->setRedirectUrl($this->getCancelUrl());
}
-}
\ No newline at end of file
+}
diff --git a/modules/salesforce_encrypt/src/Form/SettingsForm.php b/modules/salesforce_encrypt/src/Form/SettingsForm.php
index c8cfbfb2..c80accb9 100644
--- a/modules/salesforce_encrypt/src/Form/SettingsForm.php
+++ b/modules/salesforce_encrypt/src/Form/SettingsForm.php
@@ -59,11 +59,6 @@ class SettingsForm extends FormBase {
/**
* SettingsForm constructor.
- *
- * @param \Drupal\Core\State\StateInterface $state
- * State service.
- * @param \Drupal\encrypt\EncryptionProfileManagerInterface $encryptionProfileManager
- * Encryption profile manager service.
*/
public function __construct(StateInterface $state, EncryptionProfileManagerInterface $encryptionProfileManager, SalesforceAuthTokenStorage $authTokenStorage, EntityTypeManagerInterface $etm, SalesforceEncrypt $salesforceEncrypt) {
$this->encryptionProfileManager = $encryptionProfileManager;
diff --git a/modules/salesforce_encrypt/src/SalesforceEncrypt.php b/modules/salesforce_encrypt/src/SalesforceEncrypt.php
index 242e8cb5..2743b803 100644
--- a/modules/salesforce_encrypt/src/SalesforceEncrypt.php
+++ b/modules/salesforce_encrypt/src/SalesforceEncrypt.php
@@ -10,10 +10,14 @@ use Drupal\key\Entity\KeyConfigOverride;
use Drupal\key\KeyConfigOverrides;
use Drupal\salesforce\Entity\SalesforceAuthConfig;
+/**
+ * Class SalesforceEncrypt.
+ */
class SalesforceEncrypt {
- final
-
+ /**
+ * SalesforceEncrypt constructor.
+ */
public function __construct(EncryptionProfileManagerInterface $encryptionProfileManager, KeyConfigOverrides $keyConfigOverrides, ConfigFactoryInterface $configFactory, StateInterface $state) {
$this->encryptionProfileManager = $encryptionProfileManager;
$this->keyConfigOverrides = $keyConfigOverrides;
@@ -24,7 +28,7 @@ class SalesforceEncrypt {
/**
* TRUE if the given authconfig is overridden with encrypted values.
*
- * @param \Drupal\salesforce\Entity\SalesforceAuthConfig $authConfig
+ * @param \Drupal\salesforce\Entity\SalesforceAuthConfig $auth
* The given auth config.
*
* @return bool
@@ -43,6 +47,15 @@ class SalesforceEncrypt {
$this->keyConfigOverrides->loadOverrides("$configName.provider_settings");
}
+ /**
+ * Encrypt auth config.
+ *
+ * @param \Drupal\salesforce\Entity\SalesforceAuthConfig $auth
+ * Auth config.
+ *
+ * @throws \Drupal\Core\Entity\EntityStorageException
+ * Exception.
+ */
public function encryptAuthConfig(SalesforceAuthConfig $auth) {
if ($this->isEncrypted($auth)) {
throw new \Exception('Auth is already encrypted');
@@ -85,7 +98,7 @@ class SalesforceEncrypt {
/**
* Get the assigned encryption profile, or NULL.
*
- * @return \Drupal\encrypt\EncryptionProfileInterface|NULL
+ * @return \Drupal\encrypt\EncryptionProfileInterface|null
* The assigned encryption profile, or NULL.
*/
public function getProfile() {
@@ -96,12 +109,11 @@ class SalesforceEncrypt {
/**
* Get the assigned encryption profile id, or NULL.
*
- * @return string|NULL
+ * @return string|null
* The assigned encryption profile id, or NULL.
*/
public function getProfileId() {
return $this->state->get('salesforce_encrypt.profile');
}
-
-}
\ No newline at end of file
+}
diff --git a/modules/salesforce_encrypt/src/SalesforceEncryptServiceProvider.php b/modules/salesforce_encrypt/src/SalesforceEncryptServiceProvider.php
index e75e85b0..0d2a9ac0 100644
--- a/modules/salesforce_encrypt/src/SalesforceEncryptServiceProvider.php
+++ b/modules/salesforce_encrypt/src/SalesforceEncryptServiceProvider.php
@@ -16,11 +16,11 @@ class SalesforceEncryptServiceProvider {
*/
public function alter(ContainerBuilder $container) {
// Add a normalizer service for file entities.
- $service_definition = new Definition('Drupal\salesforce_encrypt\Storage\SalesforceEncryptedAuthTokenStorage', array(
+ $service_definition = new Definition('Drupal\salesforce_encrypt\Storage\SalesforceEncryptedAuthTokenStorage', [
new Reference('state'),
new Reference('encryption'),
new Reference('encrypt.encryption_profile.manager'),
- ));
+ ]);
$container->setDefinition('salesforce.auth_token_storage', $service_definition);
}
diff --git a/modules/salesforce_encrypt/src/Storage/SalesforceEncryptedAuthStorage.php b/modules/salesforce_encrypt/src/Storage/SalesforceEncryptedAuthStorage.php
index e712e436..5b50d9c0 100644
--- a/modules/salesforce_encrypt/src/Storage/SalesforceEncryptedAuthStorage.php
+++ b/modules/salesforce_encrypt/src/Storage/SalesforceEncryptedAuthStorage.php
@@ -6,6 +6,9 @@ use Drupal\Core\Config\Entity\ConfigEntityStorage;
use Drupal\Core\Entity\EntityInterface;
use Drupal\Core\Entity\EntityMalformedException;
+/**
+ * Class SalesforceEncryptedAuthStorage.
+ */
class SalesforceEncryptedAuthStorage extends ConfigEntityStorage {
/**
@@ -19,11 +22,13 @@ class SalesforceEncryptedAuthStorage extends ConfigEntityStorage {
return parent::save($entity);
}
+ /**
+ * {@inheritdoc}
+ */
protected function doLoadMultiple(array $ids = NULL) {
$entities = parent::doLoadMultiple($ids);
- // Decrypt the sensitive values and return
+ // Decrypt the sensitive values and return.
return $entities;
}
-
-}
\ No newline at end of file
+}
diff --git a/modules/salesforce_encrypt/src/Storage/SalesforceEncryptedAuthTokenStorage.php b/modules/salesforce_encrypt/src/Storage/SalesforceEncryptedAuthTokenStorage.php
index 7b4bef26..3065e34c 100644
--- a/modules/salesforce_encrypt/src/Storage/SalesforceEncryptedAuthTokenStorage.php
+++ b/modules/salesforce_encrypt/src/Storage/SalesforceEncryptedAuthTokenStorage.php
@@ -69,8 +69,4 @@ class SalesforceEncryptedAuthTokenStorage extends SalesforceAuthTokenStorage {
return $identity;
}
- public function storeAuthorizationState($service, $state) {
- return parent::storeAuthorizationState($service, $state); // TODO: Change the autogenerated stub
- }
-
}
diff --git a/modules/salesforce_jwt/src/Plugin/SalesforceAuthProvider/SalesforceJWTPlugin.php b/modules/salesforce_jwt/src/Plugin/SalesforceAuthProvider/SalesforceJWTPlugin.php
index 16b9d067..c2a6f6d2 100644
--- a/modules/salesforce_jwt/src/Plugin/SalesforceAuthProvider/SalesforceJWTPlugin.php
+++ b/modules/salesforce_jwt/src/Plugin/SalesforceAuthProvider/SalesforceJWTPlugin.php
@@ -59,6 +59,8 @@ class SalesforceJWTPlugin extends SalesforceAuthProviderPluginBase {
* Http client wrapper.
* @param \Drupal\salesforce\Storage\SalesforceAuthTokenStorageInterface $storage
* Token storage.
+ * @param \Drupal\key\KeyRepositoryInterface $keyRepository
+ * Key repository.
*
* @throws \OAuth\OAuth2\Service\Exception\InvalidScopeException
* On error.
@@ -164,10 +166,11 @@ class SalesforceJWTPlugin extends SalesforceAuthProviderPluginBase {
*
* @param string $assertion
* The JWT assertion.
- * @param string $loginUrl
+ * @param string $state
* Not used.
*
- * @return TokenInterface $token
+ * @return \OAuth\Common\Token\TokenInterface
+ * Access Token.
*
* @throws \OAuth\Common\Http\Exception\TokenResponseException
*/
diff --git a/modules/salesforce_mapping/src/Controller/AutocompleteController.php b/modules/salesforce_mapping/src/Controller/AutocompleteController.php
index 3437e237..870f2441 100644
--- a/modules/salesforce_mapping/src/Controller/AutocompleteController.php
+++ b/modules/salesforce_mapping/src/Controller/AutocompleteController.php
@@ -34,6 +34,8 @@ class AutocompleteController extends ControllerBase {
*
* @param \Drupal\Core\Entity\EntityFieldManagerInterface $field_manager
* Entity field manager.
+ * @param \Drupal\typed_data\DataFetcherInterface $dataFetcher
+ * Data fetcher.
*/
public function __construct(EntityFieldManagerInterface $field_manager, DataFetcherInterface $dataFetcher) {
$this->fieldManager = $field_manager;
diff --git a/modules/salesforce_mapping/src/Entity/MappedObjectInterface.php b/modules/salesforce_mapping/src/Entity/MappedObjectInterface.php
index f5ba65ef..44e35d35 100644
--- a/modules/salesforce_mapping/src/Entity/MappedObjectInterface.php
+++ b/modules/salesforce_mapping/src/Entity/MappedObjectInterface.php
@@ -67,7 +67,7 @@ interface MappedObjectInterface extends EntityChangedInterface, RevisionLogInter
*/
public function authMan();
- /**
+ /**
* Get a salesforce url for the linked record.
*
* @return string
diff --git a/modules/salesforce_mapping/src/Plugin/SalesforceMappingField/PropertiesExtended.php b/modules/salesforce_mapping/src/Plugin/SalesforceMappingField/PropertiesExtended.php
index 09516b3b..41387038 100644
--- a/modules/salesforce_mapping/src/Plugin/SalesforceMappingField/PropertiesExtended.php
+++ b/modules/salesforce_mapping/src/Plugin/SalesforceMappingField/PropertiesExtended.php
@@ -74,6 +74,8 @@ class PropertiesExtended extends SalesforceMappingFieldPluginBase {
* Event dispatcher service.
* @param \Drupal\Core\Extension\ModuleHandlerInterface $moduleHandler
* Module handler service.
+ * @param \Drupal\typed_data\DataFetcherInterface $dataFetcher
+ * Data fetcher.
*
* @throws \Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException
* @throws \Drupal\Component\Plugin\Exception\PluginNotFoundException
diff --git a/modules/salesforce_oauth/src/Controller/SalesforceOAuthController.php b/modules/salesforce_oauth/src/Controller/SalesforceOAuthController.php
index 7bc291cd..364d7e4a 100644
--- a/modules/salesforce_oauth/src/Controller/SalesforceOAuthController.php
+++ b/modules/salesforce_oauth/src/Controller/SalesforceOAuthController.php
@@ -14,7 +14,7 @@ use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
/**
- *
+ * SalesforceOAuthController.
*/
class SalesforceOAuthController extends ControllerBase {
diff --git a/modules/salesforce_push/src/Plugin/SalesforcePushQueueProcessor/Rest.php b/modules/salesforce_push/src/Plugin/SalesforcePushQueueProcessor/Rest.php
index 2da7a43f..91f256ae 100644
--- a/modules/salesforce_push/src/Plugin/SalesforcePushQueueProcessor/Rest.php
+++ b/modules/salesforce_push/src/Plugin/SalesforcePushQueueProcessor/Rest.php
@@ -84,7 +84,7 @@ class Rest extends PluginBase implements PushQueueProcessorInterface {
* ETM service.
* @param \Symfony\Component\EventDispatcher\EventDispatcherInterface $eventDispatcher
* Event dispatcher service.
- * @param \Drupal\salesforce\SalesforceAuthProviderPluginManager
+ * @param \Drupal\salesforce\SalesforceAuthProviderPluginManager $authMan
* Auth manager.
*
* @throws \Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException
diff --git a/modules/salesforce_push/tests/src/Unit/SalesforcePushQueueProcessorRestTest.php b/modules/salesforce_push/tests/src/Unit/SalesforcePushQueueProcessorRestTest.php
index 676a7003..c34adcd6 100644
--- a/modules/salesforce_push/tests/src/Unit/SalesforcePushQueueProcessorRestTest.php
+++ b/modules/salesforce_push/tests/src/Unit/SalesforcePushQueueProcessorRestTest.php
@@ -79,7 +79,6 @@ class SalesforcePushQueueProcessorRestTest extends UnitTestCase {
->method('getToken')
->willReturn($this->authToken);
-
$container = new ContainerBuilder();
$container->set('queue.salesforce_push', $this->queue);
$container->set('salesforce.client', $this->client);
@@ -144,7 +143,6 @@ class SalesforcePushQueueProcessorRestTest extends UnitTestCase {
$this->handler->process([(object) [1]]);
}
-
/**
* @covers ::processItem
*/
diff --git a/modules/salesforce_soap/src/Soap/SoapClient.php b/modules/salesforce_soap/src/Soap/SoapClient.php
index 31d955af..6389c896 100644
--- a/modules/salesforce_soap/src/Soap/SoapClient.php
+++ b/modules/salesforce_soap/src/Soap/SoapClient.php
@@ -44,6 +44,8 @@ class SoapClient extends SforcePartnerClient implements SoapClientInterface {
*
* @param \Drupal\salesforce\Rest\RestClientInterface $rest_api
* The Salesforce REST API client.
+ * @param \Drupal\salesforce\SalesforceAuthProviderPluginManager $authMan
+ * Auth manager.
* @param string $wsdl
* (Optional) Path to the WSDL that should be used. Defaults to using the
* partner WSDL from the developerforce/force.com-toolkit-for-php package.
diff --git a/salesforce.info.yml b/salesforce.info.yml
index 5efe50b7..3be778fa 100644
--- a/salesforce.info.yml
+++ b/salesforce.info.yml
@@ -5,4 +5,4 @@ package: Salesforce
core: 8.x
configure: salesforce.admin_config_salesforce
dependencies:
- typed_data:typed_data
\ No newline at end of file
+ typed_data:typed_data
diff --git a/salesforce.install b/salesforce.install
index ce87a7b0..1efe47fd 100644
--- a/salesforce.install
+++ b/salesforce.install
@@ -267,9 +267,6 @@ function salesforce_update_8004() {
\Drupal::cache()->delete('salesforce:objects');
}
-/**
- * Convert legacy oauth credentials to new auth plugin config.
- */
/**
* Convert legacy oauth credentials to new auth plugin config.
*/
@@ -317,13 +314,15 @@ function salesforce_update_8006() {
}
}
+/**
+ * Enable salesforce_oauth module and purge legacy settings.
+ */
function salesforce_update_8401() {
// Enable salesforce_oauth module.
\Drupal::service('module_installer')->install(['salesforce_oauth']);
- // purge old stateful values.
- // clear old config.
throw new \Exception('foo');
+ // Purge old stateful values and config.
\Drupal::configFactory()->getEditable('salesforce.settings')
->clear('consumer_key')
->clear('consumer_secret')
diff --git a/src/Consumer/SalesforceCredentials.php b/src/Consumer/SalesforceCredentials.php
index d521eded..533a9871 100644
--- a/src/Consumer/SalesforceCredentials.php
+++ b/src/Consumer/SalesforceCredentials.php
@@ -4,6 +4,9 @@ namespace Drupal\salesforce\Consumer;
use OAuth\Common\Consumer\Credentials;
+/**
+ * Class SalesforceCredentials.
+ */
abstract class SalesforceCredentials extends Credentials implements SalesforceCredentialsInterface {
/**
@@ -20,7 +23,7 @@ abstract class SalesforceCredentials extends Credentials implements SalesforceCr
*/
protected $consumerKey;
-/**
+ /**
* {@inheritdoc}
*/
public function getConsumerKey() {
@@ -34,4 +37,4 @@ abstract class SalesforceCredentials extends Credentials implements SalesforceCr
return $this->loginUrl;
}
-}
\ No newline at end of file
+}
diff --git a/src/Form/SalesforceAuthDeleteForm.php b/src/Form/SalesforceAuthDeleteForm.php
index 048ba71d..90e71907 100644
--- a/src/Form/SalesforceAuthDeleteForm.php
+++ b/src/Form/SalesforceAuthDeleteForm.php
@@ -6,7 +6,11 @@ use Drupal\Core\Entity\EntityConfirmFormBase;
use Drupal\Core\Form\FormStateInterface;
use Drupal\Core\Url;
+/**
+ * Class SalesforceAuthDeleteForm.
+ */
class SalesforceAuthDeleteForm extends EntityConfirmFormBase {
+
/**
* {@inheritdoc}
*/
@@ -55,4 +59,4 @@ class SalesforceAuthDeleteForm extends EntityConfirmFormBase {
$form_state->setRedirectUrl($this->getCancelUrl());
}
-}
\ No newline at end of file
+}
diff --git a/src/Form/SalesforceAuthForm.php b/src/Form/SalesforceAuthForm.php
index 27db7a57..77fe127f 100644
--- a/src/Form/SalesforceAuthForm.php
+++ b/src/Form/SalesforceAuthForm.php
@@ -20,8 +20,6 @@ class SalesforceAuthForm extends EntityForm {
*/
protected $entity;
-
-
/**
* {@inheritdoc}
*/
@@ -129,6 +127,9 @@ class SalesforceAuthForm extends EntityForm {
}
}
+ /**
+ * {@inheritdoc}
+ */
public function save(array $form, FormStateInterface $form_state) {
parent::save($form, $form_state);
$this->entity->getPlugin()->save($form, $form_state);
diff --git a/src/Form/SalesforceAuthRevokeForm.php b/src/Form/SalesforceAuthRevokeForm.php
index 4463ba9a..d848e005 100644
--- a/src/Form/SalesforceAuthRevokeForm.php
+++ b/src/Form/SalesforceAuthRevokeForm.php
@@ -7,7 +7,11 @@ use Drupal\Core\Form\FormStateInterface;
use Drupal\Core\Url;
use Drupal\salesforce\Entity\SalesforceAuthConfig;
+/**
+ * Class SalesforceAuthRevokeForm.
+ */
class SalesforceAuthRevokeForm extends EntityConfirmFormBase {
+
/**
* {@inheritdoc}
*/
@@ -46,4 +50,4 @@ class SalesforceAuthRevokeForm extends EntityConfirmFormBase {
$form_state->setRedirectUrl($this->getCancelUrl());
}
-}
\ No newline at end of file
+}
diff --git a/src/Form/SalesforceAuthSettings.php b/src/Form/SalesforceAuthSettings.php
index aca5f81b..05c0ed34 100644
--- a/src/Form/SalesforceAuthSettings.php
+++ b/src/Form/SalesforceAuthSettings.php
@@ -12,6 +12,9 @@ use Drupal\salesforce\SalesforceAuthProviderPluginManager;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
+/**
+ * Class SalesforceAuthSettings.
+ */
class SalesforceAuthSettings extends ConfigFormBase {
protected $salesforceAuth;
@@ -21,7 +24,11 @@ class SalesforceAuthSettings extends ConfigFormBase {
* Constructs a \Drupal\system\ConfigFormBase object.
*
* @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory
- * The factory for configuration objects.
+ * Config.
+ * @param \Drupal\salesforce\SalesforceAuthProviderPluginManager $salesforceAuth
+ * Authman.
+ * @param \Symfony\Component\EventDispatcher\EventDispatcherInterface $eventDispatcher
+ * Events.
*/
public function __construct(ConfigFactoryInterface $config_factory, SalesforceAuthProviderPluginManager $salesforceAuth, EventDispatcherInterface $eventDispatcher) {
parent::__construct($config_factory);
@@ -40,7 +47,6 @@ class SalesforceAuthSettings extends ConfigFormBase {
);
}
-
/**
* {@inheritdoc}
*/
@@ -60,17 +66,16 @@ class SalesforceAuthSettings extends ConfigFormBase {
*/
public function buildForm(array $form, FormStateInterface $form_state) {
if (!$this->salesforceAuth->hasProviders()) {
- return ['#markup'=> 'No auth providers have been enabled. Please enable an auth provider and create an auth config before continuing.'];
+ return ['#markup' => 'No auth providers have been enabled. Please enable an auth provider and create an auth config before continuing.'];
}
$config = $this->config('salesforce.settings');
$form = parent::buildForm($form, $form_state);
$options = [];
- /** @var \Drupal\salesforce\Entity\SalesforceAuthConfig $provider **/
- foreach($this->salesforceAuth->getProviders() as $provider) {
+ foreach ($this->salesforceAuth->getProviders() as $provider) {
$options[$provider->id()] = $provider->label() . ' (' . $provider->getPlugin()->label() . ')';
}
if (empty($options)) {
- return ['#markup'=> 'No auth providers found. Please add an auth provider before continuing.'];
+ return ['#markup' => 'No auth providers found. Please add an auth provider before continuing.'];
}
$options = ['' => '- None -'] + $options;
$form['provider'] = [
@@ -95,4 +100,4 @@ class SalesforceAuthSettings extends ConfigFormBase {
$this->eventDispatcher->dispatch(SalesforceEvents::NOTICE, new SalesforceNoticeEvent(NULL, "Authorization provider changed to %provider.", ['%provider' => $form_state->getValue('provider')]));
}
-}
\ No newline at end of file
+}
diff --git a/src/Rest/RestClient.php b/src/Rest/RestClient.php
index a07f6d41..490cec04 100644
--- a/src/Rest/RestClient.php
+++ b/src/Rest/RestClient.php
@@ -126,6 +126,8 @@ class RestClient implements RestClientInterface {
* The JSON serializer service.
* @param \Drupal\Component\Datetime\TimeInterface $time
* The Time service.
+ * @param \Drupal\salesforce\SalesforceAuthProviderPluginManager $authManager
+ * Auth manager service.
*/
public function __construct(ClientInterface $http_client, ConfigFactoryInterface $config_factory, StateInterface $state, CacheBackendInterface $cache, Json $json, TimeInterface $time, SalesforceAuthProviderPluginManager $authManager) {
$this->configFactory = $config_factory;
diff --git a/src/Rest/RestResponse.php b/src/Rest/RestResponse.php
index a7d2f50b..da9af3c1 100644
--- a/src/Rest/RestResponse.php
+++ b/src/Rest/RestResponse.php
@@ -32,7 +32,7 @@ class RestResponse extends Response {
/**
* RestResponse constructor.
*
- * @param \GuzzleHttp\Psr7\Response $response
+ * @param \Psr\Http\Message\ResponseInterface $response
* A response.
*/
public function __construct(ResponseInterface $response) {
diff --git a/src/SalesforceAuthProviderInterface.php b/src/SalesforceAuthProviderInterface.php
index 8d8e45d2..2792566b 100644
--- a/src/SalesforceAuthProviderInterface.php
+++ b/src/SalesforceAuthProviderInterface.php
@@ -136,8 +136,8 @@ interface SalesforceAuthProviderInterface extends ServiceInterface, PluginFormIn
* @param string $api_type
* (optional) Which API for which to retrieve URL, defaults to "rest".
*
- * @return string.
- * The URL
+ * @return string
+ * The URL.
*/
public function getApiEndpoint($api_type = 'rest');
diff --git a/src/SelectQueryRaw.php b/src/SelectQueryRaw.php
index 1e536eff..e1732af4 100644
--- a/src/SelectQueryRaw.php
+++ b/src/SelectQueryRaw.php
@@ -2,6 +2,9 @@
namespace Drupal\salesforce;
+/**
+ * Class SelectQueryRaw to construct SOQL manually from a string.
+ */
class SelectQueryRaw implements SelectQueryInterface {
protected $query;
@@ -22,4 +25,5 @@ class SelectQueryRaw implements SelectQueryInterface {
public function __toString() {
return str_replace(' ', '+', $this->query);
}
+
}
--
GitLab