From 56d0ad9f00c575924fb721b5a8ff3550d72e4a36 Mon Sep 17 00:00:00 2001
From: Sascha Grossenbacher <saschagros@gmail.com>
Date: Sun, 9 Feb 2025 20:24:24 +0100
Subject: [PATCH] remove deprecation, add ids
---
core/modules/views/src/Plugin/ViewsHandlerManager.php | 5 -----
.../src/Hook/ViewsTestDataAlterHooks.php | 1 +
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/core/modules/views/src/Plugin/ViewsHandlerManager.php b/core/modules/views/src/Plugin/ViewsHandlerManager.php
index 3ea5ce764ae8..df9da78f09bc 100644
--- a/core/modules/views/src/Plugin/ViewsHandlerManager.php
+++ b/core/modules/views/src/Plugin/ViewsHandlerManager.php
@@ -130,8 +130,6 @@ public function getHandler(array $item, ?string $override_plugin_id = NULL): Vie
return $handler;
}
}
- // @todo If it is a deprecated ID, still allow it but trigger a
- // deprecation message.
elseif (isset($definition['deprecated_ids'][$item['plugin_id']])) {
@trigger_error($definition['deprecated_ids'][$item['plugin_id']], E_USER_DEPRECATED);
$handler = $this->createInstance($item['plugin_id'], $definition);
@@ -139,9 +137,6 @@ public function getHandler(array $item, ?string $override_plugin_id = NULL): Vie
return $handler;
}
}
- else {
- @trigger_error('Configuring a views plugin id that is not allowed is deprecated in drupal:11.2.0 and is removed from drupal:12.0.0. Update the configuration or ensure that it is added to the views data id, ids or deprecated_ids for this column and handler type. See https://www.drupal.org/node/3458099', E_USER_DEPRECATED);
- }
}
// Finally, fall back to the default configuration suggested
diff --git a/core/modules/views/tests/modules/views_test_data_alter/src/Hook/ViewsTestDataAlterHooks.php b/core/modules/views/tests/modules/views_test_data_alter/src/Hook/ViewsTestDataAlterHooks.php
index c62ef3f64125..d8e736d05526 100644
--- a/core/modules/views/tests/modules/views_test_data_alter/src/Hook/ViewsTestDataAlterHooks.php
+++ b/core/modules/views/tests/modules/views_test_data_alter/src/Hook/ViewsTestDataAlterHooks.php
@@ -18,6 +18,7 @@ public function viewsDataAlter(array &$data): void {
// respects the handler plugin ID specified in the
// configuration.
$data['node_field_data']['status']['filter']['id'] = 'numeric';
+ $data['node_field_data']['status']['filter']['ids'] = ['boolean'];
}
}
--
GitLab