From d088a7b0b17a3128a55f08256f609960bfec5222 Mon Sep 17 00:00:00 2001
From: Lauri Eskola <lauri.eskola@acquia.com>
Date: Fri, 27 Oct 2023 12:14:14 +0300
Subject: [PATCH] Issue #3395748 by KarimB, joachim: getSetting()'s
 documentation should specify what happens when a setting doesn't exist

---
 core/lib/Drupal/Core/Field/FieldStorageDefinitionInterface.php | 2 +-
 core/lib/Drupal/Core/TypedData/DataDefinitionInterface.php     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/lib/Drupal/Core/Field/FieldStorageDefinitionInterface.php b/core/lib/Drupal/Core/Field/FieldStorageDefinitionInterface.php
index d75eb2295b2f..ead716800865 100644
--- a/core/lib/Drupal/Core/Field/FieldStorageDefinitionInterface.php
+++ b/core/lib/Drupal/Core/Field/FieldStorageDefinitionInterface.php
@@ -74,7 +74,7 @@ public function getSettings();
    *   The setting name.
    *
    * @return mixed
-   *   The setting value.
+   *   The setting value or NULL if the setting name doesn't exist.
    */
   public function getSetting($setting_name);
 
diff --git a/core/lib/Drupal/Core/TypedData/DataDefinitionInterface.php b/core/lib/Drupal/Core/TypedData/DataDefinitionInterface.php
index e5614d3d462e..3b9c64f4337a 100644
--- a/core/lib/Drupal/Core/TypedData/DataDefinitionInterface.php
+++ b/core/lib/Drupal/Core/TypedData/DataDefinitionInterface.php
@@ -143,7 +143,7 @@ public function getSettings();
    *   The setting name.
    *
    * @return mixed
-   *   The setting value.
+   *   The setting value or NULL if the setting name doesn't exist.
    */
   public function getSetting($setting_name);
 
-- 
GitLab