From 8177e874f43f80f5a4ffe96f04e4c784f94e43dc Mon Sep 17 00:00:00 2001
From: quietone <quietone@2572884.no-reply.drupal.org>
Date: Tue, 28 Mar 2023 15:45:14 +1300
Subject: [PATCH] Issue #3347766 by Spokje, smustgrave: Address @todo-comments
linking to closed issue [#3219959]
---
.../tests/src/FunctionalJavascript/OffCanvasTestBase.php | 2 --
.../views/tests/src/Functional/UserBatchActionTest.php | 2 --
.../modules/views/tests/src/Kernel/Plugin/DisplayPageTest.php | 2 --
.../Core/Asset/ResolvedLibraryDefinitionsFilesMatchTest.php | 4 ----
4 files changed, 10 deletions(-)
diff --git a/core/modules/system/tests/src/FunctionalJavascript/OffCanvasTestBase.php b/core/modules/system/tests/src/FunctionalJavascript/OffCanvasTestBase.php
index 482c8738eea1..3cfb5a195e18 100644
--- a/core/modules/system/tests/src/FunctionalJavascript/OffCanvasTestBase.php
+++ b/core/modules/system/tests/src/FunctionalJavascript/OffCanvasTestBase.php
@@ -16,8 +16,6 @@ abstract class OffCanvasTestBase extends WebDriverTestBase {
* {@inheritdoc}
*/
protected static $modules = [
- // @todo Remove this in https://www.drupal.org/node/3219959
- 'block',
'off_canvas_test',
];
diff --git a/core/modules/views/tests/src/Functional/UserBatchActionTest.php b/core/modules/views/tests/src/Functional/UserBatchActionTest.php
index 4db2f4223218..d8a1870d4ade 100644
--- a/core/modules/views/tests/src/Functional/UserBatchActionTest.php
+++ b/core/modules/views/tests/src/Functional/UserBatchActionTest.php
@@ -18,8 +18,6 @@ class UserBatchActionTest extends BrowserTestBase {
* @var array
*/
protected static $modules = [
- // @todo Remove this in https://www.drupal.org/node/3219959
- 'block',
'user',
'user_batch_action_test',
'views',
diff --git a/core/modules/views/tests/src/Kernel/Plugin/DisplayPageTest.php b/core/modules/views/tests/src/Kernel/Plugin/DisplayPageTest.php
index d596ea333d0d..86579c6cc2db 100644
--- a/core/modules/views/tests/src/Kernel/Plugin/DisplayPageTest.php
+++ b/core/modules/views/tests/src/Kernel/Plugin/DisplayPageTest.php
@@ -32,8 +32,6 @@ class DisplayPageTest extends ViewsKernelTestBase {
* @var array
*/
protected static $modules = [
- // @todo Remove this in https://www.drupal.org/node/3219959
- 'block',
'system',
'user',
'field',
diff --git a/core/tests/Drupal/KernelTests/Core/Asset/ResolvedLibraryDefinitionsFilesMatchTest.php b/core/tests/Drupal/KernelTests/Core/Asset/ResolvedLibraryDefinitionsFilesMatchTest.php
index 026f8d326386..51110a29ccfe 100644
--- a/core/tests/Drupal/KernelTests/Core/Asset/ResolvedLibraryDefinitionsFilesMatchTest.php
+++ b/core/tests/Drupal/KernelTests/Core/Asset/ResolvedLibraryDefinitionsFilesMatchTest.php
@@ -112,10 +112,6 @@ protected function setUp(): void {
return TRUE;
});
- // Install the System module configuration as Olivero's block configuration
- // depends on the system menus.
- // @todo Remove this in https://www.drupal.org/node/3219959
- $this->installConfig('system');
// Install the 'user' entity schema because the workspaces module's install
// hook creates a workspace with default uid of 1. Then the layout_builder
// module's implementation of hook_entity_presave will cause
--
GitLab