From 6923b1a62992f8cfd55d07c248b45e49dc7aff9d Mon Sep 17 00:00:00 2001
From: nod_ <nod_@598310.no-reply.drupal.org>
Date: Thu, 29 Feb 2024 21:08:40 +0100
Subject: [PATCH] Issue #3416304 by sleitner, RoloDMonkey, smustgrave:
Javascript warning from content language and translation page
---
.../content_translation.admin.js | 5 +-
.../ContentTranslationConfigUITest.php | 47 +++++++++++++++++++
2 files changed, 51 insertions(+), 1 deletion(-)
create mode 100644 core/modules/content_translation/tests/src/FunctionalJavascript/ContentTranslationConfigUITest.php
diff --git a/core/modules/content_translation/content_translation.admin.js b/core/modules/content_translation/content_translation.admin.js
index 9d82c900a7da..f24cc4dac51e 100644
--- a/core/modules/content_translation/content_translation.admin.js
+++ b/core/modules/content_translation/content_translation.admin.js
@@ -61,7 +61,10 @@
$element = $fields.filter(filterFieldsList);
}
- if ($element[0].matches(`input[value="${column}"]:checked`)) {
+ if (
+ $element.length &&
+ $element[0].matches(`input[value="${column}"]:checked`)
+ ) {
$fields.prop('checked', true).not($element).prop('disabled', true);
} else {
$fields.prop('disabled', false);
diff --git a/core/modules/content_translation/tests/src/FunctionalJavascript/ContentTranslationConfigUITest.php b/core/modules/content_translation/tests/src/FunctionalJavascript/ContentTranslationConfigUITest.php
new file mode 100644
index 000000000000..ed54b4527079
--- /dev/null
+++ b/core/modules/content_translation/tests/src/FunctionalJavascript/ContentTranslationConfigUITest.php
@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Drupal\Tests\content_translation\FunctionalJavascript;
+
+use Drupal\FunctionalJavascriptTests\WebDriverTestBase;
+
+/**
+ * Tests that the content translation configuration javascript does't fail.
+ *
+ * @group content_translation
+ */
+class ContentTranslationConfigUITest extends WebDriverTestBase {
+
+ /**
+ * {@inheritdoc}
+ */
+ protected static $modules = ['content_translation', 'node'];
+
+ /**
+ * {@inheritdoc}
+ */
+ protected $defaultTheme = 'stark';
+
+ /**
+ * Use the minimal profile.
+ *
+ * @var string
+ */
+ protected $profile = 'standard';
+
+ /**
+ * Tests that the content translation configuration javascript does't fail.
+ */
+ public function testContentTranslationConfigUI() {
+ $content_translation_manager = $this->container->get('content_translation.manager');
+ $content_translation_manager->setEnabled('node', 'article', TRUE);
+ $this->rebuildContainer();
+
+ $admin = $this->drupalCreateUser([], NULL, TRUE);
+ $this->drupalLogin($admin);
+ $this->drupalGet('/admin/config/regional/content-language');
+ $this->failOnJavaScriptErrors();
+ }
+
+}
--
GitLab