From 7e574c13ea6b7d683bceec47870c48e7caab94a7 Mon Sep 17 00:00:00 2001
From: Kunal Sachdev <57170-kunal.sachdev@users.noreply.drupalcode.org>
Date: Wed, 3 May 2023 11:43:26 +0000
Subject: [PATCH] Issue #3357721 by kunal.sachdev, yash.rode, phenaproxima:
PhpExtensionsValidator's wording is needlessly verbose
---
src/Validator/PhpExtensionsValidator.php | 2 +-
tests/src/Kernel/StatusCheck/PhpExtensionsValidatorTest.php | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/Validator/PhpExtensionsValidator.php b/src/Validator/PhpExtensionsValidator.php
index 4349bfa9f7..958bb8536b 100644
--- a/src/Validator/PhpExtensionsValidator.php
+++ b/src/Validator/PhpExtensionsValidator.php
@@ -27,7 +27,7 @@ final class PhpExtensionsValidator extends PackageManagerPhpExtensionsValidator
*/
public function validateXdebug(PreOperationStageEvent $event): void {
if ($this->isExtensionLoaded('xdebug') && $event->stage instanceof CronUpdateStage) {
- $event->addError([$this->t("Xdebug is enabled, currently Cron Updates are not allowed while it is enabled. If Xdebug is not disabled you will not receive security and other updates during cron.")]);
+ $event->addError([$this->t("Unattended updates are not allowed while Xdebug is enabled. You cannot receive updates, including security updates, until it is disabled.")]);
}
elseif ($event instanceof StatusCheckEvent) {
parent::validateXdebug($event);
diff --git a/tests/src/Kernel/StatusCheck/PhpExtensionsValidatorTest.php b/tests/src/Kernel/StatusCheck/PhpExtensionsValidatorTest.php
index 0211949835..edcbbc3790 100644
--- a/tests/src/Kernel/StatusCheck/PhpExtensionsValidatorTest.php
+++ b/tests/src/Kernel/StatusCheck/PhpExtensionsValidatorTest.php
@@ -37,7 +37,7 @@ class PhpExtensionsValidatorTest extends AutomaticUpdatesKernelTestBase {
t('Xdebug is enabled, which may have a negative performance impact on Package Manager and any modules that use it.'),
]);
$error_result = ValidationResult::createError([
- t("Xdebug is enabled, currently Cron Updates are not allowed while it is enabled. If Xdebug is not disabled you will not receive security and other updates during cron."),
+ t("Unattended updates are not allowed while Xdebug is enabled. You cannot receive updates, including security updates, until it is disabled."),
]);
$config = $this->config('automatic_updates.settings');
@@ -88,7 +88,7 @@ class PhpExtensionsValidatorTest extends AutomaticUpdatesKernelTestBase {
$this->container->get('cron')->run();
// The update should have been staged, but then stopped with an error.
$this->assertUpdateStagedTimes(1);
- $this->assertTrue($logger->hasRecordThatContains("Xdebug is enabled, currently Cron Updates are not allowed while it is enabled. If Xdebug is not disabled you will not receive security and other updates during cron.", RfcLogLevel::ERROR));
+ $this->assertTrue($logger->hasRecordThatContains("Unattended updates are not allowed while Xdebug is enabled. You cannot receive updates, including security updates, until it is disabled.", RfcLogLevel::ERROR));
}
/**
--
GitLab