Pol Dellaiera (e9996c46) at 28 Nov 09:46
Add checking whether we are in a synchronization state.
Pol Dellaiera (e9996c46) at 28 Nov 09:41
Add checking whether we are in a synchronization state.
... and 1 more commit
Thanks!
Pol Dellaiera (96fe9914) at 22 Nov 17:47
Update blacklisted paths to support new CSS/JS aggregate method int...
Closes #3396139
Pol Dellaiera (f7d3bbc7) at 29 Oct 22:06
Issue #3375638: Undefined array key "height" and "width" when using...
Thanks for your patience!
Pol Dellaiera (f7d3bbc7) at 03 Oct 09:12
Issue #3375638: Undefined array key "height" and "width" when using...
if (file_exists($url)) {
Why all these extra spaces?
Hi,
I see that we are removing a lot of temporary variables, and that's great. However, this is always a battle between code readability, code maintenance and understanding.
Despite the fact that this example has not a lot of local variables, I found this line [$vars['width'], $vars['height']] = getimagesize($url);
very confusing but very handy.
The $uri
variable can be used within $vars
$uri
can be used here.
Thanks for the changes, here's a proposal of something smaller without almost no local variables.
What do you think?
[$width, $height] = file_exists($this->fileUrlGenerator->generateAbsoluteString($file->getFileUri()))
? getimagesize($url)
: [1, 1];
Hi,
I just made a quick review, can you please give some feedback and adjust accordingly?
Thanks in advance for fixing this!
list($width, $height) = getimagesize($this->fileUrlGenerator->generateAbsoluteString($file->getFileUri()));
Could you please do this? There's no need to create extra variables for this.
Also, what happens when the return of getimagesize
is false?
Thanks for fixing the previous review comments.
I added a few more comments, let me know if it's OK for you to fix.